CheckPluginAbstract::getImportances() - Code Metrics - Inspection of "~" - turnaev/monitor-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 13c004...92d87a )

by Vladimir

created 2018-10-15 04:10 UTC

CheckPluginAbstract::getImportances() A

↳ Parent: CheckPluginAbstract

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	7
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

/**

 * This file is part of the `tvi/monitor-bundle` project.

 * (c) https://github.com/turnaev/monitor-bundle/graphs/contributors

 * For the full copyright and license information, please view the LICENSE.md

 * file that was distributed with this source code.

*/

Coding Style introduced 2018-09-26 08:01 UTC by

PHP version not specified

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @category tag in file comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @package tag in file comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @author tag in file comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @license tag in file comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @link tag in file comment

namespace Tvi\MonitorBundle\Check;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;

use Symfony\Component\Config\Definition\Builder\NodeDefinition;

use Symfony\Component\Config\Definition\Builder\TreeBuilder;

use Tvi\MonitorBundle\Exception\FeatureRequired;

/**

Coding Style introduced 2018-09-27 10:13 UTC by

Missing short description in doc comment

 * @author Vladimir Turnaev <[email protected]>

*/

Coding Style introduced 2018-09-24 09:59 UTC by

Missing @category tag in class comment

Coding Style introduced 2018-09-24 09:59 UTC by

Missing @package tag in class comment

Coding Style introduced 2018-09-24 09:59 UTC by

Missing @license tag in class comment

Coding Style introduced 2018-09-24 09:59 UTC by

Missing @link tag in class comment

abstract class CheckPluginAbstract implements CheckPluginInterface

/**

Coding Style introduced 2018-10-03 06:30 UTC by

Missing short description in doc comment

Coding Style introduced 2018-10-08 12:21 UTC by

Parameter $checkSettings should have a doc-comment as per coding-style.

     * @throws FeatureRequired

*/

Coding Style introduced 2018-10-08 12:21 UTC by

Missing @return tag in function comment

    public function checkRequirements(array $checkSettings)

/**

Coding Style introduced 2018-10-04 07:50 UTC by

Missing short description in doc comment

Coding Style introduced 2018-10-04 07:50 UTC by

Parameter $builder should have a doc-comment as per coding-style.

     * @return NodeDefinition|ArrayNodeDefinition

*/

    public function checkConf(TreeBuilder $builder): NodeDefinition

        $node = $builder

            ->root(static::CHECK_NAME, 'array')

            ->info(static::DESCR); //--

        $this->_check($node);

        return $node;

/**

Coding Style introduced 2018-10-04 07:50 UTC by

Missing short description in doc comment

Coding Style introduced 2018-10-04 07:50 UTC by

Parameter $builder should have a doc-comment as per coding-style.

     * @return NodeDefinition|ArrayNodeDefinition

*/

    public function checkFactoryConf(TreeBuilder $builder): NodeDefinition

        $node = $builder

            ->root(static::CHECK_NAME.'_factory', 'array')

            ->info(static::DESCR)

            ->children()

                ->arrayNode('items')

Coding Style introduced 2018-10-04 11:37 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

                    ->prototype('array'); //--

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

        $node = $this->_check($node)

                    ->end()

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

                ->end()

Bug introduced 2018-10-04 07:50 UTC by

The method end() does not exist on Symfony\Component\Config...der\NodeParentInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Symfony\Component\Config...ion\Builder\TreeBuilder. Are you sure you never get one of those? ( Ignorable by Annotation )

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

            ->end();

        $this->_addition($node);

        return $node;

/**

Coding Style introduced 2018-10-04 07:50 UTC by

Missing short description in doc comment

     * @param NodeDefinition|ArrayNodeDefinition $node

Coding Style introduced 2018-09-27 10:13 UTC by

Missing parameter comment

     * @return NodeDefinition|ArrayNodeDefinition

*/

    protected function _addition(NodeDefinition $node): NodeDefinition

Coding Style introduced 2018-10-04 07:50 UTC by

Protected method name "CheckPluginAbstract::_addition" must not be prefixed with an underscore

        $this->_group($node);

        $this->_tags($node);

        $this->_importance($node);

        $this->_label($node);

        $this->_descr($node);

        return $node;

/**

Coding Style introduced 2018-10-12 13:32 UTC by

Missing short description in doc comment

     * @param NodeDefinition|ArrayNodeDefinition $node

Coding Style introduced 2018-10-12 13:32 UTC by

Missing parameter comment

     * @return NodeDefinition|ArrayNodeDefinition

*/

    abstract protected function _check(NodeDefinition $node): NodeDefinition;

Coding Style introduced 2018-10-03 06:30 UTC by

Protected method name "CheckPluginAbstract::_check" must not be prefixed with an underscore

/**

Coding Style introduced 2018-10-04 07:50 UTC by

Missing short description in doc comment

     * @param NodeDefinition|ArrayNodeDefinition $node

Coding Style introduced 2018-10-04 07:50 UTC by

Missing parameter comment

     * @return NodeDefinition|ArrayNodeDefinition

*/

    protected function _label(NodeDefinition $node): NodeDefinition

Coding Style introduced 2018-10-03 06:30 UTC by

Protected method name "CheckPluginAbstract::_label" must not be prefixed with an underscore

        return $node

            ->children()

                ->scalarNode('label')->defaultNull()->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

100

            ->end();

101

102

103

/**

Coding Style introduced 2018-10-04 07:50 UTC by

Missing short description in doc comment

104

     * @param NodeDefinition|ArrayNodeDefinition $node

Coding Style introduced 2018-10-04 07:50 UTC by

Missing parameter comment

105

106

     * @return NodeDefinition|ArrayNodeDefinition

107

*/

108

    protected function _importance(ArrayNodeDefinition $node): NodeDefinition

Coding Style introduced 2018-10-12 13:32 UTC by

Protected method name "CheckPluginAbstract::_importance" must not be prefixed with an underscore

109

110

        return $node

111

            ->children()

112

                ->scalarNode('importance')

Coding Style introduced 2018-10-12 13:32 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

113

                    ->validate()

Coding Style introduced 2018-10-12 13:32 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

114

                        ->ifTrue(static function ($value) {

Coding Style introduced 2018-10-12 15:24 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

Coding Style introduced 2018-10-12 15:24 UTC by

The opening parenthesis of a multi-line function call should be the last content on the line.

115

                            if (null === $value) {

116

                                return false;

117

                            } else if (\in_array($value, CheckAbstract::getImportances(), true)) {

118

                                return false;

119

120

                            return true;

121

})

Coding Style introduced 2018-10-12 13:32 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

122

                        ->thenInvalid(sprintf('importance has to one of value [%s]', implode(', ', CheckAbstract::getImportances())))

123

                    ->end()

124

                    ->defaultNull()

125

                ->end()

126

            ->end();

127

128

129

/**

Coding Style introduced 2018-10-04 07:50 UTC by

Missing short description in doc comment

130

     * @param NodeDefinition|ArrayNodeDefinition $node

Coding Style introduced 2018-10-04 07:50 UTC by

Missing parameter comment

131

132

     * @return NodeDefinition|ArrayNodeDefinition

133

*/

134

    protected function _group(NodeDefinition $node): NodeDefinition

Coding Style introduced 2018-10-03 06:30 UTC by

Protected method name "CheckPluginAbstract::_group" must not be prefixed with an underscore

135

136

        return $node

137

            ->children()

138

                ->scalarNode('group')

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

139

                    ->cannotBeEmpty()

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

140

                ->end()

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

141

                ->scalarNode('_group')

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

142

                    ->defaultValue(static::GROUP)

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

143

                    ->cannotBeOverwritten()

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

144

                ->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

145

            ->end();

146

147

148

/**

Coding Style introduced 2018-10-04 07:50 UTC by

Missing short description in doc comment

149

     * @param NodeDefinition|ArrayNodeDefinition $node

Coding Style introduced 2018-10-04 07:50 UTC by

Missing parameter comment

150

151

     * @return NodeDefinition|ArrayNodeDefinition

152

*/

153

    protected function _tags(NodeDefinition $node): NodeDefinition

Coding Style introduced 2018-10-03 06:30 UTC by

Protected method name "CheckPluginAbstract::_tags" must not be prefixed with an underscore

154

155

        return $node

156

            ->children()

157

                ->arrayNode('tags')

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

158

                    ->prototype('scalar')->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

159

                ->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

160

            ->end();

161

162

163

/**

Coding Style introduced 2018-10-04 07:50 UTC by

Missing short description in doc comment

164

     * @param NodeDefinition|ArrayNodeDefinition $node

Coding Style introduced 2018-10-04 07:50 UTC by

Missing parameter comment

165

166

     * @return NodeDefinition|ArrayNodeDefinition

167

*/

168

    protected function _descr(NodeDefinition $node): NodeDefinition

Coding Style introduced 2018-10-04 07:50 UTC by

Protected method name "CheckPluginAbstract::_descr" must not be prefixed with an underscore

169

170

        return $node

171

            ->children()

172

                ->scalarNode('descr')

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

173

                    ->defaultNull()

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

174

                ->end()

Coding Style introduced 2018-10-04 07:50 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

175

            ->end();

176

177

178

turnaev / monitor-bundle

Push — master ( 13c004...92d87a )

CheckPluginAbstract::getImportances() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like