ApiController::checkStatusAction() - Code Metrics - Inspection of "~" - turnaev/monitor-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 54f39c...6dfcfe )

by Vladimir

created 2018-10-04 12:12 UTC

ApiController::checkStatusAction() A

↳ Parent: ApiController

Complexity

Conditions	4
Paths	23

Size

Total Lines	29
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4.3244

Importance

Changes

Metric	Value
eloc	16
dl	0
loc	29
ccs	8
cts	11
cp	0.7272
rs	9.7333
c	0
b	0
f	0
cc	4
nc	23
nop	2
crap	4.3244

<?php

/**
 * This file is part of the `tvi/monitor-bundle` project.
 *
 * (c) https://github.com/turnaev/monitor-bundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */


namespace Tvi\MonitorBundle\Controller;

use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Tvi\MonitorBundle\Exception\HttpException;
use Tvi\MonitorBundle\Reporter\Api;
use Tvi\MonitorBundle\Reporter\ReporterManager;
use Tvi\MonitorBundle\Runner\RunnerManager;

/**

 * @author Vladimir Turnaev <[email protected]>
 */

class ApiController
{
    /**

     * @var RunnerManager
     */
    protected $runnerManager;

    /**

     * @var ReporterManager
     */
    protected $reporterManager;

    public function __construct(RunnerManager $runnerManager, ReporterManager $reporterManager)

    {
        $this->runnerManager = $runnerManager;
        $this->reporterManager = $reporterManager;
    }

    public function checkListAction(Request $request): JsonResponse

    {
        try {
            list($checks, $groups, $tags) = $this->getFilterParams($request);

            $runner = $this->runnerManager->getRunner($checks, $groups, $tags);

            $breakOnFailure = (bool) $request->get('bof', false);
            $runner->setBreakOnFailure($breakOnFailure);

            /** @var $reporter Api */

            $reporter = $this->reporterManager->getReporter('api');

            $runner->addReporter($reporter);
            $runner->run();

            return new JsonResponse([

                'statusCode' => $reporter->getStatusCode(),
                'statusName' => $reporter->getStatusName(),

                'successes' => $reporter->getSuccessCount(),
                'warnings' => $reporter->getWarningCount(),
                'failures' => $reporter->getFailureCount(),
                'unknowns' => $reporter->getUnknownCount(),
                'total' => $reporter->getTotalCount(),

                'checks' => $reporter->getCheckResults(),
            ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
        } catch (\Exception $e) {
            $e = new HttpException(404, $e->getMessage());

            return new JsonResponse($e->toArray(), $e->getStatusCode());
        }
    }

    public function checkAction(Request $request, string $check): JsonResponse
    public function checkAction(/** @scrutinizer ignore-unused */ Request $request, string $check): JsonResponse
    {
        try {
            $runner = $this->runnerManager->getRunner($check);

            /** @var $reporter Api */

            $reporter = $this->reporterManager->getReporter('api');

            $runner->addReporter($reporter);
            $runner->run();

            $res = $reporter->getCheckResults()[0];

            return new JsonResponse($res);
        } catch (\Exception $e) {
            $e = new HttpException(404, $e->getMessage());

            return new JsonResponse($e->toArray(), $e->getStatusCode());
        }
    }

    public function checkStatusAction(Request $request, ?string $check = null): Response

    {
        try {

            list($checks, $groups, $tags) = $this->getFilterParams($request);

            if($check !== null) {

                $runner = $this->runnerManager->getRunner($check);
            } else {
                $runner = $this->runnerManager->getRunner($checks, $groups, $tags);
            }

            $breakOnFailure = (bool) $request->get('bof', false);
            $runner->setBreakOnFailure($breakOnFailure);

            /** @var $reporter Api */

            $reporter = $this->reporterManager->getReporter('api');

            $runner->addReporter($reporter);
            $runner->run();

            $code = $reporter->getStatusCode() == $reporter::STATUS_CODE_SUCCESS ? 200 : 500;

            return new Response($reporter->getStatusName(), $code);

        } catch (\Exception $e) {
            $e = new HttpException(404, $e->getMessage());

            return new JsonResponse($e->toArray(), $e->getStatusCode());
        }
    }

    /**

     * @return array [$checks, $groups, $tags],
     */
    private function getFilterParams(Request $request): array

    {
        $checks = $request->get('check', []);
        if (\is_scalar($checks)) {
            $checks = $checks ? [$checks] : [];
        }
        $checks = !\is_array($checks) ? [$checks] : $checks;

        $groups = $request->get('group', []);
        if (\is_scalar($groups)) {
            $groups = $groups ? [$groups] : [];
        }
        $groups = !\is_array($groups) ? [$groups] : $groups;

        $tags = $request->get('tag', []);
        if (\is_scalar($tags)) {
            $tags = $tags ? [$tags] : [];
        }
        $tags = !\is_array($tags) ? [$tags] : $tags;

        return [$checks, $groups, $tags];
    }
}


turnaev / monitor-bundle

Push — master ( 54f39c...6dfcfe )

ApiController::checkStatusAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like