Tvi\MonitorBundle\Controller\ApiInfoTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	checkInfoListAction()	0	23	3
A	tagInfoListAction()	0	19	3
A	groupInfoListAction()	0	11	2

<?php

/**
 * This file is part of the `tvi/monitor-bundle` project.
 *
 * (c) https://github.com/turnaev/monitor-bundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Tvi\MonitorBundle\Controller;

use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Tvi\MonitorBundle\Exception\HttpException;
use Tvi\MonitorBundle\Reporter\ReporterManager;
use Tvi\MonitorBundle\Runner\RunnerManager;

/**

Missing short description in doc comment

 * @property RunnerManager   $runnerManager
 * @property ReporterManager $reporterManager
 *
 * @author Vladimir Turnaev <turnaev@gmail.com>
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

trait ApiInfoTrait
{
    public function checkInfoListAction(Request $request): JsonResponse

Missing doc comment for function checkInfoListAction()

    {
        try {
            list($checks, $groups, $tags) = $this->getFilterParams($request);

It seems like getFilterParams() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $checks = $this->runnerManager->findChecks($checks, $groups, $tags);

            $data = [];
            foreach ($checks as $check) {
                $tags = $check->getTags();

                $d = ['check' => $check->getId(), 'label' => $check->getLabel(), 'group' => $check->getGroup(), 'tags' => $tags, 'Descr' => $check->getDescr()];
                $d = array_filter($d, static function ($v) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                    return !empty($v);
                });

For multi-line function calls, the closing parenthesis should be on a new line.

                $data[] = $d;
            }

            return new JsonResponse($data);
        } catch (\Exception $e) {
            $e = new HttpException(500, $e->getMessage());

            return new JsonResponse($e->toArray(), $e->getStatusCode());
        }
    }

    public function groupInfoListAction(Request $request): JsonResponse

Missing doc comment for function groupInfoListAction()

    {
        try {
            list($_, $groups, $_) = $this->getFilterParams($request);
            $groups = $this->runnerManager->findGroups($groups);

            return new JsonResponse($groups);
        } catch (\Exception $e) {
            $e = new HttpException(500, $e->getMessage());

            return new JsonResponse($e->toArray(), $e->getStatusCode());
        }
    }

    public function tagInfoListAction(Request $request): JsonResponse

Missing doc comment for function tagInfoListAction()

    {
        try {
            try {
                list($_, $_, $tags) = $this->getFilterParams($request);
                $tags = $this->runnerManager->findTags($tags);
v($tags);

The function v was not found. Maybe you did not declare it correctly or list all dependencies?

Line indented incorrectly; expected at least 16 spaces, found 0

                exit;

Using exit here is not recommended.

In this branch, the function will implicitly return null which is incompatible with the type-hinted return Symfony\Component\HttpFoundation\JsonResponse. Consider adding a return statement or allowing null as return value.

                return new JsonResponse($tags);

return new Symfony\Component\HttpFoundation\JsonResponse($tags) is not reachable.

            } catch (\Exception $e) {
                $e = new HttpException(500, $e->getMessage());

                return new JsonResponse($e->toArray(), $e->getStatusCode());
            }
        } catch (\Exception $e) {
            $e = new HttpException(500, $e->getMessage());

            return new JsonResponse($e->toArray(), $e->getStatusCode());
        }
    }
}