Tvi\MonitorBundle\Controller\ApiCheckTrait

Complexity

Total Complexity

16

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Test Coverage

Coverage

83.33%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	checkAction()	0	25	4
A	checkStatusAction()	0	25	5
A	checkStatusesAction()	0	27	5
A	checksAction()	0	32	2

<?php

/**
 * This file is part of the `tvi/monitor-bundle` project.
 *
 * (c) https://github.com/turnaev/monitor-bundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Tvi\MonitorBundle\Controller;

use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use JMS\Serializer\Serializer;
use Tvi\MonitorBundle\Exception\HttpException;
use Tvi\MonitorBundle\Reporter\Api;
use Tvi\MonitorBundle\Reporter\ReporterManager;
use Tvi\MonitorBundle\Runner\RunnerManager;

/**

Missing short description in doc comment

 * @property RunnerManager   $runnerManager
 * @property ReporterManager $reporterManager
 * @property Serializer      $serializer
 *
 * @author Vladimir Turnaev <turnaev@gmail.com>
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

trait ApiCheckTrait
{
    public function checkAction(Request $request, string $id): JsonResponse

The parameter $request is not used and could be removed.

Missing doc comment for function checkAction()

    {
        try {
            $runner = $this->runnerManager->getRunner($id);

            /** @var $reporter Api */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

            $reporter = $this->reporterManager->getReporter('api');

            $runner->addReporter($reporter);
            $runner->run();

            $res = $reporter->getCheckResults();

            if (isset($res[0])) {
                return JsonResponse::fromJsonString($this->serializer->serialize($res[0], 'json'));
            }

            throw new NotFoundHttpException(sprintf('Check %s not found', $id));
        } catch (NotFoundHttpException $e) {
            $e = new HttpException(404, $e->getMessage());
            $json = $this->serializer->serialize($e->toArray(), 'json');

            return JsonResponse::fromJsonString($json, $e->getStatusCode());
        } catch (\Exception $e) {
            return new Response($e->getMessage(), 500);

The expression return new Symfony\Component\HttpFoundation\Response($e->getMessage(), 500) returns the type Symfony\Component\HttpFoundation\Response which includes types incompatible with the type-hinted return Symfony\Component\HttpFoundation\JsonResponse.

        }
    }

    public function checksAction(Request $request): JsonResponse

Missing doc comment for function checksAction()

    {
        try {
            list($checks, $groups, $tags) = $this->getFilterParams($request);

It seems like getFilterParams() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $runner = $this->runnerManager->getRunner($checks, $groups, $tags);

            $breakOnFailure = (bool) $request->get('break-on-failure', false);
            $runner->setBreakOnFailure($breakOnFailure);

            /** @var $reporter Api */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

            $reporter = $this->reporterManager->getReporter('api');

            $runner->addReporter($reporter);
            $runner->run();
            $data = [
                'statusCode' => $reporter->getStatusCode(),
                'statusName' => $reporter->getStatusName(),

                'successes' => $reporter->getSuccessCount(),
                'warnings' => $reporter->getWarningCount(),
                'failures' => $reporter->getFailureCount(),
                'unknowns' => $reporter->getUnknownCount(),
                'total' => $reporter->getTotalCount(),

                'checks' => $reporter->getCheckResults(),
            ];
            $json = $this->serializer->serialize($data, 'json');

            return JsonResponse::fromJsonString($json);
        } catch (\Exception $e) {
            return new Response($e->getMessage(), 500);

The expression return new Symfony\Component\HttpFoundation\Response($e->getMessage(), 500) returns the type Symfony\Component\HttpFoundation\Response which includes types incompatible with the type-hinted return Symfony\Component\HttpFoundation\JsonResponse.

        }
    }

    public function checkStatusAction(Request $request, string $id): Response

Missing doc comment for function checkStatusAction()

    {
        try {
            $runner = $this->runnerManager->getRunner($id);

            $breakOnFailure = (bool) $request->get('break-on-failure', false);
            $runner->setBreakOnFailure($breakOnFailure);

            /** @var $reporter Api */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

            $reporter = $this->reporterManager->getReporter('api');

            $runner->addReporter($reporter);
            $runner->run();

            if ($reporter->getTotalCount()) {
                $code = $reporter->getStatusCode() === $reporter::STATUS_CODE_SUCCESS ? 200 : 500;

                return new Response($reporter->getStatusName(), $code);
            }

            throw new NotFoundHttpException(sprintf('Check %s not found', $id));
        } catch (NotFoundHttpException $e) {
            return new Response($e->getMessage(), $e->getStatusCode());
        } catch (\Exception $e) {
            return new Response($e->getMessage(), 502);
        }
    }

    public function checkStatusesAction(Request $request): Response

Missing doc comment for function checkStatusesAction()

    {
        try {
            list($checks, $groups, $tags) = $this->getFilterParams($request);

            $runner = $this->runnerManager->getRunner($checks, $groups, $tags);

            $breakOnFailure = (bool) $request->get('break-on-failure', false);
            $runner->setBreakOnFailure($breakOnFailure);

            /** @var $reporter Api */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

            $reporter = $this->reporterManager->getReporter('api');

            $runner->addReporter($reporter);
            $runner->run();

            if ($reporter->getTotalCount()) {
                $code = $reporter->getStatusCode() === $reporter::STATUS_CODE_SUCCESS ? 200 : 500;

                return new Response($reporter->getStatusName(), $code);
            }

            throw new NotFoundHttpException('Check(s) not found');
        } catch (NotFoundHttpException $e) {
            return new Response($e->getMessage(), $e->getStatusCode());
        } catch (\Exception $e) {
            return new Response($e->getMessage(), 502);
        }
    }
}