Tvi\MonitorBundle\Command\CheckInfoCommand::execute()

Complexity

Conditions	8
Paths	56

Size

Total Lines	45
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

0

<?php
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $namesFilter = $input->getOption('name');
        $namesFilter = ($namesFilter) ? $namesFilter : null;

        $groupsFilter = $input->getOption('groups');
        $groupsFilter = ($groupsFilter) ? $groupsFilter : null;

        $tagsFilter = $input->getOption('tags');
        $tagsFilter = ($tagsFilter) ? $tagsFilter : null;

        $manager = $this->manager;
        $checks = $manager->findChecks($namesFilter, $groupsFilter, $tagsFilter);

It seems like $groupsFilter can also be of type true; however, parameter $groups of Tvi\MonitorBundle\Runner\Manager::findChecks() does only seem to accept null|string|string[], maybe add an additional type check?

It seems like $tagsFilter can also be of type true; however, parameter $tags of Tvi\MonitorBundle\Runner\Manager::findChecks() does only seem to accept null|string|string[], maybe add an additional type check?

It seems like $namesFilter can also be of type true; however, parameter $alias of Tvi\MonitorBundle\Runner\Manager::findChecks() does only seem to accept null|string|string[], maybe add an additional type check?

        $table = new Table($output);
        $table->setHeaders(['Group', 'Tag(s)', 'Check', 'Label']);

        $groupOld = null;
        foreach ($checks as $check) {

            $tags = $check->getTags();
            if ($tags) {
                $tags = $manager->findTags($check->getTags());
                $tags = array_map(function($t) {

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 space after FUNCTION keyword; 0 found

                    return $t->getLabel();
                }, $tags);

For multi-line function calls, the closing parenthesis should be on a new line.

                $tags = implode(', ', $tags);
            } else {
                $tags = null;
            }

            $group = null;
            $groupNew = sprintf('<fg=yellow;options=bold>%-8s</>', $check->getGroup());
            if($groupOld != $groupNew) {

Expected "if (...) {\n"; found "if(...) {\n"

                if($groupOld) {

Expected "if (...) {\n"; found "if(...) {\n"

                    $table->addRow(new TableSeparator());
                }
                $group = $groupOld = $groupNew;
            }
            $checkAlias = sprintf('<info>%s</info>', $check->getId());
            $table->addRow([$group, $tags, $checkAlias, $check->getLabel()]);
        }

        $table->render();
    }