Tvi\MonitorBundle\Check\http\GuzzleHttpService\Plugin::checkFactoryConf()

Complexity

Conditions	5
Paths	1

Size

Total Lines	42
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	5.0144

Importance

Changes

0

<?php
    public function checkFactoryConf(TreeBuilder $builder): ArrayNodeDefinition

Missing doc comment for function checkFactoryConf()

    {
        /* @var ArrayNodeDefinition $node */
        $node = parent::checkFactoryConf($builder);
        $keys = [
            'headers',
            'options',
            'statusCode',
            'method',
            'content',
            'body',
            'withData',
        ];

        $node = $node
            ->beforeNormalization()
            ->ifArray()
            ->then(static function ($value) use ($keys) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                foreach ($keys as $key) {
                    if (isset($value[$key])) {
                        foreach ($value['items'] as &$v) {
                            if (!array_key_exists($key, $v['check'])) {
                                $v['check'][$key] = $value[$key];
                            }
                        }
                    }
                }

                return $value;
            })

For multi-line function calls, the closing parenthesis should be on a new line.

            ->end();
        $node->children()
            ->variableNode('headers')->end()
            ->variableNode('options')->end()
            ->integerNode('statusCode')->end()
            ->scalarNode('method')->end()
            ->scalarNode('content')->end()
            ->scalarNode('body')->end()
            ->booleanNode('withData')->end()
        ->end();

Object operator not indented correctly; expected 12 spaces but found 8

        return $node;

The expression return $node returns the type Symfony\Component\Config\Definition\Builder\NodeDefinition which includes types incompatible with the type-hinted return Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition.

    }