turahe / master-data

src/Models/Model.php

<?php

namespace Turahe\Master\Models;

use Illuminate\Database\Eloquent\Model as BaseModel;
use Turahe\Master\Traits\AutoFilter;
use Turahe\Master\Traits\AutoSort;

/**
 * Class Model.
 */
abstract class Model extends BaseModel
{
    use AutoFilter;
    use AutoSort;
    /**
     * @var string
     */
    protected $keyType = 'string';

    /**
     * @var string[]
     */
    protected $searchableColumns = ['id', 'name'];

    /**
     * Model constructor.
     *
     * @param array $attributes
     */
    public function __construct(array $attributes = [])
    {
        parent::__construct($attributes);
    }

    /**
     * @param $query
     * @param $keyword
     */
    public function scopeSearch($query, $keyword)
    {
        if ($keyword && $this->searchableColumns) {

The expression $this->searchableColumns of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $query->whereLike($this->searchableColumns, $keyword);
        }
    }
}