turahe / master-data

src/Commands/CurrencyManage.php

<?php


namespace Turahe\Master\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Arr;

class CurrencyManage extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'currency:manage
                                {action : Action to perform (add, update, or delete)}
                                {currency : Code or comma separated list of codes for currencies}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Manage currency values';

    /**
     * Currency storage instance
     *
     * @var \Torann\Currency\Contracts\DriverInterface

The type Torann\Currency\Contracts\DriverInterface was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    protected $storage;

    /**
     * All installable currencies.
     *
     * @var array
     */
    protected $currencies;

    /**
     * Create a new command instance.
     */
    public function __construct()
    {
        $this->storage = app('currency')->getDriver();

The method getDriver() does not exist on Illuminate\Contracts\Foundation\Application.

        $this->currencies = include(__DIR__ . '/../../resources/currencies.php');

        parent::__construct();
    }

    /**
     * Execute the console command for Laravel 5.4 and below
     *
     * @return void
     */
    public function fire()
    {
        $this->handle();
    }

    /**
     * Execute the console command.
     *
     * @return void
     */
    public function handle()
    {
        $action = $this->getActionArgument(['add', 'update', 'delete']);

        foreach ($this->getCurrencyArgument() as $currency) {
            $this->$action(strtoupper($currency));
        }
    }

    /**
     * Add currency to storage.
     *
     * @param string $currency
     *
     * @return void
     */
    protected function add($currency)
    {
        if (($data = $this->getCurrency($currency)) === null) {

The condition $data = $this->getCurrency($currency) === null is always false.

            $this->error("Currency \"{$currency}\" not found");
            return;
        }

        $this->output->write("Adding {$currency} currency...");

        $data['code'] = $currency;

        if (is_string($result = $this->storage->create($data))) {
            $this->output->writeln('<error>' . ($result ?: 'Failed') . '</error>');
        } else {
            $this->output->writeln("<info>success</info>");
        }
    }

    /**
     * Update currency in storage.
     *
     * @param string $currency
     *
     * @return void
     */
    protected function update($currency)
    {
        if (($data = $this->getCurrency($currency)) === null) {

The condition $data = $this->getCurrency($currency) === null is always false.

            $this->error("Currency \"{$currency}\" not found");
            return;
        }

        $this->output->write("Updating {$currency} currency...");

        if (is_string($result = $this->storage->update($currency, $data))) {
            $this->output->writeln('<error>' . ($result ?: 'Failed') . '</error>');
        } else {
            $this->output->writeln("<info>success</info>");
        }
    }

    /**
     * Delete currency from storage.
     *
     * @param string $currency
     *
     * @return void
     */
    protected function delete($currency)
    {
        $this->output->write("Deleting {$currency} currency...");

        if (is_string($result = $this->storage->delete($currency))) {
            $this->output->writeln('<error>' . ($result ?: 'Failed') . '</error>');
        } else {
            $this->output->writeln("<info>success</info>");
        }
    }

    /**
     * Get currency argument.
     *
     * @return array
     */
    protected function getCurrencyArgument()
    {
        // Get the user entered value
        $value = preg_replace('/\s+/', '', $this->argument('currency'));

        // Return all currencies if requested
        if ($value === 'all') {
            return array_keys($this->currencies);
        }

        return explode(',', $value);
    }

    /**
     * Get action argument.
     *
     * @param array $validActions
     *
     * @return array
     */
    protected function getActionArgument($validActions = [])
    {
        $action = strtolower($this->argument('action'));

It seems like $this->argument('action') can also be of type string[]; however, parameter $str of strtolower() does only seem to accept string, maybe add an additional type check?

        if (in_array($action, $validActions) === false) {
            throw new \RuntimeException("The \"{$action}\" option does not exist.");
        }

        return $action;
    }

    /**
     * Get currency data.
     *
     * @param string $currency
     *
     * @return array
     */
    protected function getCurrency($currency)
    {
        return Arr::get($this->currencies, $currency);
    }
}