Turahe\Likeable\Observers\ModelObserver

Complexity

Total Complexity

4

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	deleted()	0	7	2
A	removeLikesOnDelete()	0	3	2

<?php

namespace Turahe\Likeable\Observers;

use Turahe\Likeable\Contracts\Likeable as LikeableContract;

/**
 * Class ModelObserver.
 */
class ModelObserver
{
    /**
     * Handle the deleted event for the model.
     *
     * @param \Turahe\Likeable\Contracts\Likeable $likeable
     * @return void
     */
    public function deleted(LikeableContract $likeable)
    {
        if (! $this->removeLikesOnDelete($likeable)) {
            return;
        }

        $likeable->removeLikes();
    }

    /**
     * Should remove likes on model delete (defaults to true).
     *
     * @param \Turahe\Likeable\Contracts\Likeable $likeable
     * @return bool
     */
    protected function removeLikesOnDelete(LikeableContract $likeable)
    {
        return isset($likeable->removeLikesOnDelete) ? $likeable->removeLikesOnDelete : true;

Accessing removeLikesOnDelete on the interface Turahe\Likeable\Contracts\Likeable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}