ttskch / esaba

src/Service/AccessController.php

<?php

declare(strict_types=1);

namespace App\Service;

class AccessController
{
    public function __construct(
        private ?array $publicCategories,
        private ?array $publicTags,
        private ?array $privateCategories,
        private ?array $privateTags,
    ) {
    }

    public function isPublic(?string $category, array $tags): bool
    {
        if ($this->matchesPrivateConditions($category, $tags)) {
            return false;
        }

        return $this->matchesPublicConditions($category, $tags);
    }

    private function matchesPublicConditions(?string $category, array $tags): bool
    {
        if (empty($this->publicCategories) && empty($this->publicTags)) {
            return true;
        }

        if ($this->categoryIsUnderOneOf($category, $this->publicCategories)) {

It seems like $this->publicCategories can also be of type null; however, parameter $haystacks of App\Service\AccessController::categoryIsUnderOneOf() does only seem to accept array, maybe add an additional type check?

            return true;
        }

        if ($this->atLeastOneTagIsIn($tags, $this->publicTags)) {

It seems like $this->publicTags can also be of type null; however, parameter $haystacks of App\Service\AccessController::atLeastOneTagIsIn() does only seem to accept array, maybe add an additional type check?

            return true;
        }

        return false;
    }

    private function matchesPrivateConditions(?string $category, array $tags): bool
    {
        return $this->categoryIsUnderOneOf($category, $this->privateCategories) || $this->atLeastOneTagIsIn($tags, $this->privateTags);

It seems like $this->privateTags can also be of type null; however, parameter $haystacks of App\Service\AccessController::atLeastOneTagIsIn() does only seem to accept array, maybe add an additional type check?

It seems like $this->privateCategories can also be of type null; however, parameter $haystacks of App\Service\AccessController::categoryIsUnderOneOf() does only seem to accept array, maybe add an additional type check?

    }

    private function categoryIsUnderOneOf(?string $needle, array $haystacks): bool
    {
        foreach ($haystacks as $haystack) {
            if (preg_match(sprintf('#^%s#', $haystack), (string) $needle)) {
                return true;
            }
        }

        return false;
    }

    private function atLeastOneTagIsIn(array $needles, array $haystacks): bool
    {
        foreach ($haystacks as $haystack) {
            foreach ($needles as $needle) {
                if ($needle === $haystack) {
                    return true;
                }
            }
        }

        return false;
    }
}