trivago / chapi

src/BusinessCase/Comparison/CompositeJobComparisonBusinessCase.php

Spacing +7 added lines, -7 removed lines

@@ -34,10 +34,10 @@ 
     public function getLocalMissingJobs()
     {
         $_aMissingJobs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $missing = $jobComparers->getLocalMissingJobs();
-            $_aMissingJobs = array_merge($_aMissingJobs,  $missing);
+            $_aMissingJobs = array_merge($_aMissingJobs, $missing);
         }
         return $_aMissingJobs;
     }
@@ -48,7 +48,7 @@ 
     public function getRemoteMissingJobs()
     {
         $_aChronosMissingJobs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $_aChronosMissingJobs = array_merge($_aChronosMissingJobs, $jobComparers->getRemoteMissingJobs());
         }
@@ -61,7 +61,7 @@ 
     public function getLocalJobUpdates()
     {
         $_aLocalJobUpdates = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $_aLocalJobUpdates = array_merge($_aLocalJobUpdates, $jobComparers->getLocalJobUpdates());
         }
@@ -75,7 +75,7 @@ 
     public function getJobDiff($sJobName)
     {
         $_aJobDiffs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             // assuming same name won't be in all subsystems.
             // TODO: add support to handle the duplicate names in different subsystems
@@ -101,7 +101,7 @@ 
         }
         /** @var JobComparisonInterface $comparer */
         $comparer = null;
-        foreach($this->aComposites as $child)
+        foreach ($this->aComposites as $child)
         {
             if ($child->isJobAvailable($oJobEntityA->getKey()))
             {
@@ -125,7 +125,7 @@ 
      */
     public function isJobAvailable($sJobName)
     {
-        foreach($this->aComposites as $child)
+        foreach ($this->aComposites as $child)
         {
             if ($child->isJobAvailable($sJobName))
             {

src/Component/Http/HttpGuzzlClient.php

Braces +6 added lines, -12 removed lines

@@ -59,48 +59,42 @@
         {
             $_oResponse = $this->oGuzzelClient->request('GET', $sUrl, $_aRequestOptions);
             return new HttpGuzzlResponse($_oResponse);
-        }
-        catch (ClientException $oException) // 400 level errors
+        } catch (ClientException $oException) // 400 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (ServerException $oException) // 500 level errors
+        } catch (ServerException $oException) // 500 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (TooManyRedirectsException $oException) // too many redirects to follow
+        } catch (TooManyRedirectsException $oException) // too many redirects to follow
         {
             throw new HttpConnectionException(
                 sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_TOO_MANY_REDIRECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (ConnectException $oException) // networking error
+        } catch (ConnectException $oException) // networking error
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_CONNECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
+        } catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_REQUEST_EXCEPTION,
                 $oException
             );
-        }
-        catch (\Exception $oException)
+        } catch (\Exception $oException)
         {
             throw new HttpConnectionException(
                 sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),

src/Entity/Marathon/AppEntity/PortDefinition.php

Spacing +5 added lines, -5 removed lines

@@ -23,12 +23,12 @@ 
 
     public function __construct($aData = [])
     {
-        MarathonEntityUtils::setAllPossibleProperties((array)$aData, $this);
-        if(isset($aData['labels']))
+        MarathonEntityUtils::setAllPossibleProperties((array) $aData, $this);
+        if (isset($aData['labels']))
         {
-            $this->labels = (object)$aData['labels'];
+            $this->labels = (object) $aData['labels'];
         } else {
-            $this->labels = (object)[];
+            $this->labels = (object) [];
         }
 
     }
@@ -41,7 +41,7 @@ 
         $_aRet = (array) $this;
         $_aRet = array_filter($_aRet, function($v, $k) {
             return !is_null($v);
-        }, ARRAY_FILTER_USE_BOTH );
+        }, ARRAY_FILTER_USE_BOTH);
         return $_aRet;
     }
 }
\ No newline at end of file

Braces +2 added lines, -1 removed lines

@@ -27,7 +27,8 @@
         if(isset($aData['labels']))
         {
             $this->labels = (object)$aData['labels'];
-        } else {
+        }
+        else {
             $this->labels = (object)[];
         }
 

src/Service/JobRepository/BridgeFileSystem.php

Braces +13 added lines, -5 removed lines

@@ -183,7 +183,8 @@ 
             if (is_file($_sPath) && preg_match('~\.json~i', $_sPath))
             {
                 $aJobFiles[] = $_sPath;
-            } elseif (is_dir($_sPath))
+            }
+            elseif (is_dir($_sPath))
             {
                 $this->getJobFilesFromFileSystem($_sPath, $aJobFiles);
             }
@@ -268,17 +269,23 @@ 
 
             if ($_aTemp)
             {
-                if (property_exists($_aTemp, 'name')) // chronos
+                if (property_exists($_aTemp, 'name')) {
+                    // chronos
                 {
                     $_aJobEntities[] = new ChronosJobEntity($_aTemp);
+                }
 
-                } else if (property_exists($_aTemp, 'id')) //marathon
+                }
+                else if (property_exists($_aTemp, 'id')) {
+                    //marathon
                 {
                     foreach ($this->getMarathonEntitiesForConfig($_aTemp) as $_oApp)
                     {
                         $_aJobEntities[] = $_oApp;
+                }
                     }
-                } else {
+                }
+                else {
                     throw new JobLoadException(
                         'Could not distinguish job as either chronos or marathon',
                         JobLoadException::ERROR_CODE_UNKNOWN_ENTITY_TYPE
@@ -385,7 +392,8 @@ 
                         }
                         return false;
                     }
-                } else {
+                }
+                else {
                     $_oDecodedConfig->apps[$key] = $oJobEntity;
                 }
                 $_bAppFound = true;

src/BusinessCase/JobManagement/AbstractStoreJobBusinessCase.php

Braces +2 added lines, -1 removed lines

@@ -70,7 +70,8 @@
             if (null == $_oLocalEntity)
             {
                 $this->addJobInLocalRepository($_oRemoteEntity);
-            } else {
+            }
+            else {
                 //update
                 $this->updateJobInLocalRepository($_oRemoteEntity, $bForceOverwrite);
             }

src/Component/RemoteClients/ChronosApiClient.php

Braces +2 added lines, -1 removed lines

@@ -62,7 +62,8 @@
         if (!empty($oJobEntity->schedule) && empty($oJobEntity->parents))
         {
             $_sTargetUrl = '/scheduler/iso8601';
-        } elseif (empty($oJobEntity->schedule) && !empty($oJobEntity->parents))
+        }
+        elseif (empty($oJobEntity->schedule) && !empty($oJobEntity->parents))
         {
             $_sTargetUrl = '/scheduler/dependency';
         }

src/Component/DatePeriod/DatePeriodFactory.php

Braces +1 added lines, -2 removed lines

@@ -38,8 +38,7 @@
         try
         {
             return self::$aIso8601Entity[$_sKey] = new Iso8601Entity($sIso8601);
-        }
-        catch (\InvalidArgumentException $_oException)
+        } catch (\InvalidArgumentException $_oException)
         {
             throw new DatePeriodException(sprintf("Can't init Iso8601Entity for '%s' iso 8601 string.", $sIso8601), 1, $_oException);
         }

src/Service/JobRepository/Filter/FilterIgnoreSettings.php

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
      * @param string $sDirectoryPath
      * @param array $aSearchPatterns
      */
-    private function getSearchPatternsFromDir($sDirectoryPath, &$aSearchPatterns=[])
+    private function getSearchPatternsFromDir($sDirectoryPath, &$aSearchPatterns = [])
     {
         $_sIgnoreFilePath = $sDirectoryPath . DIRECTORY_SEPARATOR . '.chapiignore';
 

src/Component/RemoteClients/MarathonApiClient.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      */
     public function removeJob($sJobName)
     {
-        $_sTargetEndpoint = '/v2/apps/'.$sJobName;
+        $_sTargetEndpoint = '/v2/apps/' . $sJobName;
 
         $_oResponse = $this->oHttpClient->delete($_sTargetEndpoint);
         return ($_oResponse->getStatusCode() == 200);