trivago / chapi

src/Service/JobValidator/PropertyValidator/Epsilon.php

Braces +4 added lines, -3 removed lines

@@ -57,9 +57,11 @@ 
                 $_oDateIntervalEpsilon = new \DateInterval($oJobEntity->epsilon);
                 $_iIntervalEpsilon = (int) $_oDateIntervalEpsilon->format('%Y%M%D%H%I%S');
 
-                if ($_iIntervalEpsilon > 30) // if epsilon > "PT30S"
+                if ($_iIntervalEpsilon > 30) {
+                    // if epsilon > "PT30S"
                 {
                     $_oIso8601Entity = $this->oDatePeriodFactory->createIso8601Entity($oJobEntity->schedule);
+                }
 
                     $_oDateIntervalScheduling = new \DateInterval($_oIso8601Entity->sInterval);
                     $_iIntervalScheduling = (int) $_oDateIntervalScheduling->format('%Y%M%D%H%I%S');
@@ -69,8 +71,7 @@ 
 
                 // if epsilon is less or equal than 30sec the not empty check is enough
                 return true;
-            }
-            catch (\Exception $_oException)
+            } catch (\Exception $_oException)
             {
                 // can't init \DateInterval instance
                 return false;

src/Service/JobValidator/PropertyValidator/Schedule.php

Braces +1 added lines, -2 removed lines

@@ -62,8 +62,7 @@
             {
                 $_oDataPeriod = $this->oDatePeriodFactory->createDatePeriod($oJobEntity->schedule, $oJobEntity->scheduleTimeZone);
                 return (false !== $_oDataPeriod);
-            }
-            catch (\Exception $oException)
+            } catch (\Exception $oException)
             {
                 // invalid: Iso8601 is not valid and/or DatePeriodFactory is able to create a valid DatePeriod
             }

src/Service/JobValidator/PropertyValidator/AbstractPropertyValidator.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace Chapi\Service\JobValidator\PropertyValidator;
 
 
-use Chapi\Entity\Chronos\JobEntity;
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Service\JobValidator\PropertyValidatorInterface;
 

src/Service/JobRepository/JobRepository.php

Braces +3 added lines, -1 removed lines

@@ -99,10 +99,12 @@
     {
         if ($this->oRepositoryBridge->addJob($oJobEntity))
         {
-            if (!is_null($this->oJobCollection)) // if no collection inited the new job will init by chronos request
+            if (!is_null($this->oJobCollection)) {
+                // if no collection inited the new job will init by chronos request
             {
                 $this->oJobCollection->offsetSet($oJobEntity->getKey(), $oJobEntity);
             }
+            }
 
             return true;
         }

src/Commands/AbstractCommand.php

Braces +3 added lines, -1 removed lines

@@ -116,12 +116,14 @@
         if (
             !file_exists($this->getHomeDir() . DIRECTORY_SEPARATOR . 'parameters.yml')
             && !file_exists($this->getWorkingDir() . DIRECTORY_SEPARATOR . '.chapiconfig')
-        ) // one file have to exist
+        ) {
+            // one file have to exist
         {
             $this->oOutput->writeln(sprintf(
                 '<error>%s</error>',
                 'No parameter file found. Please run "configure" command for initial setup or add a local `.chapiconfig` to your working directory.'
             ));
+        }
             return false;
         }
 

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 
 use Chapi\BusinessCase\Comparison\JobComparisonInterface;
-use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobIndex\JobIndexServiceInterface;
 use Chapi\Service\JobRepository\JobRepositoryInterface;

Braces +1 added lines, -2 removed lines

@@ -83,8 +83,7 @@
                         ));
                         return false;
                     }
-                }
-                catch(\Exception $e)
+                } catch(\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
                         'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()

src/Service/JobRepository/BridgeFactory.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use Chapi\Component\Cache\CacheInterface;
 use Chapi\Component\RemoteClients\ApiClientInterface;
-use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobValidator\JobValidatorServiceInterface;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Filesystem\Filesystem;

src/Component/Http/HttpGuzzlClient.php

Braces +6 added lines, -12 removed lines

@@ -59,48 +59,42 @@
         {
             $_oResponse = $this->oGuzzelClient->request('GET', $sUrl, $_aRequestOptions);
             return new HttpGuzzlResponse($_oResponse);
-        }
-        catch (ClientException $oException) // 400 level errors
+        } catch (ClientException $oException) // 400 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (ServerException $oException) // 500 level errors
+        } catch (ServerException $oException) // 500 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (TooManyRedirectsException $oException) // too many redirects to follow
+        } catch (TooManyRedirectsException $oException) // too many redirects to follow
         {
             throw new HttpConnectionException(
                 sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_TOO_MANY_REDIRECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (ConnectException $oException) // networking error
+        } catch (ConnectException $oException) // networking error
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_CONNECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
+        } catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_REQUEST_EXCEPTION,
                 $oException
             );
-        }
-        catch (\Exception $oException)
+        } catch (\Exception $oException)
         {
             throw new HttpConnectionException(
                 sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Unused Use Statements -2 removed lines

@@ -13,9 +13,7 @@
 
 use Chapi\Component\Comparison\DiffCompareInterface;
 use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Chronos\JobCollection;
 use Chapi\Entity\JobEntityInterface;
-use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobRepository\JobRepositoryInterface;