trivago / chapi

src/Entity/Marathon/AppEntity/Container.php

Spacing +2 added lines, -2 removed lines

@@ -35,14 +35,14 @@
 
         if (isset($aData['docker']))
         {
-            $this->docker = new Docker((array)$aData['docker']);
+            $this->docker = new Docker((array) $aData['docker']);
         }
 
         if (isset($aData['volumes']))
         {
             foreach ($aData['volumes'] as $volume)
             {
-                $this->volumes[] = new ContainerVolume((array)$volume);
+                $this->volumes[] = new ContainerVolume((array) $volume);
             }
         }
 

src/Entity/Marathon/AppEntity/Docker.php

Spacing +4 added lines, -4 removed lines

@@ -39,17 +39,17 @@
 
         if (isset($aData['portMappings']))
         {
-            foreach($aData['portMappings'] as $portMapping)
+            foreach ($aData['portMappings'] as $portMapping)
             {
-                $this->portMappings[] = new DockerPortMapping((array)$portMapping);
+                $this->portMappings[] = new DockerPortMapping((array) $portMapping);
             }
         }
 
         if (isset($aData['parameters']))
         {
-            foreach($aData['parameters'] as $parameter)
+            foreach ($aData['parameters'] as $parameter)
             {
-                $this->parameters[] = new DockerParameters((array)$parameter);
+                $this->parameters[] = new DockerParameters((array) $parameter);
             }
         }
 

src/Entity/Marathon/AppEntity/HealthCheck.php

Spacing +2 added lines, -2 removed lines

@@ -41,9 +41,9 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['command']))
+        if (isset($aData['command']))
         {
-            $this->command = new HealthCheckCommand((array)$aData['command']);
+            $this->command = new HealthCheckCommand((array) $aData['command']);
         }
     }
 

src/Entity/Marathon/AppEntity/IpAddress.php

Spacing +2 added lines, -2 removed lines

@@ -25,13 +25,13 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['groups']))
+        if (isset($aData['groups']))
         {
             $this->groups = $aData['groups'];
         }
         if (isset($aData['labels']))
         {
-            $this->labels = (object)$aData['labels'];
+            $this->labels = (object) $aData['labels'];
         }
     }
 }
\ No newline at end of file

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         $this->oDiffCompare = $oDiffCompare;
     }
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         if (
             !$oLocalJob instanceof MarathonAppEntity ||

Unused Use Statements -2 removed lines

@@ -13,9 +13,7 @@
 
 use Chapi\Component\Comparison\DiffCompareInterface;
 use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Chronos\JobCollection;
 use Chapi\Entity\JobEntityInterface;
-use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobRepository\JobRepositoryInterface;
 

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
     }
 
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         // no modification needed
         return;

src/BusinessCase/Comparison/AbstractJobComparisionBusinessCase.php

Spacing +2 added lines, -2 removed lines

@@ -166,7 +166,7 @@ 
             $_aDifferences[$_sProperty] = $this->oDiffCompare->compare(
                 $_oRemoteEntity->{$_sProperty},
                 $_oLocalEntity->{$_sProperty}
-            ) ;
+            );
         }
 
         return $_aDifferences;
@@ -219,7 +219,7 @@ 
      * @param JobEntityInterface $oRemoteJob
      * @return null
      */
-    abstract protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob);
+    abstract protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob);
 
     /**
      * Gets entity for each system with defaults set

src/BusinessCase/Comparison/CompositeJobComparisonBusinessCase.php

Spacing +7 added lines, -7 removed lines

@@ -34,10 +34,10 @@ 
     public function getLocalMissingJobs()
     {
         $_aMissingJobs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $missing = $jobComparers->getLocalMissingJobs();
-            $_aMissingJobs = array_merge($_aMissingJobs,  $missing);
+            $_aMissingJobs = array_merge($_aMissingJobs, $missing);
         }
         return $_aMissingJobs;
     }
@@ -48,7 +48,7 @@ 
     public function getRemoteMissingJobs()
     {
         $_aChronosMissingJobs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $_aChronosMissingJobs = array_merge($_aChronosMissingJobs, $jobComparers->getRemoteMissingJobs());
         }
@@ -61,7 +61,7 @@ 
     public function getLocalJobUpdates()
     {
         $_aLocalJobUpdates = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $_aLocalJobUpdates = array_merge($_aLocalJobUpdates, $jobComparers->getLocalJobUpdates());
         }
@@ -75,7 +75,7 @@ 
     public function getJobDiff($sJobName)
     {
         $_aJobDiffs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             // assuming same name won't be in all subsystems.
             // TODO: add support to handle the duplicate names in different subsystems
@@ -101,7 +101,7 @@ 
         }
         /** @var JobComparisonInterface $comparer */
         $comparer = null;
-        foreach($this->aComposites as $child)
+        foreach ($this->aComposites as $child)
         {
             if ($child->isJobAvailable($oJobEntityA->getKey()))
             {
@@ -125,7 +125,7 @@ 
      */
     public function isJobAvailable($sJobName)
     {
-        foreach($this->aComposites as $child)
+        foreach ($this->aComposites as $child)
         {
             if ($child->isJobAvailable($sJobName))
             {

src/Entity/Marathon/MarathonAppEntity.php

Unused Use Statements -2 removed lines

@@ -11,12 +11,10 @@
 
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\AppEntity\Container;
-use Chapi\Entity\Marathon\AppEntity\DockerPortMapping;
 use Chapi\Entity\Marathon\AppEntity\HealthCheck;
 use Chapi\Entity\Marathon\AppEntity\IpAddress;
 use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\AppEntity\UpgradeStrategy;
-use Symfony\Component\Config\Definition\Exception\Exception;
 
 class MarathonAppEntity implements JobEntityInterface
 {

Spacing +11 added lines, -11 removed lines

@@ -51,7 +51,7 @@ 
     /**
      * @var array
      */
-    public $constraints  = [];
+    public $constraints = [];
 
 
     public $acceptedResourceRoles = null;
@@ -103,47 +103,47 @@ 
         {
             foreach ($aData['portDefinitions'] as $portDefinition)
             {
-                $this->portDefinitions[] = new PortDefinition((array)$portDefinition);
+                $this->portDefinitions[] = new PortDefinition((array) $portDefinition);
             }
         }
 
         if (isset($aData['container']))
         {
-            $this->container = new Container((array)$aData['container']);
+            $this->container = new Container((array) $aData['container']);
         }
 
         if (isset($aData['healthChecks']))
         {
-            foreach($aData['healthChecks'] as $healthCheck)
+            foreach ($aData['healthChecks'] as $healthCheck)
             {
-                $this->healthChecks[] = new HealthCheck((array)$healthCheck);
+                $this->healthChecks[] = new HealthCheck((array) $healthCheck);
             }
         }
 
         if (isset($aData['upgradeStrategy']))
         {
-            $this->upgradeStrategy = new UpgradeStrategy((array)$aData['upgradeStrategy']);
+            $this->upgradeStrategy = new UpgradeStrategy((array) $aData['upgradeStrategy']);
         } else {
             $this->upgradeStrategy = new UpgradeStrategy();
         }
 
         if (isset($aData['ipAddress']))
         {
-            $this->ipAddress = new IpAddress((array)$aData['ipAddress']);
+            $this->ipAddress = new IpAddress((array) $aData['ipAddress']);
         }
 
         if (isset($aData['env']))
         {
-            $this->env =  (object) $aData['env'];
+            $this->env = (object) $aData['env'];
         } else {
-            $this->env = (object)[];
+            $this->env = (object) [];
         }
 
         if (isset($aData['labels']))
         {
             $this->labels = (object) $aData['labels'];
         } else {
-            $this->labels = (object)[];
+            $this->labels = (object) [];
         }
         MarathonEntityUtils::setPropertyIfExist($aData, $this, 'constraints');
         MarathonEntityUtils::setPropertyIfExist($aData, $this, 'args');
@@ -161,7 +161,7 @@ 
         $_aRet = (array) $this;
         $_aRet = array_filter($_aRet, function($v, $k) {
             return !is_null($v) || empty($v);
-        }, ARRAY_FILTER_USE_BOTH );
+        }, ARRAY_FILTER_USE_BOTH);
         return $_aRet;
     }
 

Braces +6 added lines, -3 removed lines

@@ -123,7 +123,8 @@ 
         if (isset($aData['upgradeStrategy']))
         {
             $this->upgradeStrategy = new UpgradeStrategy((array)$aData['upgradeStrategy']);
-        } else {
+        }
+        else {
             $this->upgradeStrategy = new UpgradeStrategy();
         }
 
@@ -135,14 +136,16 @@ 
         if (isset($aData['env']))
         {
             $this->env =  (object) $aData['env'];
-        } else {
+        }
+        else {
             $this->env = (object)[];
         }
 
         if (isset($aData['labels']))
         {
             $this->labels = (object) $aData['labels'];
-        } else {
+        }
+        else {
             $this->labels = (object)[];
         }
         MarathonEntityUtils::setPropertyIfExist($aData, $this, 'constraints');