FetchEntity - Code Metrics - Inspection of "[WIP] Update for chronos2.5 and marathon1.6" - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#104)

unknown

created 2018-03-29 18:20 UTC

FetchEntity A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	36.84 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

87.5%

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	0
dl	14
loc	38
ccs	7
cts	8
cp	0.875
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	__construct()	14	14	5

How to fix Duplicated Code

<?php
/**
 * @package: chapi
 *
 * @author:  sbrueggen
 * @since:   2018-03-29
 */

namespace Chapi\Entity\Chronos\JobEntity;

class FetchEntity

{
    /**
     * @param array|object $jobData
     * @throws \InvalidArgumentException
     */
    public function __construct($jobData = [])
    {
        if (is_array($jobData) || is_object($jobData)) {
            foreach ($jobData as $key => $value) {
                if (property_exists($this, $key)) {
                    $this->{$key} = $value;
                } else {
                    $this->unknown_fields[$key] = $value;
                }
            }
        } else {
            throw new \InvalidArgumentException(sprintf('Argument 1 passed to "%s" must be an array or object', __METHOD__));
        }
    }

    public $unknown_fields = [];
    
    /** @var string  */
    public $uri = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    
    /** @var string  */
    public $destPath = '';
    
    /** @var bool */
    public $extract = false;
    
    /** @var bool  */
    public $cache = false;
    
    /** @var bool  */
    public $executable = false;
}


1			<?php
2			/**
3			* @package: chapi
4			*
5			* @author: sbrueggen
6			* @since: 2018-03-29
7			*/
8
9			namespace Chapi\Entity\Chronos\JobEntity;
10
11			class FetchEntity
			0 ignored issues – show Coding Style introduced 2018-03-29 18:28 UTC by Report Bug Copy Issue Report The property $unknown_fields is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
12			{
13			/**
14			* @param array\|object $jobData
15			* @throws \InvalidArgumentException
16			*/
17	2	View Code Duplication	public function __construct($jobData = [])
18			{
19	2		if (is_array($jobData) \|\| is_object($jobData)) {
20	2		foreach ($jobData as $key => $value) {
21	2		if (property_exists($this, $key)) {
22	2		$this->{$key} = $value;
23			} else {
24	2		$this->unknown_fields[$key] = $value;
25			}
26			}
27			} else {
28			throw new \InvalidArgumentException(sprintf('Argument 1 passed to "%s" must be an array or object', __METHOD__));
29			}
30	2		}
31
32			public $unknown_fields = [];
33
34			/** @var string */
35			public $uri = "";
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-03-29 18:28 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
36
37			/** @var string */
38			public $destPath = '';
39
40			/** @var bool */
41			public $extract = false;
42
43			/** @var bool */
44			public $cache = false;
45
46			/** @var bool */
47			public $executable = false;
48			}
49

trivago / chapi

GitHub Access Token became invalid

Pull Request — master (#104)

FetchEntity A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like