@@ -87,8 +87,7 @@ discard block |
||
87 | 87 | $this->{$_sKey} = $_mValue; |
88 | 88 | } |
89 | 89 | } |
90 | - } |
|
91 | - else |
|
90 | + } else |
|
92 | 91 | { |
93 | 92 | throw new \InvalidArgumentException(sprintf('Argument 1 passed to "%s" must be an array or object', __METHOD__)); |
94 | 93 | } |
@@ -136,8 +135,7 @@ discard block |
||
136 | 135 | if (!empty($this->schedule)) |
137 | 136 | { |
138 | 137 | unset($_aReturn['parents']); |
139 | - } |
|
140 | - else |
|
138 | + } else |
|
141 | 139 | { |
142 | 140 | unset($_aReturn['schedule']); |
143 | 141 | unset($_aReturn['scheduleTimeZone']); |
@@ -230,8 +230,7 @@ |
||
230 | 230 | // set path to job file map |
231 | 231 | $this->setJobFileToMap($_oJobEntity->name, $_sJobFilePath); |
232 | 232 | } |
233 | - } |
|
234 | - else |
|
233 | + } else |
|
235 | 234 | { |
236 | 235 | throw new JobLoadException( |
237 | 236 | sprintf('Unable to load json job data from "%s". Please check if the json is valid.', $_sJobFilePath), |
@@ -138,8 +138,7 @@ discard block |
||
138 | 138 | { |
139 | 139 | $_oDataPeriod = $this->oDatePeriodFactory->createDatePeriod($oJobEntity->schedule, $oJobEntity->scheduleTimeZone); |
140 | 140 | return (false !== $_oDataPeriod); |
141 | - } |
|
142 | - catch (DatePeriodException $oException) |
|
141 | + } catch (DatePeriodException $oException) |
|
143 | 142 | { |
144 | 143 | // invalid: Iso8601 is not valid and/or DatePeriodFactory is able to create a valid DatePeriod |
145 | 144 | } |
@@ -161,9 +160,11 @@ discard block |
||
161 | 160 | $_oDateIntervalEpsilon = new \DateInterval($oJobEntity->epsilon); |
162 | 161 | $_iIntervalEpsilon = (int) $_oDateIntervalEpsilon->format('%Y%M%D%H%I%S'); |
163 | 162 | |
164 | - if ($_iIntervalEpsilon > 30) // if epsilon > "PT30S" |
|
163 | + if ($_iIntervalEpsilon > 30) { |
|
164 | + // if epsilon > "PT30S" |
|
165 | 165 | { |
166 | 166 | $_oIso8601Entity = $this->oDatePeriodFactory->createIso8601Entity($oJobEntity->schedule); |
167 | + } |
|
167 | 168 | |
168 | 169 | $_oDateIntervalScheduling = new \DateInterval($_oIso8601Entity->sInterval); |
169 | 170 | $_iIntervalScheduling = (int) $_oDateIntervalScheduling->format('%Y%M%D%H%I%S'); |
@@ -173,8 +174,7 @@ discard block |
||
173 | 174 | |
174 | 175 | // if epsilon is less or equal than 30sec the not empty check is enough |
175 | 176 | return true; |
176 | - } |
|
177 | - catch (\Exception $_oException) |
|
177 | + } catch (\Exception $_oException) |
|
178 | 178 | { |
179 | 179 | // can't init \DateInterval instance |
180 | 180 | return false; |
@@ -84,10 +84,12 @@ |
||
84 | 84 | { |
85 | 85 | if ($this->oRepositoryBridge->addJob($oJobEntity)) |
86 | 86 | { |
87 | - if (!is_null($this->oJobCollection)) // if no collection inited the new job will init by chronos request |
|
87 | + if (!is_null($this->oJobCollection)) { |
|
88 | + // if no collection inited the new job will init by chronos request |
|
88 | 89 | { |
89 | 90 | $this->oJobCollection->offsetSet($oJobEntity->name, $oJobEntity); |
90 | 91 | } |
92 | + } |
|
91 | 93 | |
92 | 94 | return true; |
93 | 95 | } |