Constraints::isValid() - Code Metrics - Inspection of "Enhancement/improve validation" - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#61)

by Marc

created 2016-11-14 14:09 UTC

Constraints::isValid() A

↳ Parent: Constraints

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	2
crap	1

<?php
/**
 * @package: chapi
 *
 * @author:  msiebeneicher
 * @since:   2016-11-10
 *
 */


namespace Chapi\Service\JobValidator\PropertyValidator;

use Chapi\Entity\Chronos\JobEntity;
use Chapi\Service\JobValidator\PropertyValidatorInterface;

class Constraints extends AbstractPropertyValidator implements PropertyValidatorInterface
{
    const DIC_NAME = 'ConstraintsValidator';
    const MESSAGE_TEMPLATE = '"%s" contained constraint is not valid. Should be an array with three values.';

    /**
     * @inheritDoc
     */
    public function isValid($sProperty, JobEntity $oJobEntity)
    {
        return $this->returnIsValidHelper(
            $this->isConstraintsPropertyValid($oJobEntity->{$sProperty}),
            $sProperty,
            self::MESSAGE_TEMPLATE
        );
    }

    /**
     * @param array $aConstraints
     * @return bool
     */
    private function isConstraintsPropertyValid($aConstraints)
    {
        if (!is_array($aConstraints) && !is_null($aConstraints))
        {
            return false;
        }
        
        if (!empty($aConstraints))
        {
            foreach ($aConstraints as $_aConstraint)
            {
                if (!is_array($_aConstraint) || count($_aConstraint) != 3)
                {
                    return false;
                }
            }
        }

        return true;
    }
}

1		<?php
2		/**
3		* @package: chapi
4		*
5		* @author: msiebeneicher
6		* @since: 2016-11-10
7		*
8		*/
9
10
11		namespace Chapi\Service\JobValidator\PropertyValidator;
12
13		use Chapi\Entity\Chronos\JobEntity;
14		use Chapi\Service\JobValidator\PropertyValidatorInterface;
15
16		class Constraints extends AbstractPropertyValidator implements PropertyValidatorInterface
17		{
18		const DIC_NAME = 'ConstraintsValidator';
19		const MESSAGE_TEMPLATE = '"%s" contained constraint is not valid. Should be an array with three values.';
20
21		/**
22		* @inheritDoc
23		*/
24	3	public function isValid($sProperty, JobEntity $oJobEntity)
25		{
26	3	return $this->returnIsValidHelper(
27	3	$this->isConstraintsPropertyValid($oJobEntity->{$sProperty}),
28	3	$sProperty,
29		self::MESSAGE_TEMPLATE
30	3	);
31		}
32
33		/**
34		* @param array $aConstraints
35		* @return bool
36		*/
37	3	private function isConstraintsPropertyValid($aConstraints)
38		{
39	3	if (!is_array($aConstraints) && !is_null($aConstraints))
40	3	{
41	2	return false;
42		}
43
44	3	if (!empty($aConstraints))
45	3	{
46	2	foreach ($aConstraints as $_aConstraint)
47		{
48	2	if (!is_array($_aConstraint) \|\| count($_aConstraint) != 3)
49	2	{
50	1	return false;
51		}
52	1	}
53	1	}
54
55	2	return true;
56		}
57		}

trivago / chapi

GitHub Access Token became invalid

Pull Request — master (#61)

Constraints::isValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like