Command::isCommandPropertyValid() - Code Metrics - Inspection of "Enhancement/improve validation" - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#61)

by Marc

created 2016-11-14 14:09 UTC

Command::isCommandPropertyValid() A

↳ Parent: Command

Complexity

Conditions	4
Paths	4

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	9.2
c	1
b	0
f	1
cc	4
eloc	4
nc	4
nop	1
crap	4

<?php
/**
 * @package: chapi
 *
 * @author:  msiebeneicher
 * @since:   2016-11-10
 *
 */


namespace Chapi\Service\JobValidator\PropertyValidator;

use Chapi\Entity\Chronos\JobEntity;
use Chapi\Service\JobValidator\PropertyValidatorInterface;

class Command extends AbstractPropertyValidator implements PropertyValidatorInterface
{
    const DIC_NAME = 'CommandValidator';
    const MESSAGE_TEMPLATE = '"%s" is not allowed to be empty for non docker jobs';

    /**
     * @inheritDoc
     */
    public function isValid($sProperty, JobEntity $oJobEntity)
    {
        return $this->returnIsValidHelper(
            $this->isCommandPropertyValid($oJobEntity),
            $sProperty,
            self::MESSAGE_TEMPLATE
        );
    }

    /**
     * @param JobEntity $oJobEntity
     * @return bool
     */
    private function isCommandPropertyValid(JobEntity $oJobEntity)
    {
        if (is_null($oJobEntity->container))
        {
            return (!empty($oJobEntity->command) && is_string($oJobEntity->command));
        }
        
        return (empty($oJobEntity->command) || is_string($oJobEntity->command));
    }
}

1		<?php
2		/**
3		* @package: chapi
4		*
5		* @author: msiebeneicher
6		* @since: 2016-11-10
7		*
8		*/
9
10
11		namespace Chapi\Service\JobValidator\PropertyValidator;
12
13		use Chapi\Entity\Chronos\JobEntity;
14		use Chapi\Service\JobValidator\PropertyValidatorInterface;
15
16		class Command extends AbstractPropertyValidator implements PropertyValidatorInterface
17		{
18		const DIC_NAME = 'CommandValidator';
19		const MESSAGE_TEMPLATE = '"%s" is not allowed to be empty for non docker jobs';
20
21		/**
22		* @inheritDoc
23		*/
24	3	public function isValid($sProperty, JobEntity $oJobEntity)
25		{
26	3	return $this->returnIsValidHelper(
27	3	$this->isCommandPropertyValid($oJobEntity),
28	3	$sProperty,
29		self::MESSAGE_TEMPLATE
30	3	);
31		}
32
33		/**
34		* @param JobEntity $oJobEntity
35		* @return bool
36		*/
37	3	private function isCommandPropertyValid(JobEntity $oJobEntity)
38		{
39	3	if (is_null($oJobEntity->container))
40	3	{
41	3	return (!empty($oJobEntity->command) && is_string($oJobEntity->command));
42		}
43
44	1	return (empty($oJobEntity->command) \|\| is_string($oJobEntity->command));
45		}
46		}

trivago / chapi

GitHub Access Token became invalid

Pull Request — master (#61)

Command::isCommandPropertyValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like