trivago / chapi

src/Commands/StatusCommand.php

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
                 {
                     $_aFilteredJobList[] = $_sJobName;
                 }
-            }
-            else
+            } else
             {
                 if (!$this->oJobIndexService->isJobInIndex($_sJobName))
                 {

src/Service/JobRepository/BridgeFileSystem.php

Doc Comments +3 added lines

@@ -347,6 +347,9 @@
     }
 
 
+    /**
+     * @param string $sJobFile
+     */
     private function dumpFileWithGroup($sJobFile, JobEntityInterface $oJobEntity, $bAdd = true)
     {
         $_sGroupConfig = file_get_contents($sJobFile);

Braces +9 added lines, -8 removed lines

@@ -155,8 +155,7 @@ 
                 DIRECTORY_SEPARATOR,
                 $oJobEntity->getKey()
             );
-        }
-        else
+        } else
         {
             $_sJobPath = $oJobEntity->getKey();
         }
@@ -268,15 +267,19 @@ 
 
             if ($_aTemp)
             {
-                if (property_exists($_aTemp, 'name')) // chronos
+                if (property_exists($_aTemp, 'name')) {
+                    // chronos
                 {
                     $_aJobEntities[] = new ChronosJobEntity($_aTemp);
+                }
 
-                } else if (property_exists($_aTemp, 'id')) //marathon
+                } else if (property_exists($_aTemp, 'id')) {
+                    //marathon
                 {
                     foreach ($this->getMarathonEntitiesForConfig($_aTemp) as $_oApp)
                     {
                         $_aJobEntities[] = $_oApp;
+                }
                     }
                 } else {
                     throw new JobLoadException(
@@ -297,8 +300,7 @@ 
                     $_aJobs[] = $_oJobEntity;
                 }
 
-            }
-            else
+            } else
             {
                 throw new JobLoadException(
                     sprintf('Unable to load json job data from "%s". Please check if the json is valid.', $_sJobFilePath),
@@ -323,8 +325,7 @@ 
                 $this->aGroupedApps[] = $_oApp->id;
                 $_aRet[] = $_oGroupEntity;
             }
-        }
-        else
+        } else
         {
             $_aRet[] = new MarathonAppEntity($aEntityData);
         }

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Braces +1 added lines, -2 removed lines

@@ -317,8 +317,7 @@
         {
             $_oDateTime = new \DateTime(str_replace('Z', '', $_oIso8601Entity->sStartTime));
             $_oDateTime->setTimezone(new \DateTimeZone($sTimeZone));
-        }
-        else
+        } else
         {
             $_oDateTime = new \DateTime($_oIso8601Entity->sStartTime);
         }

src/Service/JobRepository/JobRepository.php

Braces +3 added lines, -1 removed lines

@@ -99,10 +99,12 @@
     {
         if ($this->oRepositoryBridge->addJob($oJobEntity))
         {
-            if (!is_null($this->oJobCollection)) // if no collection inited the new job will init by chronos request
+            if (!is_null($this->oJobCollection)) {
+                // if no collection inited the new job will init by chronos request
             {
                 $this->oJobCollection->offsetSet($oJobEntity->getKey(), $oJobEntity);
             }
+            }
 
             return true;
         }

src/Commands/InfoCommand.php

Braces +1 added lines, -2 removed lines

@@ -55,8 +55,7 @@
                 $_mValue = (!empty($_mValue))
                     ? json_encode($_mValue, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES)
                     : $_sEmptyString;
-            }
-            elseif (is_bool($_mValue))
+            } elseif (is_bool($_mValue))
             {
                 $_mValue = (true === $_mValue)
                     ? 'true'

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +3 added lines

@@ -133,6 +133,9 @@
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $iImmediateChildren
+     */
     private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree

Braces +1 added lines, -2 removed lines

@@ -83,8 +83,7 @@
                         ));
                         return false;
                     }
-                }
-                catch(\Exception $e)
+                } catch(\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
                         'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()

src/Component/Http/HttpGuzzlClient.php

Doc Comments +2 added lines, -2 removed lines

@@ -98,8 +98,8 @@
     }
 
     /**
-     * @param $sMethod
-     * @param $sUrl
+     * @param string $sMethod
+     * @param string $sUrl
      * @param $mData
      * @return HttpGuzzlResponse
      */

Braces +6 added lines, -12 removed lines

@@ -59,48 +59,42 @@
         {
             $_oResponse = $this->oGuzzelClient->request('GET', $sUrl, $_aRequestOptions);
             return new HttpGuzzlResponse($_oResponse);
-        }
-        catch (ClientException $oException) // 400 level errors
+        } catch (ClientException $oException) // 400 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (ServerException $oException) // 500 level errors
+        } catch (ServerException $oException) // 500 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (TooManyRedirectsException $oException) // too many redirects to follow
+        } catch (TooManyRedirectsException $oException) // too many redirects to follow
         {
             throw new HttpConnectionException(
                 sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_TOO_MANY_REDIRECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (ConnectException $oException) // networking error
+        } catch (ConnectException $oException) // networking error
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_CONNECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
+        } catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_REQUEST_EXCEPTION,
                 $oException
             );
-        }
-        catch (\Exception $oException)
+        } catch (\Exception $oException)
         {
             throw new HttpConnectionException(
                 sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),

src/BusinessCase/JobManagement/ChronosStoreJobBusinessCase.php

Braces +1 added lines, -2 removed lines

@@ -151,8 +151,7 @@
             if ($this->oJobComparisonBusinessCase->hasSameJobType($_oJobEntityLocal, $_oJobEntityChronos))
             {
                 $_bHasUpdatedJob = $this->oJobRepositoryRemote->updateJob($_oJobEntityLocal);
-            }
-            else
+            } else
             {
                 $_bHasUpdatedJob = (
                     $this->oJobRepositoryRemote->removeJob($_oJobEntityChronos->getKey())

src/BusinessCase/JobManagement/AbstractStoreJobBusinessCase.php

Braces +3 added lines, -6 removed lines

@@ -52,8 +52,7 @@ 
         if (empty($aEntityNames))
         {
             $_aRemoteEntities = $this->oJobRepositoryRemote->getJobs();
-        }
-        else
+        } else
         {
             $_aRemoteEntities = [];
             foreach ($aEntityNames as $_sJobName)
@@ -85,8 +84,7 @@ 
                 'Entity %s stored in local repository',
                 $oAppRemote->getKey()
             ));
-        }
-        else {
+        } else {
             $this->oLogger->error(sprintf(
                 'Failed to store %s in local repository',
                 $oAppRemote->getKey()
@@ -116,8 +114,7 @@ 
                     'Entity %s is updated in local repository',
                     $oAppRemote->getKey()
                 ));
-            }
-            else {
+            } else {
                 $this->oLogger->error(sprintf(
                     'Failed to update app %s in local repository',
                     $oAppRemote->getKey()