Chapi\Service\JobRepository\BridgeFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	60
Duplicated Lines	53.33 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getChronosBridge()	16	18	2
A	getMarathonBridge()	16	18	2
A	getFilesystemBridge()	0	18	2

<?php
/**
 * @package: chapi
 *
 * @author:  bthapaliya
 * @since:   2017-02-14
 */


namespace Chapi\Service\JobRepository;


use Chapi\Component\Cache\CacheInterface;
use Chapi\Component\RemoteClients\ApiClientInterface;
use Chapi\Entity\Chronos\ChronosJobEntity;
use Chapi\Entity\Marathon\MarathonAppEntity;
use Chapi\Service\JobValidator\JobValidatorServiceInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\Filesystem\Filesystem;

class BridgeFactory

BridgeFactory does not seem to conform to the naming convention (Utils?$).

{
    public static function getChronosBridge(

This method seems to be duplicated in your project.

        ApiClientInterface $oApiClient,
        CacheInterface $oCache,
        JobValidatorServiceInterface $oJobEntityValidatorService,
        LoggerInterface $oLogger
    )
    {
        if ($oApiClient->ping())
        {
            return new BridgeChronos(
                $oApiClient,
                $oCache,
                $oJobEntityValidatorService,
                $oLogger);
        }

        return new DummyBridge($oLogger);
    }

    public static function getMarathonBridge(

This method seems to be duplicated in your project.

        ApiClientInterface $oApiClient,
        CacheInterface $oCache,
        JobValidatorServiceInterface $oJobEntityValidatorService,
        LoggerInterface $oLogger
    )
    {
        if ($oApiClient->ping())
        {
            return new BridgeMarathon(
                $oApiClient,
                $oCache,
                $oJobEntityValidatorService,
                $oLogger);
        }

        return new DummyBridge($oLogger);
    }


    public static function getFilesystemBridge(
        Filesystem $oFileSystemService,
        CacheInterface $oCache,
        $sRepositoryDir,
        LoggerInterface $oLogger
    )
    {
        if (empty($sRepositoryDir))
        {
            return new DummyBridge($oLogger);
        }

        return new BridgeFileSystem(
            $oFileSystemService,
            $oCache,
            $sRepositoryDir
        );
    }
}