trivago / chapi

src/BusinessCase/Comparison/AbstractJobComparisionBusinessCase.php

Spacing +2 added lines, -2 removed lines

@@ -166,7 +166,7 @@ 
             $_aDifferences[$_sProperty] = $this->oDiffCompare->compare(
                 $_oRemoteEntity->{$_sProperty},
                 $_oLocalEntity->{$_sProperty}
-            ) ;
+            );
         }
 
         return $_aDifferences;
@@ -219,7 +219,7 @@ 
      * @param JobEntityInterface $oRemoteJob
      * @return null
      */
-    abstract protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob);
+    abstract protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob);
 
     /**
      * Gets entity for each system with defaults set

src/Commands/ConfigureCommand.php

Spacing +2 added lines, -2 removed lines

@@ -165,7 +165,7 @@ 
         $_sYaml = $_oDumper->dump(array('parameters' => $aToStore), 2);
 
         $_oFileSystem = new Filesystem();
-        $_oFileSystem->dumpFile($this->getHomeDir() . '/parameters.yml', $_sYaml);
+        $_oFileSystem->dumpFile($this->getHomeDir().'/parameters.yml', $_sYaml);
     }
 
     /**
@@ -194,7 +194,7 @@ 
     private function getParameterValue($sKey, $mDefaultValue = null)
     {
         $_oParser = new Parser();
-        $_sParameterFile = $this->getHomeDir() . '/parameters.yml';
+        $_sParameterFile = $this->getHomeDir().'/parameters.yml';
 
         if (file_exists($_sParameterFile))
         {

src/BusinessCase/Comparison/CompositeJobComparisonBusinessCase.php

Spacing +7 added lines, -7 removed lines

@@ -34,10 +34,10 @@ 
     public function getLocalMissingJobs()
     {
         $_aMissingJobs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $missing = $jobComparers->getLocalMissingJobs();
-            $_aMissingJobs = array_merge($_aMissingJobs,  $missing);
+            $_aMissingJobs = array_merge($_aMissingJobs, $missing);
         }
         return $_aMissingJobs;
     }
@@ -48,7 +48,7 @@ 
     public function getRemoteMissingJobs()
     {
         $_aChronosMissingJobs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $_aChronosMissingJobs = array_merge($_aChronosMissingJobs, $jobComparers->getRemoteMissingJobs());
         }
@@ -61,7 +61,7 @@ 
     public function getLocalJobUpdates()
     {
         $_aLocalJobUpdates = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             $_aLocalJobUpdates = array_merge($_aLocalJobUpdates, $jobComparers->getLocalJobUpdates());
         }
@@ -75,7 +75,7 @@ 
     public function getJobDiff($sJobName)
     {
         $_aJobDiffs = array();
-        foreach($this->aComposites as $jobComparers)
+        foreach ($this->aComposites as $jobComparers)
         {
             // assuming same name won't be in all subsystems.
             // TODO: add support to handle the duplicate names in different subsystems
@@ -101,7 +101,7 @@ 
         }
         /** @var JobComparisonInterface $comparer */
         $comparer = null;
-        foreach($this->aComposites as $child)
+        foreach ($this->aComposites as $child)
         {
             if ($child->isJobAvailable($oJobEntityA->getKey()))
             {
@@ -125,7 +125,7 @@ 
      */
     public function isJobAvailable($sJobName)
     {
-        foreach($this->aComposites as $child)
+        foreach ($this->aComposites as $child)
         {
             if ($child->isJobAvailable($sJobName))
             {

src/Entity/Marathon/MarathonAppEntity.php

Unused Use Statements -2 removed lines

@@ -11,12 +11,10 @@
 
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\AppEntity\Container;
-use Chapi\Entity\Marathon\AppEntity\DockerPortMapping;
 use Chapi\Entity\Marathon\AppEntity\HealthCheck;
 use Chapi\Entity\Marathon\AppEntity\IpAddress;
 use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\AppEntity\UpgradeStrategy;
-use Symfony\Component\Config\Definition\Exception\Exception;
 
 class MarathonAppEntity implements JobEntityInterface
 {

Spacing +11 added lines, -11 removed lines

@@ -51,7 +51,7 @@ 
     /**
      * @var array
      */
-    public $constraints  = [];
+    public $constraints = [];
 
 
     public $acceptedResourceRoles = null;
@@ -103,47 +103,47 @@ 
         {
             foreach ($aData['portDefinitions'] as $portDefinition)
             {
-                $this->portDefinitions[] = new PortDefinition((array)$portDefinition);
+                $this->portDefinitions[] = new PortDefinition((array) $portDefinition);
             }
         }
 
         if (isset($aData['container']))
         {
-            $this->container = new Container((array)$aData['container']);
+            $this->container = new Container((array) $aData['container']);
         }
 
         if (isset($aData['healthChecks']))
         {
-            foreach($aData['healthChecks'] as $healthCheck)
+            foreach ($aData['healthChecks'] as $healthCheck)
             {
-                $this->healthChecks[] = new HealthCheck((array)$healthCheck);
+                $this->healthChecks[] = new HealthCheck((array) $healthCheck);
             }
         }
 
         if (isset($aData['upgradeStrategy']))
         {
-            $this->upgradeStrategy = new UpgradeStrategy((array)$aData['upgradeStrategy']);
+            $this->upgradeStrategy = new UpgradeStrategy((array) $aData['upgradeStrategy']);
         } else {
             $this->upgradeStrategy = new UpgradeStrategy();
         }
 
         if (isset($aData['ipAddress']))
         {
-            $this->ipAddress = new IpAddress((array)$aData['ipAddress']);
+            $this->ipAddress = new IpAddress((array) $aData['ipAddress']);
         }
 
         if (isset($aData['env']))
         {
-            $this->env =  (object) $aData['env'];
+            $this->env = (object) $aData['env'];
         } else {
-            $this->env = (object)[];
+            $this->env = (object) [];
         }
 
         if (isset($aData['labels']))
         {
             $this->labels = (object) $aData['labels'];
         } else {
-            $this->labels = (object)[];
+            $this->labels = (object) [];
         }
         MarathonEntityUtils::setPropertyIfExist($aData, $this, 'constraints');
         MarathonEntityUtils::setPropertyIfExist($aData, $this, 'args');
@@ -161,7 +161,7 @@ 
         $_aRet = (array) $this;
         $_aRet = array_filter($_aRet, function($v, $k) {
             return !is_null($v) || empty($v);
-        }, ARRAY_FILTER_USE_BOTH );
+        }, ARRAY_FILTER_USE_BOTH);
         return $_aRet;
     }
 

Braces +6 added lines, -3 removed lines

@@ -123,7 +123,8 @@ 
         if (isset($aData['upgradeStrategy']))
         {
             $this->upgradeStrategy = new UpgradeStrategy((array)$aData['upgradeStrategy']);
-        } else {
+        }
+        else {
             $this->upgradeStrategy = new UpgradeStrategy();
         }
 
@@ -135,14 +136,16 @@ 
         if (isset($aData['env']))
         {
             $this->env =  (object) $aData['env'];
-        } else {
+        }
+        else {
             $this->env = (object)[];
         }
 
         if (isset($aData['labels']))
         {
             $this->labels = (object) $aData['labels'];
-        } else {
+        }
+        else {
             $this->labels = (object)[];
         }
         MarathonEntityUtils::setPropertyIfExist($aData, $this, 'constraints');

src/Entity/Marathon/AppEntity/PortDefinition.php

Spacing +5 added lines, -5 removed lines

@@ -23,12 +23,12 @@ 
 
     public function __construct($aData = [])
     {
-        MarathonEntityUtils::setAllPossibleProperties((array)$aData, $this);
-        if(isset($aData['labels']))
+        MarathonEntityUtils::setAllPossibleProperties((array) $aData, $this);
+        if (isset($aData['labels']))
         {
-            $this->labels = (object)$aData['labels'];
+            $this->labels = (object) $aData['labels'];
         } else {
-            $this->labels = (object)[];
+            $this->labels = (object) [];
         }
 
     }
@@ -41,7 +41,7 @@ 
         $_aRet = (array) $this;
         $_aRet = array_filter($_aRet, function($v, $k) {
             return !is_null($v);
-        }, ARRAY_FILTER_USE_BOTH );
+        }, ARRAY_FILTER_USE_BOTH);
         return $_aRet;
     }
 }
\ No newline at end of file

Braces +2 added lines, -1 removed lines

@@ -27,7 +27,8 @@
         if(isset($aData['labels']))
         {
             $this->labels = (object)$aData['labels'];
-        } else {
+        }
+        else {
             $this->labels = (object)[];
         }
 

src/Service/JobRepository/Filter/FilterIgnoreSettings.php

Spacing +2 added lines, -2 removed lines

@@ -96,9 +96,9 @@
      * @param string $sDirectoryPath
      * @param array $aSearchPatterns
      */
-    private function getSearchPatternsFromDir($sDirectoryPath, &$aSearchPatterns=[])
+    private function getSearchPatternsFromDir($sDirectoryPath, &$aSearchPatterns = [])
     {
-        $_sIgnoreFilePath = $sDirectoryPath . DIRECTORY_SEPARATOR . '.chapiignore';
+        $_sIgnoreFilePath = $sDirectoryPath.DIRECTORY_SEPARATOR.'.chapiignore';
 
         if (is_file($_sIgnoreFilePath))
         {

src/BusinessCase/JobManagement/AbstractStoreJobBusinessCase.php

Braces +2 added lines, -1 removed lines

@@ -70,7 +70,8 @@
             if (null == $_oLocalEntity)
             {
                 $this->addJobInLocalRepository($_oRemoteEntity);
-            } else {
+            }
+            else {
                 //update
                 $this->updateJobInLocalRepository($_oRemoteEntity, $bForceOverwrite);
             }

src/Component/DatePeriod/DatePeriodFactory.php

Braces +1 added lines, -2 removed lines

@@ -38,8 +38,7 @@
         try
         {
             return self::$aIso8601Entity[$_sKey] = new Iso8601Entity($sIso8601);
-        }
-        catch (\InvalidArgumentException $_oException)
+        } catch (\InvalidArgumentException $_oException)
         {
             throw new DatePeriodException(sprintf("Can't init Iso8601Entity for '%s' iso 8601 string.", $sIso8601), 1, $_oException);
         }