Container::isValid() - Code Metrics - Inspection of "Enhancement/improve validation" - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#61)

by Marc

created 2016-11-14 13:46 UTC

Container::isValid() A

↳ Parent: Container

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	2
crap	1

<?php
/**
 * @package: chapi
 *
 * @author:  msiebeneicher
 * @since:   2016-11-10
 */


namespace Chapi\Service\JobValidator\PropertyValidator;

use Chapi\Entity\Chronos\JobEntity;
use Chapi\Service\JobValidator\PropertyValidatorInterface;

class Container extends AbstractPropertyValidator implements PropertyValidatorInterface
{
    const DIC_NAME = 'ContainerValidator';
    const MESSAGE_TEMPLATE = '"%s" is not valid. Type (required), image (required), forcePullImage (optional), network (optional), and volumes (optional)';

    /**
     * @inheritDoc
     */
    public function isValid($sProperty, JobEntity $oJobEntity)
    {
        return $this->returnIsValidHelper(
            $this->isContainerPropertyValid($oJobEntity->{$sProperty}),
            $sProperty,
            self::MESSAGE_TEMPLATE
        );
    }

    /**
     * @param JobEntity\ContainerEntity $oContainer
     * @return bool
     *
     * @see http://mesos.github.io/chronos/docs/api.html#adding-a-docker-job
     * This contains the subfields for the Docker container:
     *  type (required), image (required), forcePullImage (optional), network (optional),
     *  and volumes (optional)
     */
    private function isContainerPropertyValid($oContainer)
    {
        if (is_null($oContainer))
        {
            return true;
        }

        if (empty($oContainer->type) || empty($oContainer->image))
        {
            return false;
        }

        if (!is_array($oContainer->volumes))
        {
            return false;
        }

        foreach ($oContainer->volumes as $_oVolume)
        {
            if (!in_array($_oVolume->mode, ['RO', 'RW']))
            {
                return false;
            }
        }

        return true;
    }
}

1		<?php
2		/**
3		* @package: chapi
4		*
5		* @author: msiebeneicher
6		* @since: 2016-11-10
7		*/
8
9
10		namespace Chapi\Service\JobValidator\PropertyValidator;
11
12		use Chapi\Entity\Chronos\JobEntity;
13		use Chapi\Service\JobValidator\PropertyValidatorInterface;
14
15		class Container extends AbstractPropertyValidator implements PropertyValidatorInterface
16		{
17		const DIC_NAME = 'ContainerValidator';
18		const MESSAGE_TEMPLATE = '"%s" is not valid. Type (required), image (required), forcePullImage (optional), network (optional), and volumes (optional)';
19
20		/**
21		* @inheritDoc
22		*/
23	3	public function isValid($sProperty, JobEntity $oJobEntity)
24		{
25	3	return $this->returnIsValidHelper(
26	3	$this->isContainerPropertyValid($oJobEntity->{$sProperty}),
27	3	$sProperty,
28		self::MESSAGE_TEMPLATE
29	3	);
30		}
31
32		/**
33		* @param JobEntity\ContainerEntity $oContainer
34		* @return bool
35		*
36		* @see http://mesos.github.io/chronos/docs/api.html#adding-a-docker-job
37		* This contains the subfields for the Docker container:
38		* type (required), image (required), forcePullImage (optional), network (optional),
39		* and volumes (optional)
40		*/
41	3	private function isContainerPropertyValid($oContainer)
42		{
43	3	if (is_null($oContainer))
44	3	{
45	2	return true;
46		}
47
48	3	if (empty($oContainer->type) \|\| empty($oContainer->image))
49	3	{
50	2	return false;
51		}
52
53	2	if (!is_array($oContainer->volumes))
54	2	{
55	1	return false;
56		}
57
58	2	foreach ($oContainer->volumes as $_oVolume)
59		{
60	2	if (!in_array($_oVolume->mode, ['RO', 'RW']))
61	2	{
62	1	return false;
63		}
64	1	}
65
66	1	return true;
67		}
68		}

trivago / chapi

GitHub Access Token became invalid

Pull Request — master (#61)

Container::isValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like