trivago / chapi

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +3 added lines

@@ -133,6 +133,9 @@
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $iImmediateChildren
+     */
     private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 
 use Chapi\BusinessCase\Comparison\JobComparisonInterface;
-use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobIndex\JobIndexServiceInterface;
 use Chapi\Service\JobRepository\JobRepositoryInterface;

Spacing +5 added lines, -5 removed lines

@@ -72,7 +72,7 @@ 
             }
 
             // check if dependency is satisfied
-            if ( $_oJobEntityLocal->isDependencyJob())
+            if ($_oJobEntityLocal->isDependencyJob())
             {
                 try {
                     $circular = $this->isDependencyCircular($_oJobEntityLocal, count($_oJobEntityLocal->dependencies));
@@ -84,10 +84,10 @@ 
                         return false;
                     }
                 }
-                catch(\Exception $e)
+                catch (\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
-                        'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()
+                        'Job %s cannot be added to remote : %s', $sAppId, $e->getMessage()
                     ));
                     return false;
                 }
@@ -133,7 +133,7 @@ 
         return !(count($arr) == count(array_unique($arr)));
     }
 
-    private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
+    private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path = [])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree
         if ($this->hasDuplicates($path))
@@ -186,7 +186,7 @@ 
             // for B intermediate Child will be 2.
             // when we process D, it will be reduced to 1 and with C to 0
             // then we will pop B to generate path [A, E] when we reach E.
-            $iImmediateChildren = $iImmediateChildren -1;
+            $iImmediateChildren = $iImmediateChildren - 1;
             if ($iImmediateChildren == 0)
             {
                 array_pop($path);

Braces +1 added lines, -2 removed lines

@@ -83,8 +83,7 @@
                         ));
                         return false;
                     }
-                }
-                catch(\Exception $e)
+                } catch(\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
                         'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()

src/Component/Http/HttpGuzzlClient.php

Doc Comments +2 added lines, -2 removed lines

@@ -98,8 +98,8 @@
     }
 
     /**
-     * @param $sMethod
-     * @param $sUrl
+     * @param string $sMethod
+     * @param string $sUrl
      * @param $mData
      * @return HttpGuzzlResponse
      */

Spacing +6 added lines, -6 removed lines

@@ -63,7 +63,7 @@ 
         catch (ClientException $oException) // 400 level errors
         {
             throw new HttpConnectionException(
-                sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
+                sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri').$sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
@@ -71,7 +71,7 @@ 
         catch (ServerException $oException) // 500 level errors
         {
             throw new HttpConnectionException(
-                sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
+                sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri').$sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
@@ -79,7 +79,7 @@ 
         catch (TooManyRedirectsException $oException) // too many redirects to follow
         {
             throw new HttpConnectionException(
-                sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 HttpConnectionException::ERROR_CODE_TOO_MANY_REDIRECT_EXCEPTION,
                 $oException
             );
@@ -87,7 +87,7 @@ 
         catch (ConnectException $oException) // networking error
         {
             throw new HttpConnectionException(
-                sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 HttpConnectionException::ERROR_CODE_CONNECT_EXCEPTION,
                 $oException
             );
@@ -95,7 +95,7 @@ 
         catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
         {
             throw new HttpConnectionException(
-                sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 HttpConnectionException::ERROR_CODE_REQUEST_EXCEPTION,
                 $oException
             );
@@ -103,7 +103,7 @@ 
         catch (\Exception $oException)
         {
             throw new HttpConnectionException(
-                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 HttpConnectionException::ERROR_CODE_UNKNOWN,
                 $oException
             );

Braces +6 added lines, -12 removed lines

@@ -59,48 +59,42 @@
         {
             $_oResponse = $this->oGuzzelClient->request('GET', $sUrl, $_aRequestOptions);
             return new HttpGuzzlResponse($_oResponse);
-        }
-        catch (ClientException $oException) // 400 level errors
+        } catch (ClientException $oException) // 400 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (ServerException $oException) // 500 level errors
+        } catch (ServerException $oException) // 500 level errors
         {
             throw new HttpConnectionException(
                 sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
-        }
-        catch (TooManyRedirectsException $oException) // too many redirects to follow
+        } catch (TooManyRedirectsException $oException) // too many redirects to follow
         {
             throw new HttpConnectionException(
                 sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_TOO_MANY_REDIRECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (ConnectException $oException) // networking error
+        } catch (ConnectException $oException) // networking error
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_CONNECT_EXCEPTION,
                 $oException
             );
-        }
-        catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
+        } catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
         {
             throw new HttpConnectionException(
                 sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
                 HttpConnectionException::ERROR_CODE_REQUEST_EXCEPTION,
                 $oException
             );
-        }
-        catch (\Exception $oException)
+        } catch (\Exception $oException)
         {
             throw new HttpConnectionException(
                 sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),

src/Service/JobRepository/BridgeFactory.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use Chapi\Component\Cache\CacheInterface;
 use Chapi\Component\RemoteClients\ApiClientInterface;
-use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobValidator\JobValidatorServiceInterface;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Filesystem\Filesystem;

src/Entity/Marathon/AppEntity/Container.php

Spacing +2 added lines, -2 removed lines

@@ -35,14 +35,14 @@
 
         if (isset($aData['docker']))
         {
-            $this->docker = new Docker((array)$aData['docker']);
+            $this->docker = new Docker((array) $aData['docker']);
         }
 
         if (isset($aData['volumes']))
         {
             foreach ($aData['volumes'] as $volume)
             {
-                $this->volumes[] = new ContainerVolume((array)$volume);
+                $this->volumes[] = new ContainerVolume((array) $volume);
             }
         }
 

src/Entity/Marathon/AppEntity/Docker.php

Spacing +4 added lines, -4 removed lines

@@ -39,17 +39,17 @@
 
         if (isset($aData['portMappings']))
         {
-            foreach($aData['portMappings'] as $portMapping)
+            foreach ($aData['portMappings'] as $portMapping)
             {
-                $this->portMappings[] = new DockerPortMapping((array)$portMapping);
+                $this->portMappings[] = new DockerPortMapping((array) $portMapping);
             }
         }
 
         if (isset($aData['parameters']))
         {
-            foreach($aData['parameters'] as $parameter)
+            foreach ($aData['parameters'] as $parameter)
             {
-                $this->parameters[] = new DockerParameters((array)$parameter);
+                $this->parameters[] = new DockerParameters((array) $parameter);
             }
         }
 

src/Entity/Marathon/AppEntity/HealthCheck.php

Spacing +2 added lines, -2 removed lines

@@ -41,9 +41,9 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['command']))
+        if (isset($aData['command']))
         {
-            $this->command = new HealthCheckCommand((array)$aData['command']);
+            $this->command = new HealthCheckCommand((array) $aData['command']);
         }
     }
 

src/Entity/Marathon/AppEntity/IpAddress.php

Spacing +2 added lines, -2 removed lines

@@ -25,13 +25,13 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['groups']))
+        if (isset($aData['groups']))
         {
             $this->groups = $aData['groups'];
         }
         if (isset($aData['labels']))
         {
-            $this->labels = (object)$aData['labels'];
+            $this->labels = (object) $aData['labels'];
         }
     }
 }
\ No newline at end of file

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         $this->oDiffCompare = $oDiffCompare;
     }
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         if (
             !$oLocalJob instanceof MarathonAppEntity ||

Braces +3 added lines, -6 removed lines

@@ -104,12 +104,10 @@ 
         if (is_array($mValueA) && is_array($mValueB))
         {
             return $this->isArrayEqual($mValueA, $mValueB);
-        }
-        elseif (is_object($mValueA) && is_object($mValueB))
+        } elseif (is_object($mValueA) && is_object($mValueB))
         {
             return $this->isArrayEqual(get_object_vars($mValueA), get_object_vars($mValueB));
-        }
-        elseif ((is_scalar($mValueA) && is_scalar($mValueB)) || (is_null($mValueA) && is_null($mValueB)))
+        } elseif ((is_scalar($mValueA) && is_scalar($mValueB)) || (is_null($mValueA) && is_null($mValueB)))
         {
             return $mValueA == $mValueB;
         }
@@ -142,8 +140,7 @@ 
                 {
                     return false;
                 }
-            }
-            else
+            } else
             {
                 foreach ($aValuesB as $_mValueB)
                 {

Unused Use Statements -2 removed lines

@@ -13,9 +13,7 @@
 
 use Chapi\Component\Comparison\DiffCompareInterface;
 use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Chronos\JobCollection;
 use Chapi\Entity\JobEntityInterface;
-use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobRepository\JobRepositoryInterface;
 

src/BusinessCase/Comparison/AbstractJobComparisionBusinessCase.php

Spacing +2 added lines, -2 removed lines

@@ -166,7 +166,7 @@ 
             $_aDifferences[$_sProperty] = $this->oDiffCompare->compare(
                 $_oRemoteEntity->{$_sProperty},
                 $_oLocalEntity->{$_sProperty}
-            ) ;
+            );
         }
 
         return $_aDifferences;
@@ -219,7 +219,7 @@ 
      * @param JobEntityInterface $oRemoteJob
      * @return null
      */
-    abstract protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob);
+    abstract protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob);
 
     /**
      * Gets entity for each system with defaults set