trivago / chapi

src/Service/JobValidator/ChronosJobValidatorService.php

Unused Use Statements -2 removed lines

@@ -9,8 +9,6 @@
 
 namespace Chapi\Service\JobValidator;
 
-use Chapi\Component\DatePeriod\DatePeriodFactoryInterface;
-use Chapi\Entity\Chronos\JobEntity;
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\JobValidator\ValidationResult;
 

src/BusinessCase/JobManagement/ChronosStoreJobBusinessCase.php

Braces +2 added lines, -1 removed lines

@@ -148,7 +148,8 @@
             // handle job update
             if ($this->jobComparisonBusinessCase->hasSameJobType($jobEntityLocal, $jobEntityChronos)) {
                 $hasUpdatedJob = $this->jobRepositoryRemote->updateJob($jobEntityLocal);
-            } else {
+            }
+            else {
                 $hasUpdatedJob = (
                     $this->jobRepositoryRemote->removeJob($jobEntityChronos->getKey())
                     && $this->jobRepositoryRemote->addJob($jobEntityLocal)

src/BusinessCase/JobManagement/AbstractStoreJobBusinessCase.php

Braces +8 added lines, -4 removed lines

@@ -49,7 +49,8 @@ 
     {
         if (empty($entityNames)) {
             $remoteEntities = $this->jobRepositoryRemote->getJobs();
-        } else {
+        }
+        else {
             $remoteEntities = [];
             foreach ($entityNames as $jobName) {
                 $remoteEntities[] = $this->jobRepositoryRemote->getJob($jobName);
@@ -62,7 +63,8 @@ 
             // new job
             if (null == $localEntity) {
                 $this->addJobInLocalRepository($remoteEntity);
-            } else {
+            }
+            else {
                 //update
                 $this->updateJobInLocalRepository($remoteEntity, $forceOverwrite);
             }
@@ -76,7 +78,8 @@ 
                 'Entity %s stored in local repository',
                 $appRemote->getKey()
             ));
-        } else {
+        }
+        else {
             $this->logger->error(sprintf(
                 'Failed to store %s in local repository',
                 $appRemote->getKey()
@@ -103,7 +106,8 @@ 
                     'Entity %s is updated in local repository',
                     $appRemote->getKey()
                 ));
-            } else {
+            }
+            else {
                 $this->logger->error(sprintf(
                     'Failed to update app %s in local repository',
                     $appRemote->getKey()

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     }
 
 
-    protected function preCompareModifications(JobEntityInterface &$localJob, JobEntityInterface &$remoteJob)
+    protected function preCompareModifications(JobEntityInterface & $localJob, JobEntityInterface & $remoteJob)
     {
         // no modification needed
         return;

Braces +2 added lines, -1 removed lines

@@ -219,7 +219,8 @@
         if (!empty($timeZone)) {
             $dateTime = new \DateTime(str_replace('Z', '', $iso8601Entity->startTime));
             $dateTime->setTimezone(new \DateTimeZone($timeZone));
-        } else {
+        }
+        else {
             $dateTime = new \DateTime($iso8601Entity->startTime);
         }
 

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
         $this->diffCompare = $diffCompare;
     }
 
-    protected function preCompareModifications(JobEntityInterface &$localJob, JobEntityInterface &$remoteJob)
+    protected function preCompareModifications(JobEntityInterface & $localJob, JobEntityInterface & $remoteJob)
     {
         if (!$localJob instanceof MarathonAppEntity ||
             !$remoteJob instanceof MarathonAppEntity

Braces +6 added lines, -3 removed lines

@@ -94,9 +94,11 @@ 
     {
         if (is_array($valueA) && is_array($valueB)) {
             return $this->isArrayEqual($valueA, $valueB);
-        } elseif (is_object($valueA) && is_object($valueB)) {
+        }
+        elseif (is_object($valueA) && is_object($valueB)) {
             return $this->isArrayEqual(get_object_vars($valueA), get_object_vars($valueB));
-        } elseif ((is_scalar($valueA) && is_scalar($valueB)) || (is_null($valueA) && is_null($valueB))) {
+        }
+        elseif ((is_scalar($valueA) && is_scalar($valueB)) || (is_null($valueA) && is_null($valueB))) {
             return $valueA == $valueB;
         }
 
@@ -125,7 +127,8 @@ 
                 if (!array_key_exists($keyA, $valuesB) || !$this->isEqual($valueA, $valuesB[$keyA])) {
                     return false;
                 }
-            } else {
+            }
+            else {
                 foreach ($valuesB as $valueB) {
                     if ($this->isEqual($valueA, $valueB)) {
                         continue 2;

src/BusinessCase/Comparison/AbstractJobComparisionBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -207,7 +207,7 @@
      * @param JobEntityInterface $remoteJob
      * @return null
      */
-    abstract protected function preCompareModifications(JobEntityInterface &$localJob, JobEntityInterface &$remoteJob);
+    abstract protected function preCompareModifications(JobEntityInterface & $localJob, JobEntityInterface & $remoteJob);
 
     /**
      * Gets entity for each system with defaults set

src/Service/JobRepository/BridgeFileSystem.php

Braces +12 added lines, -6 removed lines

@@ -149,7 +149,8 @@ 
                 DIRECTORY_SEPARATOR,
                 $jobEntity->getKey()
             );
-        } else {
+        }
+        else {
             $jobPath = $jobEntity->getKey();
         }
 
@@ -172,7 +173,8 @@ 
         foreach ($temp as $path) {
             if (is_file($path) && preg_match('~\.json~i', $path)) {
                 $jobFiles[] = $path;
-            } elseif (is_dir($path)) {
+            }
+            elseif (is_dir($path)) {
                 $this->getJobFilesFromFileSystem($path, $jobFiles);
             }
         }
@@ -259,7 +261,8 @@ 
                     foreach ($this->getMarathonEntitiesForConfig($temp) as $app) {
                         $jobEntities[] = $app;
                     }
-                } else {
+                }
+                else {
                     throw new JobLoadException(
                         'Could not distinguish job as either chronos or marathon',
                         JobLoadException::ERROR_CODE_UNKNOWN_ENTITY_TYPE
@@ -275,7 +278,8 @@ 
 
                     $jobs[] = $jobEntity;
                 }
-            } else {
+            }
+            else {
                 throw new JobLoadException(
                     sprintf('Unable to load json job data from "%s". Please check if the json is valid.', $jobFilePath),
                     JobLoadException::ERROR_CODE_NO_VALID_JSON
@@ -297,7 +301,8 @@ 
                 $this->groupedApps[] = $app->id;
                 $return[] = $groupEntity;
             }
-        } else {
+        }
+        else {
             $return[] = new MarathonAppEntity($entityData);
         }
         return $return;
@@ -356,7 +361,8 @@ 
                         }
                         return false;
                     }
-                } else {
+                }
+                else {
                     $decodedConfig->apps[$key] = $jobEntity;
                 }
                 $appFound = true;

src/Service/JobRepository/Filter/FilterIgnoreSettings.php

Braces +2 added lines, -1 removed lines

@@ -93,7 +93,8 @@
             foreach ($profileConfig['ignore'] as $searchPattern) {
                 if ('!' == substr($searchPattern, 0, 1)) {
                     $searchPatterns['ignore_not'][] = substr($searchPattern, 1);
-                } else {
+                }
+                else {
                     $searchPatterns['ignore'][] = $searchPattern;
                 }
             }

src/Component/RemoteClients/ChronosApiClient.php

Braces +2 added lines, -1 removed lines

@@ -58,7 +58,8 @@
 
         if (!empty($jobEntity->schedule) && empty($jobEntity->parents)) {
             $targetUrl = '/scheduler/iso8601';
-        } elseif (empty($jobEntity->schedule) && !empty($jobEntity->parents)) {
+        }
+        elseif (empty($jobEntity->schedule) && !empty($jobEntity->parents)) {
             $targetUrl = '/scheduler/dependency';
         }