trivago / chapi

src/Commands/StatusCommand.php

Braces +1 added lines, -2 removed lines

@@ -230,8 +230,7 @@
                     // set path to job file map
                     $this->setJobFileToMap($_oJobEntity->name, $_sJobFilePath);
                 }
-            }
-            else
+            } else
             {
                 throw new JobLoadException(
                     sprintf('Unable to load json job data from "%s". Please check if the json is valid.', $_sJobFilePath),

src/Commands/AbstractCommand.php

Braces +3 added lines, -1 removed lines

@@ -125,12 +125,14 @@
         if (
             !file_exists($this->getHomeDir() . DIRECTORY_SEPARATOR . 'parameters.yml')
             AND !file_exists(getcwd() . DIRECTORY_SEPARATOR . '.chapiconfig')
-        ) // one file have to exist
+        ) {
+            // one file have to exist
         {
             $this->oOutput->writeln(sprintf(
                 '<error>%s</error>',
                 'No parameter file found. Please run "configure" command for initial setup or add a local `.chapiconfig` to your working directory.'
             ));
+        }
             return false;
         }
 

Indentation +16 added lines, -16 removed lines

@@ -44,22 +44,22 @@
     private static $sHomeDir = '';
 
     /**
-    * Executes the current command.
-    *
-    * This method is not abstract because you can use this class
-    * as a concrete class. In this case, instead of defining the
-    * execute() method, you set the code to execute by passing
-    * a Closure to the setCode() method.
-    *
-    * @param InputInterface $oInput An InputInterface instance
-    * @param OutputInterface $oOutput An OutputInterface instance
-    *
-    * @return integer null or 0 if everything went fine, or an error code
-    *
-    * @throws \LogicException When this abstract method is not implemented
-    *
-    * @see setCode()
-    */
+     * Executes the current command.
+     *
+     * This method is not abstract because you can use this class
+     * as a concrete class. In this case, instead of defining the
+     * execute() method, you set the code to execute by passing
+     * a Closure to the setCode() method.
+     *
+     * @param InputInterface $oInput An InputInterface instance
+     * @param OutputInterface $oOutput An OutputInterface instance
+     *
+     * @return integer null or 0 if everything went fine, or an error code
+     *
+     * @throws \LogicException When this abstract method is not implemented
+     *
+     * @see setCode()
+     */
     protected function execute(InputInterface $oInput, OutputInterface $oOutput)
     {
         $this->oInput = $oInput;

Spacing +6 added lines, -6 removed lines

@@ -99,7 +99,7 @@ 
             $this->loadParameterConfig($this->getWorkingDir(), '.chapiconfig', $_oContainer);
 
             // load services
-            $_oLoader = new YamlFileLoader($_oContainer, new FileLocator(__DIR__ . self::FOLDER_RESOURCES));
+            $_oLoader = new YamlFileLoader($_oContainer, new FileLocator(__DIR__.self::FOLDER_RESOURCES));
             $_oLoader->load('services.yml');
 
             self::$oContainer = $_oContainer;
@@ -114,8 +114,8 @@ 
     protected function isAppRunable()
     {
         if (
-            !file_exists($this->getHomeDir() . DIRECTORY_SEPARATOR . 'parameters.yml')
-            && !file_exists($this->getWorkingDir() . DIRECTORY_SEPARATOR . '.chapiconfig')
+            !file_exists($this->getHomeDir().DIRECTORY_SEPARATOR.'parameters.yml')
+            && !file_exists($this->getWorkingDir().DIRECTORY_SEPARATOR.'.chapiconfig')
         ) // one file have to exist
         {
             $this->oOutput->writeln(sprintf(
@@ -141,7 +141,7 @@ 
         $_sHomeDir = getenv('CHAPI_HOME');
         if (!$_sHomeDir)
         {
-            $_sHomeDir = CommandUtils::getOsHomeDir() . DIRECTORY_SEPARATOR . '.chapi';
+            $_sHomeDir = CommandUtils::getOsHomeDir().DIRECTORY_SEPARATOR.'.chapi';
         }
 
         CommandUtils::hasCreateDirectoryIfNotExists($_sHomeDir);
@@ -154,7 +154,7 @@ 
      */
     protected function getCacheDir()
     {
-        $_sCacheDir = $this->getHomeDir() . DIRECTORY_SEPARATOR . 'cache';
+        $_sCacheDir = $this->getHomeDir().DIRECTORY_SEPARATOR.'cache';
         CommandUtils::hasCreateDirectoryIfNotExists($_sCacheDir);
 
         return $_sCacheDir;
@@ -176,7 +176,7 @@ 
     private function loadParameterConfig($sPath, $sFile, $oContainer)
     {
         // load local parameters
-        if (file_exists($sPath . DIRECTORY_SEPARATOR . $sFile))
+        if (file_exists($sPath.DIRECTORY_SEPARATOR.$sFile))
         {
             $_oLoader = new YamlFileLoader($oContainer, new FileLocator($sPath));
             $_oLoader->load($sFile);

src/BusinessCase/JobManagement/StoreJobBusinessCase.php

Braces +4 added lines, -8 removed lines

@@ -101,8 +101,7 @@ 
         if (empty($aJobNames))
         {
             $_aChronosJobs = $this->oJobRepositoryChronos->getJobs();
-        }
-        else
+        } else
         {
             $_aChronosJobs = [];
             foreach ($aJobNames as $_sJobName)
@@ -124,8 +123,7 @@ 
                         'Job "%s" successfully stored in local repository',
                         $_oJobEntity->name
                     ));
-                }
-                else
+                } else
                 {
                     $this->oLogger->error(sprintf(
                         'Failed to store job "%s" in local repository',
@@ -156,8 +154,7 @@ 
                         'Job "%s" successfully updated in local repository',
                         $_oJobEntity->name
                     ));
-                }
-                else
+                } else
                 {
                     $this->oLogger->error(sprintf(
                         'Failed to update job "%s" in local repository',
@@ -245,8 +242,7 @@ 
             if ($this->oJobComparisonBusinessCase->hasSameJobType($_oJobEntityLocal, $_oJobEntityChronos))
             {
                 $_bHasUpdatedJob = $this->oJobRepositoryChronos->updateJob($_oJobEntityLocal);
-            }
-            else
+            } else
             {
                 $_bHasUpdatedJob = (
                     $this->oJobRepositoryChronos->removeJob($_oJobEntityChronos)

src/Commands/ListCommand.php

Spacing +2 added lines, -2 removed lines

@@ -129,12 +129,12 @@
                 ? 100 / $oJobEntity->successCount * $oJobEntity->errorCount
                 : 100;
 
-            $_aJobInfoText[] = 'errors rate: ' . round($_fErrorRate, 2) . '%';
+            $_aJobInfoText[] = 'errors rate: '.round($_fErrorRate, 2).'%';
         }
 
         if ($oJobEntity->errorsSinceLastSuccess > 0)
         {
-            $_aJobInfoText[] = 'errors since last success:' . $oJobEntity->errorsSinceLastSuccess;
+            $_aJobInfoText[] = 'errors since last success:'.$oJobEntity->errorsSinceLastSuccess;
         }
 
         return (!empty($_aJobInfoText))

src/Commands/ConfigureCommand.php

Spacing +2 added lines, -2 removed lines

@@ -136,7 +136,7 @@ 
         $_sYaml = $_oDumper->dump(array('parameters' => $aToStore));
 
         $_oFileSystem = new Filesystem();
-        $_oFileSystem->dumpFile($this->getHomeDir() . '/parameters.yml', $_sYaml);
+        $_oFileSystem->dumpFile($this->getHomeDir().'/parameters.yml', $_sYaml);
     }
 
     /**
@@ -165,7 +165,7 @@ 
     private function getParameterValue($sKey, $mDefaultValue = null)
     {
         $_oParser = new Parser();
-        $_sParameterFile = $this->getHomeDir() . '/parameters.yml';
+        $_sParameterFile = $this->getHomeDir().'/parameters.yml';
 
         if (file_exists($_sParameterFile))
         {

src/Component/Cache/DoctrineCache.php

Spacing +5 added lines, -5 removed lines

@@ -36,7 +36,7 @@ 
             md5($sCachePrefix),
             0,
             6
-        ) . '.';
+        ).'.';
     }
 
     /**
@@ -47,7 +47,7 @@ 
      */
     public function set($sKey, $mValue, $iTTL = 0)
     {
-        return $this->oDoctrineCache->save($this->sCachePrefix . $sKey, $mValue, $iTTL);
+        return $this->oDoctrineCache->save($this->sCachePrefix.$sKey, $mValue, $iTTL);
     }
 
     /**
@@ -56,8 +56,8 @@ 
      */
     public function get($sKey)
     {
-        return ($this->oDoctrineCache->contains($this->sCachePrefix . $sKey))
-            ? $this->oDoctrineCache->fetch($this->sCachePrefix . $sKey)
+        return ($this->oDoctrineCache->contains($this->sCachePrefix.$sKey))
+            ? $this->oDoctrineCache->fetch($this->sCachePrefix.$sKey)
             : null
         ;
     }
@@ -68,6 +68,6 @@ 
      */
     public function delete($sKey)
     {
-        return $this->oDoctrineCache->delete($this->sCachePrefix . $sKey);
+        return $this->oDoctrineCache->delete($this->sCachePrefix.$sKey);
     }
 }
\ No newline at end of file

src/Component/Chronos/ApiClient.php

Spacing +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
      */
     public function removeJob($sJobName)
     {
-        $_oResponse = $this->oHttpClient->delete('/scheduler/job/' . $sJobName);
+        $_oResponse = $this->oHttpClient->delete('/scheduler/job/'.$sJobName);
         return ($_oResponse->getStatusCode() == 204);
     }
 
@@ -91,7 +91,7 @@ 
      */
     public function getJobStats($sJobName)
     {
-        return $this->sendGetJsonRequest('/scheduler/job/stat/' . $sJobName);
+        return $this->sendGetJsonRequest('/scheduler/job/stat/'.$sJobName);
     }
 
     /**

src/Entity/Chronos/JobEntity.php

Braces +3 added lines, -6 removed lines

@@ -94,15 +94,13 @@ 
                     if ($_sKey == 'container')
                     {
                         $this->{$_sKey} = new ContainerEntity($_mValue);
-                    }
-                    else
+                    } else
                     {
                         $this->{$_sKey} = $_mValue;    
                     }
                 }
             }
-        }
-        else
+        } else
         {
             throw new \InvalidArgumentException(sprintf('Argument 1 passed to "%s" must be an array or object', __METHOD__));
         }
@@ -150,8 +148,7 @@ 
         if (!empty($this->schedule))
         {
             unset($_aReturn['parents']);
-        }
-        else
+        } else
         {
             unset($_aReturn['schedule']);
             unset($_aReturn['scheduleTimeZone']);

src/Entity/Chronos/JobEntity/ContainerEntity.php

Braces +3 added lines, -6 removed lines

@@ -26,23 +26,20 @@
                     if ($_sKey == 'type')
                     {
                         $this->{$_sKey} = strtolower($_mValue);
-                    }
-                    elseif ($_sKey == 'volumes')
+                    } elseif ($_sKey == 'volumes')
                     {
                         foreach ($_mValue as $_mValueVolume)
                         {
                             $_oVolume = new ContainerVolumeEntity($_mValueVolume);
                             $this->volumes[] = $_oVolume;
                         }
-                    }
-                    else
+                    } else
                     {
                         $this->{$_sKey} = $_mValue;
                     }
                 }
             }
-        }
-        else
+        } else
         {
             throw new \InvalidArgumentException(sprintf('Argument 1 passed to "%s" must be an array or object', __METHOD__));
         }