Schedule::isSchedulePropertyValid() - Code Metrics - Inspection of "Enhancement/improve validation" - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#61)

by Marc

created 2016-11-14 13:57 UTC

Schedule::isSchedulePropertyValid() B

↳ Parent: Schedule

Complexity

Conditions	6
Paths	4

Size

Total Lines	22
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	11
cts	11
cp	1
rs	8.6737
c	0
b	0
f	0
cc	6
eloc	9
nc	4
nop	1
crap	6

<?php
/**
 * @package: chapi
 *
 * @author:  msiebeneicher
 * @since:   2016-11-10
 *
 */

namespace Chapi\Service\JobValidator\PropertyValidator;


use Chapi\Component\DatePeriod\DatePeriodFactoryInterface;
use Chapi\Entity\Chronos\JobEntity;
use Chapi\Service\JobValidator\PropertyValidatorInterface;

class Schedule extends AbstractPropertyValidator implements PropertyValidatorInterface
{
    const DIC_NAME = 'ScheduleValidator';
    const MESSAGE_TEMPLATE = '"%s" is not a valid ISO8601 string and/or DatePeriodFactory is not able to create a valid DatePeriod';

    /**
     * @var DatePeriodFactoryInterface
     */
    private $oDatePeriodFactory;

    /**
     * Epsilon constructor.
     * @param DatePeriodFactoryInterface $oDatePeriodFactory
     */
    public function __construct(DatePeriodFactoryInterface $oDatePeriodFactory)
    {
        $this->oDatePeriodFactory = $oDatePeriodFactory;
    }
    
    /**
     * @inheritDoc
     */
    public function isValid($sProperty, JobEntity $oJobEntity)
    {
        return $this->returnIsValidHelper(
            $this->isSchedulePropertyValid($oJobEntity),
            $sProperty,
            self::MESSAGE_TEMPLATE
        );
    }

    /**
     * @param JobEntity $oJobEntity
     * @return bool
     */
    private function isSchedulePropertyValid(JobEntity $oJobEntity)
    {
        if (empty($oJobEntity->schedule) && !empty($oJobEntity->parents))
        {
            return true;
        }

        if (!empty($oJobEntity->schedule) && empty($oJobEntity->parents))
        {
            try
            {
                $_oDataPeriod = $this->oDatePeriodFactory->createDatePeriod($oJobEntity->schedule, $oJobEntity->scheduleTimeZone);
                return (false !== $_oDataPeriod);
            }
            catch (\Exception $oException)
            {
                // invalid: Iso8601 is not valid and/or DatePeriodFactory is able to create a valid DatePeriod
            }
        }

        return false;
    }
}

1		<?php
2		/**
3		* @package: chapi
4		*
5		* @author: msiebeneicher
6		* @since: 2016-11-10
7		*
8		*/
9
10		namespace Chapi\Service\JobValidator\PropertyValidator;
11
12
13		use Chapi\Component\DatePeriod\DatePeriodFactoryInterface;
14		use Chapi\Entity\Chronos\JobEntity;
15		use Chapi\Service\JobValidator\PropertyValidatorInterface;
16
17		class Schedule extends AbstractPropertyValidator implements PropertyValidatorInterface
18		{
19		const DIC_NAME = 'ScheduleValidator';
20		const MESSAGE_TEMPLATE = '"%s" is not a valid ISO8601 string and/or DatePeriodFactory is not able to create a valid DatePeriod';
21
22		/**
23		* @var DatePeriodFactoryInterface
24		*/
25		private $oDatePeriodFactory;
26
27		/**
28		* Epsilon constructor.
29		* @param DatePeriodFactoryInterface $oDatePeriodFactory
30		*/
31	5	public function __construct(DatePeriodFactoryInterface $oDatePeriodFactory)
32		{
33	5	$this->oDatePeriodFactory = $oDatePeriodFactory;
34	5	}
35
36		/**
37		* @inheritDoc
38		*/
39	5	public function isValid($sProperty, JobEntity $oJobEntity)
40		{
41	5	return $this->returnIsValidHelper(
42	5	$this->isSchedulePropertyValid($oJobEntity),
43	5	$sProperty,
44		self::MESSAGE_TEMPLATE
45	5	);
46		}
47
48		/**
49		* @param JobEntity $oJobEntity
50		* @return bool
51		*/
52	5	private function isSchedulePropertyValid(JobEntity $oJobEntity)
53		{
54	5	if (empty($oJobEntity->schedule) && !empty($oJobEntity->parents))
55	5	{
56	1	return true;
57		}
58
59	5	if (!empty($oJobEntity->schedule) && empty($oJobEntity->parents))
60	5	{
61		try
62		{
63	4	$_oDataPeriod = $this->oDatePeriodFactory->createDatePeriod($oJobEntity->schedule, $oJobEntity->scheduleTimeZone);
64	3	return (false !== $_oDataPeriod);
65		}
66	1	catch (\Exception $oException)
67		{
68		// invalid: Iso8601 is not valid and/or DatePeriodFactory is able to create a valid DatePeriod
69		}
70	1	}
71
72	4	return false;
73		}
74		}

trivago / chapi

GitHub Access Token became invalid

Pull Request — master (#61)

Schedule::isSchedulePropertyValid() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like