Chapi\Entity\Marathon\AppEntity\PortDefinition

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	40 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

54.55%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	11	2
A	jsonSerialize()	8	8	1

<?php
/**
 * @package: chapi
 *
 * @author: bthapaliya
 * @since: 2016-10-16
 *
 */
namespace Chapi\Entity\Marathon\AppEntity;

use Chapi\Entity\Marathon\MarathonEntityUtils;

class PortDefinition implements \JsonSerializable
{
    const DIC = self::class;
    public $port = 0;

    public $protocol = 'tcp';

    public $name = null;

    public $labels = null;

    public function __construct($aData = [])
    {
        MarathonEntityUtils::setAllPossibleProperties((array)$aData, $this);
        if(isset($aData['labels']))

This code seems to be duplicated across your project.

        {
            $this->labels = (object)$aData['labels'];
        } else {
            $this->labels = (object)[];
        }

    }

    /**
     * @inheritdoc
     */
    function jsonSerialize()

This method seems to be duplicated in your project.

    {
        $_aRet = (array) $this;
        $_aRet = array_filter($_aRet, function($v, $k) {

The parameter $k is not used and could be removed.

            return !is_null($v);
        }, ARRAY_FILTER_USE_BOTH );
        return $_aRet;
    }
}