trivago / chapi

src/Service/JobRepository/BridgeFileSystem.php

Doc Comments +3 added lines

@@ -347,6 +347,9 @@
     }
 
 
+    /**
+     * @param string $sJobFile
+     */
     private function dumpFileWithGroup($sJobFile, JobEntityInterface $oJobEntity, $bAdd = true)
     {
         $_sGroupConfig = file_get_contents($sJobFile);

Spacing +2 added lines, -2 removed lines

@@ -161,7 +161,7 @@ 
             $_sJobPath = $oJobEntity->getKey();
         }
 
-        return $this->sRepositoryDir . DIRECTORY_SEPARATOR . $_sJobPath . '.json';
+        return $this->sRepositoryDir.DIRECTORY_SEPARATOR.$_sJobPath.'.json';
     }
 
     /**
@@ -176,7 +176,7 @@ 
             throw new \RuntimeException(sprintf('Path "%s" is not valid', $sPath));
         }
 
-        $_aTemp = Glob::glob(rtrim($sPath, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . '*');
+        $_aTemp = Glob::glob(rtrim($sPath, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.'*');
 
         foreach ($_aTemp as $_sPath)
         {

src/Entity/Marathon/MarathonEntityUtils.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      */
     public static function setAllPossibleProperties($oData, $oTarget)
     {
-        foreach($oData as $attrName => $attrValue)
+        foreach ($oData as $attrName => $attrValue)
         {
             // dont set array or objects.
             // Because this would need further type information to properly set.

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +3 added lines

@@ -133,6 +133,9 @@
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $iImmediateChildren
+     */
     private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree

Spacing +5 added lines, -5 removed lines

@@ -72,7 +72,7 @@ 
             }
 
             // check if dependency is satisfied
-            if ( $_oJobEntityLocal->isDependencyJob())
+            if ($_oJobEntityLocal->isDependencyJob())
             {
                 try {
                     $circular = $this->isDependencyCircular($_oJobEntityLocal, count($_oJobEntityLocal->dependencies));
@@ -84,10 +84,10 @@ 
                         return false;
                     }
                 }
-                catch(\Exception $e)
+                catch (\Exception $e)
                 {
                     $this->oLogger->error(sprintf(
-                        'Job %s cannot be added to remote : %s',$sAppId, $e->getMessage()
+                        'Job %s cannot be added to remote : %s', $sAppId, $e->getMessage()
                     ));
                     return false;
                 }
@@ -133,7 +133,7 @@ 
         return !(count($arr) == count(array_unique($arr)));
     }
 
-    private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
+    private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path = [])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree
         if ($this->hasDuplicates($path))
@@ -186,7 +186,7 @@ 
             // for B intermediate Child will be 2.
             // when we process D, it will be reduced to 1 and with C to 0
             // then we will pop B to generate path [A, E] when we reach E.
-            $iImmediateChildren = $iImmediateChildren -1;
+            $iImmediateChildren = $iImmediateChildren - 1;
             if ($iImmediateChildren == 0)
             {
                 array_pop($path);

src/Component/Http/HttpGuzzlClient.php

Doc Comments +2 added lines, -2 removed lines

@@ -98,8 +98,8 @@
     }
 
     /**
-     * @param $sMethod
-     * @param $sUrl
+     * @param string $sMethod
+     * @param string $sUrl
      * @param $mData
      * @return HttpGuzzlResponse
      */

Spacing +6 added lines, -6 removed lines

@@ -63,7 +63,7 @@ 
         catch (ClientException $oException) // 400 level errors
         {
             throw new HttpConnectionException(
-                sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
+                sprintf('Client error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri').$sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
@@ -71,7 +71,7 @@ 
         catch (ServerException $oException) // 500 level errors
         {
             throw new HttpConnectionException(
-                sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri') . $sUrl, $oException->getCode()),
+                sprintf('Server error: Calling %s returned %d', $this->oGuzzelClient->getConfig('base_uri').$sUrl, $oException->getCode()),
                 $oException->getCode(),
                 $oException
             );
@@ -79,7 +79,7 @@ 
         catch (TooManyRedirectsException $oException) // too many redirects to follow
         {
             throw new HttpConnectionException(
-                sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Request to %s failed due to too many redirects', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 HttpConnectionException::ERROR_CODE_TOO_MANY_REDIRECT_EXCEPTION,
                 $oException
             );
@@ -87,7 +87,7 @@ 
         catch (ConnectException $oException) // networking error
         {
             throw new HttpConnectionException(
-                sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Cannot connect to %s due to some networking error', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 HttpConnectionException::ERROR_CODE_CONNECT_EXCEPTION,
                 $oException
             );
@@ -95,7 +95,7 @@ 
         catch (RequestException $oException) // networking error (connection timeout, DNS errors, etc.)
         {
             throw new HttpConnectionException(
-                sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Cannot connect to %s due to networking error', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 HttpConnectionException::ERROR_CODE_REQUEST_EXCEPTION,
                 $oException
             );
@@ -103,7 +103,7 @@ 
         catch (\Exception $oException)
         {
             throw new HttpConnectionException(
-                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri') . $sUrl),
+                sprintf('Can\'t get response from "%s"', $this->oGuzzelClient->getConfig('base_uri').$sUrl),
                 HttpConnectionException::ERROR_CODE_UNKNOWN,
                 $oException
             );

src/Entity/Marathon/AppEntity/Container.php

Spacing +2 added lines, -2 removed lines

@@ -35,14 +35,14 @@
 
         if (isset($aData['docker']))
         {
-            $this->docker = new Docker((array)$aData['docker']);
+            $this->docker = new Docker((array) $aData['docker']);
         }
 
         if (isset($aData['volumes']))
         {
             foreach ($aData['volumes'] as $volume)
             {
-                $this->volumes[] = new ContainerVolume((array)$volume);
+                $this->volumes[] = new ContainerVolume((array) $volume);
             }
         }
 

src/Entity/Marathon/AppEntity/Docker.php

Spacing +4 added lines, -4 removed lines

@@ -39,17 +39,17 @@
 
         if (isset($aData['portMappings']))
         {
-            foreach($aData['portMappings'] as $portMapping)
+            foreach ($aData['portMappings'] as $portMapping)
             {
-                $this->portMappings[] = new DockerPortMapping((array)$portMapping);
+                $this->portMappings[] = new DockerPortMapping((array) $portMapping);
             }
         }
 
         if (isset($aData['parameters']))
         {
-            foreach($aData['parameters'] as $parameter)
+            foreach ($aData['parameters'] as $parameter)
             {
-                $this->parameters[] = new DockerParameters((array)$parameter);
+                $this->parameters[] = new DockerParameters((array) $parameter);
             }
         }
 

src/Entity/Marathon/AppEntity/HealthCheck.php

Spacing +2 added lines, -2 removed lines

@@ -41,9 +41,9 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['command']))
+        if (isset($aData['command']))
         {
-            $this->command = new HealthCheckCommand((array)$aData['command']);
+            $this->command = new HealthCheckCommand((array) $aData['command']);
         }
     }
 

src/Entity/Marathon/AppEntity/IpAddress.php

Spacing +2 added lines, -2 removed lines

@@ -25,13 +25,13 @@
     {
         MarathonEntityUtils::setAllPossibleProperties($aData, $this);
 
-        if(isset($aData['groups']))
+        if (isset($aData['groups']))
         {
             $this->groups = $aData['groups'];
         }
         if (isset($aData['labels']))
         {
-            $this->labels = (object)$aData['labels'];
+            $this->labels = (object) $aData['labels'];
         }
     }
 }
\ No newline at end of file

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         $this->oDiffCompare = $oDiffCompare;
     }
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         if (
             !$oLocalJob instanceof MarathonAppEntity ||