trivago / chapi

src/Service/JobRepository/BridgeFileSystem.php

Doc Comments +3 added lines

@@ -347,6 +347,9 @@
     }
 
 
+    /**
+     * @param string $sJobFile
+     */
     private function dumpFileWithGroup($sJobFile, JobEntityInterface $oJobEntity, $bAdd = true)
     {
         $_sGroupConfig = file_get_contents($sJobFile);

src/Service/JobValidator/PropertyValidator/AbstractPropertyValidator.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace Chapi\Service\JobValidator\PropertyValidator;
 
 
-use Chapi\Entity\Chronos\JobEntity;
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Service\JobValidator\PropertyValidatorInterface;
 

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php

Doc Comments +3 added lines

@@ -133,6 +133,9 @@
         return !(count($arr) == count(array_unique($arr)));
     }
 
+    /**
+     * @param integer $iImmediateChildren
+     */
     private function isDependencyCircular(MarathonAppEntity $oEntity, $iImmediateChildren, &$path=[])
     {
         // Invariant: path will not have duplicates for acyclic dependency tree

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 
 use Chapi\BusinessCase\Comparison\JobComparisonInterface;
-use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobIndex\JobIndexServiceInterface;
 use Chapi\Service\JobRepository\JobRepositoryInterface;

src/Component/Http/HttpGuzzlClient.php

Doc Comments +2 added lines, -2 removed lines

@@ -98,8 +98,8 @@
     }
 
     /**
-     * @param $sMethod
-     * @param $sUrl
+     * @param string $sMethod
+     * @param string $sUrl
      * @param $mData
      * @return HttpGuzzlResponse
      */

src/Service/JobRepository/BridgeFactory.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use Chapi\Component\Cache\CacheInterface;
 use Chapi\Component\RemoteClients\ApiClientInterface;
-use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobValidator\JobValidatorServiceInterface;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Filesystem\Filesystem;

src/BusinessCase/Comparison/MarathonJobComparisonBusinessCase.php

Unused Use Statements -2 removed lines

@@ -13,9 +13,7 @@
 
 use Chapi\Component\Comparison\DiffCompareInterface;
 use Chapi\Entity\Chronos\ChronosJobEntity;
-use Chapi\Entity\Chronos\JobCollection;
 use Chapi\Entity\JobEntityInterface;
-use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\MarathonAppEntity;
 use Chapi\Service\JobRepository\JobRepositoryInterface;
 

src/Entity/Marathon/MarathonAppEntity.php

Unused Use Statements -2 removed lines

@@ -11,12 +11,10 @@
 
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Entity\Marathon\AppEntity\Container;
-use Chapi\Entity\Marathon\AppEntity\DockerPortMapping;
 use Chapi\Entity\Marathon\AppEntity\HealthCheck;
 use Chapi\Entity\Marathon\AppEntity\IpAddress;
 use Chapi\Entity\Marathon\AppEntity\PortDefinition;
 use Chapi\Entity\Marathon\AppEntity\UpgradeStrategy;
-use Symfony\Component\Config\Definition\Exception\Exception;
 
 class MarathonAppEntity implements JobEntityInterface
 {