Chapi\Component\RemoteClients\MarathonApiClient

Complexity

Total Complexity

11

Size/Duplication

Total Lines	95
Duplicated Lines	16.84 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

90%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	listingJobs()	0	10	2
A	addingJob()	0	7	1
A	updatingJob()	0	8	1
A	removeJob()	0	7	1
A	getJobStats()	0	4	1
A	ping()	16	16	4

<?php

namespace Chapi\Component\RemoteClients;


use Chapi\Component\Http\HttpClientInterface;
use Chapi\Entity\Chronos\ChronosJobEntity;
use Chapi\Entity\JobEntityInterface;
use Chapi\Exception\HttpConnectionException;
use Symfony\Component\Config\Definition\Exception\Exception;

class MarathonApiClient implements ApiClientInterface
{

    /** @var HttpClientInterface  */
    private $oHttpClient;

    public function __construct(
        HttpClientInterface $oHttpClient
    )
    {
        $this->oHttpClient = $oHttpClient;
    }

    /**
     * @link: https://mesos.github.io/chronos/docs/api.html#listing-jobs
     * @return array
     */
    public function listingJobs()
    {
        $oResponse = $this->oHttpClient->get('/v2/apps');
        if (200 == $oResponse->getStatusCode())
        {
            return $oResponse->json();
        }

        return [];
    }

    /**
     * @param JobEntityInterface $oJobEntity
     * @return bool
     */
    public function addingJob(JobEntityInterface $oJobEntity)
    {
        $_sTargetEndpoint = '/v2/apps';

        $_oResponse = $this->oHttpClient->postJsonData($_sTargetEndpoint, $oJobEntity);
        return ($_oResponse->getStatusCode() == 201);
    }

    /**
     * @param JobEntityInterface|ChronosJobEntity $oJobEntity
     * @return bool
     */
    public function updatingJob(JobEntityInterface $oJobEntity)
    {
        $_sJobName = $oJobEntity->getKey();

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

        $_sTargetEndpoint = '/v2/apps/' . $_sJobName;

        $_oResponse = $this->oHttpClient->putJsonData($_sTargetEndpoint, $oJobEntity);
        return ($_oResponse->getStatusCode() == 200);
    }

    /**
     * @param string $sJobName
     * @return bool
     */
    public function removeJob($sJobName)
    {
        $_sTargetEndpoint = '/v2/apps/' . $sJobName;

        $_oResponse = $this->oHttpClient->delete($_sTargetEndpoint);
        return ($_oResponse->getStatusCode() == 200);
    }

    /**
     * @param string $sJobName
     * @return array
     */
    public function getJobStats($sJobName)
    {
        return [];
    }

    /**
     * Returns true if the client can be connected to.
     * @return bool
     */
    public function ping()

This method seems to be duplicated in your project.

    {
        try {
            $this->oHttpClient->get('/v2/info');
        } catch (HttpConnectionException $e)
        {
            if (
                $e->getCode() == HttpConnectionException::ERROR_CODE_REQUEST_EXCEPTION ||
                $e->getCode() == HttpConnectionException::ERROR_CODE_CONNECT_EXCEPTION
            )
            {
                return false;
            }
        }
        return true;
    }
}