trivago / chapi

src/Service/JobValidator/PropertyValidator/Schedule.php

Braces +1 added lines, -2 removed lines

@@ -62,8 +62,7 @@
             {
                 $_oDataPeriod = $this->oDatePeriodFactory->createDatePeriod($oJobEntity->schedule, $oJobEntity->scheduleTimeZone);
                 return (false !== $_oDataPeriod);
-            }
-            catch (\Exception $oException)
+            } catch (\Exception $oException)
             {
                 // invalid: Iso8601 is not valid and/or DatePeriodFactory is able to create a valid DatePeriod
             }

src/Service/JobRepository/BridgeFileSystem.php

Doc Comments +3 added lines

@@ -347,6 +347,9 @@
     }
 
 
+    /**
+     * @param string $sJobFile
+     */
     private function dumpFileWithGroup($sJobFile, JobEntityInterface $oJobEntity, $bAdd = true)
     {
         $_sGroupConfig = file_get_contents($sJobFile);

Spacing +2 added lines, -2 removed lines

@@ -161,7 +161,7 @@ 
             $_sJobPath = $oJobEntity->getKey();
         }
 
-        return $this->sRepositoryDir . DIRECTORY_SEPARATOR . $_sJobPath . '.json';
+        return $this->sRepositoryDir.DIRECTORY_SEPARATOR.$_sJobPath.'.json';
     }
 
     /**
@@ -176,7 +176,7 @@ 
             throw new \RuntimeException(sprintf('Path "%s" is not valid', $sPath));
         }
 
-        $_aTemp = Glob::glob(rtrim($sPath, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . '*');
+        $_aTemp = Glob::glob(rtrim($sPath, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.'*');
 
         foreach ($_aTemp as $_sPath)
         {

Braces +9 added lines, -8 removed lines

@@ -155,8 +155,7 @@ 
                 DIRECTORY_SEPARATOR,
                 $oJobEntity->getKey()
             );
-        }
-        else
+        } else
         {
             $_sJobPath = $oJobEntity->getKey();
         }
@@ -268,15 +267,19 @@ 
 
             if ($_aTemp)
             {
-                if (property_exists($_aTemp, 'name')) // chronos
+                if (property_exists($_aTemp, 'name')) {
+                    // chronos
                 {
                     $_aJobEntities[] = new ChronosJobEntity($_aTemp);
+                }
 
-                } else if (property_exists($_aTemp, 'id')) //marathon
+                } else if (property_exists($_aTemp, 'id')) {
+                    //marathon
                 {
                     foreach ($this->getMarathonEntitiesForConfig($_aTemp) as $_oApp)
                     {
                         $_aJobEntities[] = $_oApp;
+                }
                     }
                 } else {
                     throw new JobLoadException(
@@ -297,8 +300,7 @@ 
                     $_aJobs[] = $_oJobEntity;
                 }
 
-            }
-            else
+            } else
             {
                 throw new JobLoadException(
                     sprintf('Unable to load json job data from "%s". Please check if the json is valid.', $_sJobFilePath),
@@ -323,8 +325,7 @@ 
                 $this->aGroupedApps[] = $_oApp->id;
                 $_aRet[] = $_oGroupEntity;
             }
-        }
-        else
+        } else
         {
             $_aRet[] = new MarathonAppEntity($aEntityData);
         }

src/Service/JobValidator/PropertyValidator/AbstractPropertyValidator.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace Chapi\Service\JobValidator\PropertyValidator;
 
 
-use Chapi\Entity\Chronos\JobEntity;
 use Chapi\Entity\JobEntityInterface;
 use Chapi\Service\JobValidator\PropertyValidatorInterface;
 

src/Entity/Chronos/JobEntity/ContainerVolumeEntity.php

Braces +1 added lines, -2 removed lines

@@ -26,8 +26,7 @@
                     $this->{$_sKey} = $_mValue;
                 }
             }
-        }
-        else
+        } else
         {
             throw new \InvalidArgumentException(sprintf('Argument 1 passed to "%s" must be an array or object', __METHOD__));
         }

src/Entity/Chronos/ChronosJobEntity.php

Braces +3 added lines, -6 removed lines

@@ -94,15 +94,13 @@ 
                     if ($_sKey == 'container')
                     {
                         $this->{$_sKey} = new ContainerEntity($_mValue);
-                    }
-                    else
+                    } else
                     {
                         $this->{$_sKey} = $_mValue;    
                     }
                 }
             }
-        }
-        else
+        } else
         {
             throw new \InvalidArgumentException(sprintf('Argument 1 passed to "%s" must be an array or object', __METHOD__));
         }
@@ -150,8 +148,7 @@ 
         if (!empty($this->schedule))
         {
             unset($_aReturn['parents']);
-        }
-        else
+        } else
         {
             unset($_aReturn['schedule']);
             unset($_aReturn['scheduleTimeZone']);

src/Entity/Marathon/MarathonEntityUtils.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      */
     public static function setAllPossibleProperties($oData, $oTarget)
     {
-        foreach($oData as $attrName => $attrValue)
+        foreach ($oData as $attrName => $attrValue)
         {
             // dont set array or objects.
             // Because this would need further type information to properly set.

src/Component/DatePeriod/DatePeriodFactory.php

Braces +2 added lines, -4 removed lines

@@ -38,8 +38,7 @@ 
         try
         {
             return self::$aIso8601Entity[$_sKey] = new Iso8601Entity($sIso8601);
-        }
-        catch (\InvalidArgumentException $_oException)
+        } catch (\InvalidArgumentException $_oException)
         {
             throw new DatePeriodException(sprintf("Can't init Iso8601Entity for '%s' iso 8601 string.", $sIso8601), 1, $_oException);
         }
@@ -57,8 +56,7 @@ 
         if (!empty($sTimeZone))
         {
             $_oDateStart = new \DateTime(str_replace('Z', '', $_oIso8601Entity->sStartTime), new \DateTimeZone($sTimeZone));
-        }
-        else
+        } else
         {
             // todo: use a defined chronos time zone here?
             $_oDateStart = new \DateTime($_oIso8601Entity->sStartTime);

src/Component/RemoteClients/ChronosApiClient.php

Spacing +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
      */
     public function removeJob($sJobName)
     {
-        $_oResponse = $this->oHttpClient->delete('/scheduler/job/' . $sJobName);
+        $_oResponse = $this->oHttpClient->delete('/scheduler/job/'.$sJobName);
         return ($_oResponse->getStatusCode() == 204);
     }
 
@@ -91,7 +91,7 @@ 
      */
     public function getJobStats($sJobName)
     {
-        return $this->sendGetJsonRequest('/scheduler/job/stat/' . $sJobName);
+        return $this->sendGetJsonRequest('/scheduler/job/stat/'.$sJobName);
     }
 
     /**

src/BusinessCase/Comparison/ChronosJobComparisonBusinessCase.php

Braces +1 added lines, -2 removed lines

@@ -317,8 +317,7 @@
         {
             $_oDateTime = new \DateTime(str_replace('Z', '', $_oIso8601Entity->sStartTime));
             $_oDateTime->setTimezone(new \DateTimeZone($sTimeZone));
-        }
-        else
+        } else
         {
             $_oDateTime = new \DateTime($_oIso8601Entity->sStartTime);
         }

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
     }
 
 
-    protected function preCompareModifications(JobEntityInterface &$oLocalJob, JobEntityInterface &$oRemoteJob)
+    protected function preCompareModifications(JobEntityInterface & $oLocalJob, JobEntityInterface & $oRemoteJob)
     {
         // no modification needed
         return;