BridgeFactory::getMarathonBridge() - Code Metrics - Inspection of "Feature/add marathon support" - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#68)

by Bidesh

created 2017-02-17 15:47 UTC

BridgeFactory::getMarathonBridge() A

↳ Parent: BridgeFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	12

Duplication

Lines	16
Ratio	88.89 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	16
loc	18
ccs	0
cts	9
cp	0
rs	9.4285
cc	2
eloc	12
nc	2
nop	4
crap	6

<?php
/**
 * @package: chapi
 *
 * @author:  bthapaliya
 * @since:   2017-02-14
 */


namespace Chapi\Service\JobRepository;


use Chapi\Component\Cache\CacheInterface;
use Chapi\Component\RemoteClients\ApiClientInterface;
use Chapi\Entity\Chronos\ChronosJobEntity;
use Chapi\Entity\Marathon\MarathonAppEntity;
use Chapi\Service\JobValidator\JobValidatorServiceInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\Filesystem\Filesystem;

class BridgeFactory

{
    public static function getChronosBridge(

        ApiClientInterface $oApiClient,
        CacheInterface $oCache,
        JobValidatorServiceInterface $oJobEntityValidatorService,
        LoggerInterface $oLogger
    )
    {
        if ($oApiClient->ping())
        {
            return new BridgeChronos(
                $oApiClient,
                $oCache,
                $oJobEntityValidatorService,
                $oLogger);
        }

        return new DummyBridge($oLogger);
    }

    public static function getMarathonBridge(

        ApiClientInterface $oApiClient,
        CacheInterface $oCache,
        JobValidatorServiceInterface $oJobEntityValidatorService,
        LoggerInterface $oLogger
    )
    {
        if ($oApiClient->ping())
        {
            return new BridgeMarathon(
                $oApiClient,
                $oCache,
                $oJobEntityValidatorService,
                $oLogger);
        }

        return new DummyBridge($oLogger);
    }


    public static function getFilesystemBridge(
        Filesystem $oFileSystemService,
        CacheInterface $oCache,
        $sRepositoryDir,
        LoggerInterface $oLogger
    )
    {
        if (empty($sRepositoryDir))
        {
            return new DummyBridge($oLogger);
        }

        return new BridgeFileSystem(
            $oFileSystemService,
            $oCache,
            $sRepositoryDir
        );
    }
}


1		<?php
2		/**
3		* @package: chapi
4		*
5		* @author: bthapaliya
6		* @since: 2017-02-14
7		*/
8
9
10		namespace Chapi\Service\JobRepository;
11
12
13		use Chapi\Component\Cache\CacheInterface;
14		use Chapi\Component\RemoteClients\ApiClientInterface;
15		use Chapi\Entity\Chronos\ChronosJobEntity;
16		use Chapi\Entity\Marathon\MarathonAppEntity;
17		use Chapi\Service\JobValidator\JobValidatorServiceInterface;
18		use Psr\Log\LoggerInterface;
19		use Symfony\Component\Filesystem\Filesystem;
20
21		class BridgeFactory
		0 ignored issues – show Coding Style introduced 2017-02-16 13:15 UTC by Report Bug Copy Issue Report `BridgeFactory` does not seem to conform to the naming convention (`Utils?$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
22		{
23	View Code Duplication	public static function getChronosBridge(
		0 ignored issues – show Duplication introduced 2017-02-16 13:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		ApiClientInterface $oApiClient,
25		CacheInterface $oCache,
26		JobValidatorServiceInterface $oJobEntityValidatorService,
27		LoggerInterface $oLogger
28		)
29		{
30		if ($oApiClient->ping())
31		{
32		return new BridgeChronos(
33		$oApiClient,
34		$oCache,
35		$oJobEntityValidatorService,
36		$oLogger);
37		}
38
39		return new DummyBridge($oLogger);
40		}
41
42	View Code Duplication	public static function getMarathonBridge(
		0 ignored issues – show Duplication introduced 2017-02-16 13:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		ApiClientInterface $oApiClient,
44		CacheInterface $oCache,
45		JobValidatorServiceInterface $oJobEntityValidatorService,
46		LoggerInterface $oLogger
47		)
48		{
49		if ($oApiClient->ping())
50		{
51		return new BridgeMarathon(
52		$oApiClient,
53		$oCache,
54		$oJobEntityValidatorService,
55		$oLogger);
56		}
57
58		return new DummyBridge($oLogger);
59		}
60
61
62		public static function getFilesystemBridge(
63		Filesystem $oFileSystemService,
64		CacheInterface $oCache,
65		$sRepositoryDir,
66		LoggerInterface $oLogger
67		)
68		{
69		if (empty($sRepositoryDir))
70		{
71		return new DummyBridge($oLogger);
72		}
73
74		return new BridgeFileSystem(
75		$oFileSystemService,
76		$oCache,
77		$sRepositoryDir
78		);
79		}
80		}
81

trivago / chapi

GitHub Access Token became invalid

Pull Request — master (#68)

BridgeFactory::getMarathonBridge() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like