Code Duplication - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 19-23 lines in 2 locations

src/BusinessCase/JobManagement/ChronosStoreJobBusinessCase.php 1 location


    /**
     * @inheritdoc
     */
    public function storeIndexedJobs()
    {
        // add new jobs to chronos
        $_aNewJobs = $this->oJobComparisonBusinessCase->getRemoteMissingJobs();
        foreach ($_aNewJobs as $_sJobName)
        {
            $this->hasAddedJob($_sJobName);
        }

        // delete missing jobs from chronos
        $_aMissingJobs = $this->oJobComparisonBusinessCase->getLocalMissingJobs();
        foreach ($_aMissingJobs as $_sJobName)
        {
            $this->hasRemovedJob($_sJobName);
        }

        // update jobs on chronos
        $_aLocalJobUpdates = $this->oJobComparisonBusinessCase->getLocalJobUpdates();
        foreach ($_aLocalJobUpdates as $_sJobName)
        {
            $this->hasUpdatedJob($_sJobName);
        }
    }

    /**
     * @param string $sJobName

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php 1 location


    /**
     * @return void
     */
    public function storeIndexedJobs()
    {
        $_aRemoteMissingApps = $this->oJobComparisonBusinessCase->getRemoteMissingJobs();
        foreach ($_aRemoteMissingApps as $_sAppId)
        {
            $this->addRemoteMissingApp($_sAppId);
        }

        $_aLocalMissingApps = $this->oJobComparisonBusinessCase->getLocalMissingJobs();
        foreach ($_aLocalMissingApps as $_sAppId)
        {
            $this->removeLocalMissingAppInRemote($_sAppId);
        }
        $_aLocalUpdates = $this->oJobComparisonBusinessCase->getLocalJobUpdates();
        foreach ($_aLocalUpdates as $_sAppId)
        {
            $this->updateAppInRemote($_sAppId);
        }
    }

    private function addRemoteMissingApp($sAppId)
    {

		@@ 48-70 (lines=23) @@
45		/**
46		* @inheritdoc
47		*/
48		public function storeIndexedJobs()
49		{
50		// add new jobs to chronos
51		$_aNewJobs = $this->oJobComparisonBusinessCase->getRemoteMissingJobs();
52		foreach ($_aNewJobs as $_sJobName)
53		{
54		$this->hasAddedJob($_sJobName);
55		}
56
57		// delete missing jobs from chronos
58		$_aMissingJobs = $this->oJobComparisonBusinessCase->getLocalMissingJobs();
59		foreach ($_aMissingJobs as $_sJobName)
60		{
61		$this->hasRemovedJob($_sJobName);
62		}
63
64		// update jobs on chronos
65		$_aLocalJobUpdates = $this->oJobComparisonBusinessCase->getLocalJobUpdates();
66		foreach ($_aLocalJobUpdates as $_sJobName)
67		{
68		$this->hasUpdatedJob($_sJobName);
69		}
70		}
71
72		/**
73		* @param string $sJobName

		@@ 43-61 (lines=19) @@
40		/**
41		* @return void
42		*/
43		public function storeIndexedJobs()
44		{
45		$_aRemoteMissingApps = $this->oJobComparisonBusinessCase->getRemoteMissingJobs();
46		foreach ($_aRemoteMissingApps as $_sAppId)
47		{
48		$this->addRemoteMissingApp($_sAppId);
49		}
50
51		$_aLocalMissingApps = $this->oJobComparisonBusinessCase->getLocalMissingJobs();
52		foreach ($_aLocalMissingApps as $_sAppId)
53		{
54		$this->removeLocalMissingAppInRemote($_sAppId);
55		}
56		$_aLocalUpdates = $this->oJobComparisonBusinessCase->getLocalJobUpdates();
57		foreach ($_aLocalUpdates as $_sAppId)
58		{
59		$this->updateAppInRemote($_sAppId);
60		}
61		}
62
63		private function addRemoteMissingApp($sAppId)
64		{

trivago / chapi

GitHub Access Token became invalid

Code Duplication Length = 19-23 lines in 2 locations

src/BusinessCase/JobManagement/ChronosStoreJobBusinessCase.php 1 location

src/BusinessCase/JobManagement/MarathonStoreJobBusinessCase.php 1 location