Container::isContainerPropertyValid() - Code Metrics - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Container::isContainerPropertyValid() C
last analyzed 2018-04-24 11:16 UTC

↳ Parent: Container

Complexity

Conditions	7
Paths	6

Size

Total Lines	22
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	7

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	11
cts	11
cp	1
rs	6.9811
c	0
b	0
f	0
cc	7
eloc	11
nc	6
nop	1
crap	7

<?php
/**
 * @package: chapi
 *
 * @author:  msiebeneicher
 * @since:   2016-11-10
 */


namespace Chapi\Service\JobValidator\PropertyValidator;

use Chapi\Entity\Chronos\JobEntity;
use Chapi\Entity\JobEntityInterface;
use Chapi\Service\JobValidator\PropertyValidatorInterface;

class Container extends AbstractPropertyValidator implements PropertyValidatorInterface
{
    const DIC_NAME = 'ContainerValidator';
    const MESSAGE_TEMPLATE = '"%s" is not valid. Type (required), image (required), forcePullImage (optional), network (optional), and volumes (optional)';

    /**
     * @inheritDoc
     */
    public function isValid($property, JobEntityInterface $jobEntity)
    {
        return $this->returnIsValidHelper(
            $this->isContainerPropertyValid($jobEntity->{$property}),
            $property,
            self::MESSAGE_TEMPLATE
        );
    }

    /**
     * @param JobEntity\ContainerEntity $container
     * @return bool
     *
     * @see http://mesos.github.io/chronos/docs/api.html#adding-a-docker-job
     * This contains the subfields for the Docker container:
     *  type (required), image (required), forcePullImage (optional), network (optional),
     *  and volumes (optional)
     */
    private function isContainerPropertyValid($container)
    {
        if (is_null($container)) {
            return true;
        }

        if (empty($container->type) || empty($container->image)) {
            return false;
        }

        if (!is_array($container->volumes)) {
            return false;
        }

        foreach ($container->volumes as $volume) {
            if (!in_array($volume->mode, ['RO', 'RW'])) {
                return false;
            }
        }

        return true;
    }
}


1		<?php
2		/**
3		* @package: chapi
4		*
5		* @author: msiebeneicher
6		* @since: 2016-11-10
7		*/
8
9
10		namespace Chapi\Service\JobValidator\PropertyValidator;
11
12		use Chapi\Entity\Chronos\JobEntity;
13		use Chapi\Entity\JobEntityInterface;
14		use Chapi\Service\JobValidator\PropertyValidatorInterface;
15
16		class Container extends AbstractPropertyValidator implements PropertyValidatorInterface
17		{
18		const DIC_NAME = 'ContainerValidator';
19		const MESSAGE_TEMPLATE = '"%s" is not valid. Type (required), image (required), forcePullImage (optional), network (optional), and volumes (optional)';
20
21		/**
22		* @inheritDoc
23		*/
24	3	public function isValid($property, JobEntityInterface $jobEntity)
25		{
26	3	return $this->returnIsValidHelper(
27	3	$this->isContainerPropertyValid($jobEntity->{$property}),
28	3	$property,
29	3	self::MESSAGE_TEMPLATE
30		);
31		}
32
33		/**
34		* @param JobEntity\ContainerEntity $container
35		* @return bool
36		*
37		* @see http://mesos.github.io/chronos/docs/api.html#adding-a-docker-job
38		* This contains the subfields for the Docker container:
39		* type (required), image (required), forcePullImage (optional), network (optional),
40		* and volumes (optional)
41		*/
42	3	private function isContainerPropertyValid($container)
43		{
44	3	if (is_null($container)) {
45	2	return true;
46		}
47
48	3	if (empty($container->type) \|\| empty($container->image)) {
49	2	return false;
50		}
51
52	2	if (!is_array($container->volumes)) {
53	1	return false;
54		}
55
56	2	foreach ($container->volumes as $volume) {
57	2	if (!in_array($volume->mode, ['RO', 'RW'])) {
58	2	return false;
59		}
60		}
61
62	1	return true;
63		}
64		}
65

trivago / chapi

GitHub Access Token became invalid

Container::isContainerPropertyValid() C last analyzed 2018-04-24 11:16 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Container::isContainerPropertyValid() C
last analyzed 2018-04-24 11:16 UTC