Command::isValid() - Code Metrics - trivago/chapi - Measure and Improve Code Quality continuously with Scrutinizer

Command::isValid() A
last analyzed 2018-04-24 11:16 UTC

↳ Parent: Command

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	1
b	0
f	1
cc	1
eloc	5
nc	1
nop	2
crap	1

<?php
/**
 * @package: chapi
 *
 * @author:  msiebeneicher
 * @since:   2016-11-10
 *
 */


namespace Chapi\Service\JobValidator\PropertyValidator;

use Chapi\Entity\Chronos\ChronosJobEntity;
use Chapi\Entity\Chronos\JobEntity;
use Chapi\Entity\JobEntityInterface;
use Chapi\Service\JobValidator\PropertyValidatorInterface;

class Command extends AbstractPropertyValidator implements PropertyValidatorInterface
{
    const DIC_NAME = 'CommandValidator';
    const MESSAGE_TEMPLATE = '"%s" is not allowed to be empty for non docker jobs';

    /**
     * @inheritDoc
     */
    public function isValid($property, JobEntityInterface $jobEntity)
    {
        return $this->returnIsValidHelper(
            $this->isCommandPropertyValid($jobEntity),
            $property,
            self::MESSAGE_TEMPLATE
        );
    }

    /**
     * @param JobEntityInterface $jobEntity
     * @return bool
     */
    private function isCommandPropertyValid(JobEntityInterface $jobEntity)
    {
        if (!$jobEntity instanceof ChronosJobEntity) {
            throw new \RuntimeException('Required ChronosJobEntity. Something else found.');
        }

        if (is_null($jobEntity->container)) {
            return (!empty($jobEntity->command) && is_string($jobEntity->command));
        }
        
        return (empty($jobEntity->command) || is_string($jobEntity->command));
    }
}


1		<?php
2		/**
3		* @package: chapi
4		*
5		* @author: msiebeneicher
6		* @since: 2016-11-10
7		*
8		*/
9
10
11		namespace Chapi\Service\JobValidator\PropertyValidator;
12
13		use Chapi\Entity\Chronos\ChronosJobEntity;
14		use Chapi\Entity\Chronos\JobEntity;
15		use Chapi\Entity\JobEntityInterface;
16		use Chapi\Service\JobValidator\PropertyValidatorInterface;
17
18		class Command extends AbstractPropertyValidator implements PropertyValidatorInterface
19		{
20		const DIC_NAME = 'CommandValidator';
21		const MESSAGE_TEMPLATE = '"%s" is not allowed to be empty for non docker jobs';
22
23		/**
24		* @inheritDoc
25		*/
26	3	public function isValid($property, JobEntityInterface $jobEntity)
27		{
28	3	return $this->returnIsValidHelper(
29	3	$this->isCommandPropertyValid($jobEntity),
30	3	$property,
31	3	self::MESSAGE_TEMPLATE
32		);
33		}
34
35		/**
36		* @param JobEntityInterface $jobEntity
37		* @return bool
38		*/
39	3	private function isCommandPropertyValid(JobEntityInterface $jobEntity)
40		{
41	3	if (!$jobEntity instanceof ChronosJobEntity) {
42		throw new \RuntimeException('Required ChronosJobEntity. Something else found.');
43		}
44
45	3	if (is_null($jobEntity->container)) {
46	3	return (!empty($jobEntity->command) && is_string($jobEntity->command));
47		}
48
49	1	return (empty($jobEntity->command) \|\| is_string($jobEntity->command));
50		}
51		}
52

trivago / chapi

GitHub Access Token became invalid

Command::isValid() A last analyzed 2018-04-24 11:16 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Command::isValid() A
last analyzed 2018-04-24 11:16 UTC