Tristanbes\MyPoseoBundle\Api\Search::doRequest()

Complexity

Conditions	8
Paths	17

Size

Total Lines	26
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Search::getTownCode()	0	10	1

<?php

/**
 * MyPoseo API Bundle
 *
 * @author Tristan Bessoussa <tristan.bessoussa@gmail.com>
 */

namespace Tristanbes\MyPoseoBundle\Api;

use Http\Client\Common\PluginClient;
use Http\Client\HttpClient;
use Doctrine\Common\Cache\Cache;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Message\Authentication\QueryParam;
use Http\Client\Common\Plugin\AuthenticationPlugin;

use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Tristanbes\MyPoseoBundle\Connection\RestClient;
use Tristanbes\MyPoseoBundle\Exception\NotEnoughCreditsException;

/**
 * @see http://fr.myposeo.com/nos-api/api-search/
 */
class Search implements SearchInterface
{
    /**
     * @var RestClient
     */
    private $client;

    /**
     * @param RestClient $client The http client
     */
    public function __construct(RestClient $client)
    {
        $this->client = $client;
    }

    /**
     * Returns the identifiers of the search engine's extension
     *
     * @param string  $searchEngine The search engine
     * @param integer $ttl          The time to live for the cache
     *
     * @return array [['id' => 1, 'name => '.fr'] [...]]
     */
    public function getSearchEngineExtensions($searchEngine, $ttl = null)
    {
        $cacheKey = sprintf('%s_locations', $searchEngine);

        $data = $this->client->get('tool/json', [
            'method'       => 'getLocations',
            'searchEngine' => $searchEngine,
        ], $cacheKey, $ttl);

It seems like $ttl defined by parameter $ttl on line 49 can also be of type integer; however, Tristanbes\MyPoseoBundle\Connection\RestClient::get() does only seem to accept null, maybe add an additional type check?

        return $data;
    }

    /**
     * Get the town's code
     *
     * @param string $name    The town name
     * @param string $country The country ISO
     *
     * @return array [['id' => 1, 'city_code => '1234', 'city_name' => 'dunkerque', 'code_dep' : '59']]
     */
    public function getTownCode($name, $country = 'FR')
    {
        $data = $this->client->get('tool/json', [
            'method'  => 'getGeoloc',
            'country' => $country,
            'city'    => $name,
        ]);

        return $data;
    }

    /**
     * Retrieves the url position given a keyword
     *
     * @param string  $keyword
     * @param string  $url
     * @param string  $searchEngine
     * @param string  $callback
     * @param integer $geolocId
     * @param integer $location
     * @param integer $maxPage
     *
     * @return array
     *
     *   {
     *     "url_positioned": "",
     *     "position": "+100",
     *     "page": "-",
     *     "type": "seo_natural",
     *     "serp": "",
     *     "nbr_results": 250000000,
     *     "top": "https://urltestdefault.com/path/to/image",
     *     "keyword": "keyword",
     *     "url_search": "lemonde.fr",
     *     "searchEngine": "google",
     *     "location": "13"
     *   }
     */
    public function getUrlRankByKeyword($keyword, $url, $searchEngine = 'google', $callback = null, $geolocId = null, $location = 13, $maxPage = null)
    {
        $options = [];

        if ($callback) {

The expression $callback of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $options['callback'] = $callback;
        }

        if ($geolocId) {

The expression $geolocId of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $options['geolocId'] = $geolocId;
        }

        if ($maxPage) {

The expression $maxPage of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $options['maxPage'] = $maxPage;
        }

        $data = $this->client->get('tool/json', array_merge([
            'method'       => 'getPosition',
            'keyword'      => $keyword,
            'url'          => $url,
            'searchEngine' => $searchEngine,
            'location'     => $location,
        ], $options));

        return $data;
    }

    public function getNaturalSeoResult()
    {
        // @todo, feel free to send a PR
    }

    public function getSemResult()
    {
        // @todo, feel free to send a PR
    }
}