Price::map() - Code Metrics - Inspection of "Partner" - tricae-br/iris - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by Rafael

created 2016-01-07 20:55 UTC

Price::map() A

↳ Parent: Price

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	16
rs	9.4286
cc	2
eloc	10
nc	2
nop	1

<?php

namespace Iris\Mapping;

class Price extends Base
{
    /**
     * {@inheritdoc}
     */
    public function assign(array $externalData)
    {
        $priceCollection = new \Iris\Transfer\Catalog\ConfigCollection;
        foreach ($externalData as $data) {
            $price = new \Iris\Transfer\Catalog\Config([
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'sku'             => $data['sku'],
                'price'           => $data['price'],
                'special_price'   => $data['special_price'],
                'specialFromDate' => $data['special_from_date'],
                'specialToDate'   => $data['special_to_date']
            ]);
        }

        return $priceCollection;
    }

    /**
     * {@inheritdoc}
     */
    public function map($internalData)
    {
        $externalData = ['items' => []];

        foreach ($internalData->getItemCollection() as $item) {
            $externalData['items'][] = [
                'sku'             => $item->getSku(),
                'price'           => $item->getPrice(),
                'special_price'   => $item->getSpecialPrice(),
                'specialFromDate' => $item->getSpecialFromDate(),
                'specialToDate'   => $item->getSpecialToDate()
            ];  
        }

        return $externalData;
    }
}


1			<?php
2
3			namespace Iris\Mapping;
4
5			class Price extends Base
6			{
7			/**
8			* {@inheritdoc}
9			*/
10			public function assign(array $externalData)
11			{
12			$priceCollection = new \Iris\Transfer\Catalog\ConfigCollection;
13			foreach ($externalData as $data) {
14			$price = new \Iris\Transfer\Catalog\Config([
			0 ignored issues – show Unused Code introduced 2016-01-07 20:58 UTC by Report Bug Copy Issue Report `$price` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
15			'sku' => $data['sku'],
16			'price' => $data['price'],
17			'special_price' => $data['special_price'],
18			'specialFromDate' => $data['special_from_date'],
19			'specialToDate' => $data['special_to_date']
20			]);
21			}
22
23			return $priceCollection;
24			}
25
26			/**
27			* {@inheritdoc}
28			*/
29			public function map($internalData)
30			{
31			$externalData = ['items' => []];
32
33			foreach ($internalData->getItemCollection() as $item) {
34			$externalData['items'][] = [
35			'sku' => $item->getSku(),
36			'price' => $item->getPrice(),
37			'special_price' => $item->getSpecialPrice(),
38			'specialFromDate' => $item->getSpecialFromDate(),
39			'specialToDate' => $item->getSpecialToDate()
40			];
41			}
42
43			return $externalData;
44			}
45			}
46

tricae-br / iris

Pull Request — master (#8)

Price::map() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like