ShippedFromVenture::assign() - Code Metrics - Inspection of "Partner" - tricae-br/iris - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by Rafael

created 2016-01-08 17:53 UTC

ShippedFromVenture::assign() A

↳ Parent: ShippedFromVenture

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
ccs	0
cts	14
cp	0
rs	9.4286
cc	2
eloc	12
nc	2
nop	1
crap	6

<?php

namespace Iris\Mapping;

class ShippedFromVenture extends Base
{
    /**
     * {@inheritdoc}
     */
    public function assign(array $externalData)
    {
        $postPaymentCollection = new \Iris\Transfer\PostPayment\PostPaymentCollection;
        foreach ($externalData as $data) {
            $postPaymentCollection[] = new \Iris\Transfer\PostPayment\PostPayment([
                'deliveryType'       => $data['deliveryType'],
                'shippingProvider'   => $data['shippingProvider'],
                'trackingCode'       => $data['trackingCode'],
                'trackingUrl'        => $data['trackingUrl'],
                'nfeKey'             => $data['nfeKey'],
                'ventureOrderNumber' => $data['ventureOrderNumber'],
                'ventureOrderItemId' => $data['ventureOrderItemId']
            ]);
        }

        return $postPaymentCollection;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function map($internalData)
    {
        $externalData = ['items' => []];
        foreach ($internalData as $item) {
            $externalData['items'][] = [
                'deliveryType'       => $item->getDeliveryType(),
                'shippingProvider'   => $item->getShippingProvider(),
                'trackingCode'       => $item->getTrackingCode(),
                'trackingUrl'        => $item->getTrackingUrl(),
                'nfeKey'             => $item->getNfeKey(),
                'ventureOrderNumber' => $item->getVentureOrderNumber(),
                'ventureOrderItemId' => $item->getVentureOrderItemId()
            ];
        }

        return $externalData;
    }
}


1			<?php
2
3			namespace Iris\Mapping;
4
5			class ShippedFromVenture extends Base
6			{
7			/**
8			* {@inheritdoc}
9			*/
10			public function assign(array $externalData)
11			{
12			$postPaymentCollection = new \Iris\Transfer\PostPayment\PostPaymentCollection;
13			foreach ($externalData as $data) {
14			$postPaymentCollection[] = new \Iris\Transfer\PostPayment\PostPayment([
15			'deliveryType' => $data['deliveryType'],
16			'shippingProvider' => $data['shippingProvider'],
17			'trackingCode' => $data['trackingCode'],
18			'trackingUrl' => $data['trackingUrl'],
19			'nfeKey' => $data['nfeKey'],
20			'ventureOrderNumber' => $data['ventureOrderNumber'],
21			'ventureOrderItemId' => $data['ventureOrderItemId']
22			]);
23			}
24
25			return $postPaymentCollection;
			0 ignored issues – show Bug Best Practice introduced 2016-01-08 17:55 UTC by Report Bug Copy Issue Report The return type of `return $postPaymentCollection;` (`Iris\Transfer\PostPayment\PostPaymentCollection`) is incompatible with the return type declared by the abstract method `Iris\Mapping\Base::assign` of type `Iris\Transfer\Catalog\ConfigCollection`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
26			}
27
28			/**
29			* {@inheritdoc}
30			*/
31			public function map($internalData)
32			{
33			$externalData = ['items' => []];
34			foreach ($internalData as $item) {
35			$externalData['items'][] = [
36			'deliveryType' => $item->getDeliveryType(),
37			'shippingProvider' => $item->getShippingProvider(),
38			'trackingCode' => $item->getTrackingCode(),
39			'trackingUrl' => $item->getTrackingUrl(),
40			'nfeKey' => $item->getNfeKey(),
41			'ventureOrderNumber' => $item->getVentureOrderNumber(),
42			'ventureOrderItemId' => $item->getVentureOrderItemId()
43			];
44			}
45
46			return $externalData;
47			}
48			}
49

tricae-br / iris

Pull Request — master (#8)

ShippedFromVenture::assign() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like