SimpleCollection::map() - Code Metrics - Inspection of "Refactoring tracking partner and product venture" - tricae-br/iris - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by Rafael

created 2016-01-07 16:37 UTC

SimpleCollection::map() A

↳ Parent: SimpleCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	23
rs	9.0857
cc	2
eloc	18
nc	2
nop	1

<?php

namespace Iris\Mapping;

class SimpleCollection extends Base
{
    /**
     * {@inheritdoc}
     */
    public function assign(array $externalData)
    {
        $simpleCollection = new \Iris\Transfer\Catalog\SimpleCollection;

        foreach ($externalData as $c) {
            $simpleCollection[] = new \Iris\Transfer\Catalog\Simple([
                'sku'              => $c['sku'],
                'variation'        => $c['variation'],
                'brand'            => $c['brand'],
                'color'            => $c['color'],
                'gender'           => $c['gender'],
                'color_family'     => $c['color_family'],
                'box_height'       => $c['box_height'],
                'box_width'        => $c['box_width'],
                'box_length'       => $c['box_length'],
                'weight'           => $c['weight'],
                'color_name_brand' => $c['color_name_brand'],
                'quantity'         => $c['quantity'],
                'barcode_ean'      => $c['barcode_ean']
            ]);
        }

        return $simpleCollection;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     * @param \Iris\Transfer\Catalog\SimpleCollection $internalData
     */
    public function map($internalData)
    {
        $externalData = [];
        foreach ($internalData as $simple) {
            $externalData[] = [
                'sku'              => $simple->getSku(),
                'variation'        => $simple->getVariation(),
                'brand'            => $simple->getBrand(),
                'color'            => $simple->getColor(),
                'gender'           => $simple->getGender(),
                'color_family'     => $simple->getColorFamily(),
                'box_height'       => $simple->getBoxHeight(),
                'box_width'        => $simple->getBoxWidth(),
                'box_length'       => $simple->getBoxlength(),
                'weight'           => $simple->getWeight(),
                'color_name_brand' => $simple->getColorNameBrand(),
                'quantity'         => $simple->getQuantity(),
                'barcode_ean'      => $simple->getBarcodeEan()
            ];
        }

        return $externalData;
    }
}


1			<?php
2
3			namespace Iris\Mapping;
4
5			class SimpleCollection extends Base
6			{
7			/**
8			* {@inheritdoc}
9			*/
10			public function assign(array $externalData)
11			{
12			$simpleCollection = new \Iris\Transfer\Catalog\SimpleCollection;
13
14			foreach ($externalData as $c) {
15			$simpleCollection[] = new \Iris\Transfer\Catalog\Simple([
16			'sku' => $c['sku'],
17			'variation' => $c['variation'],
18			'brand' => $c['brand'],
19			'color' => $c['color'],
20			'gender' => $c['gender'],
21			'color_family' => $c['color_family'],
22			'box_height' => $c['box_height'],
23			'box_width' => $c['box_width'],
24			'box_length' => $c['box_length'],
25			'weight' => $c['weight'],
26			'color_name_brand' => $c['color_name_brand'],
27			'quantity' => $c['quantity'],
28			'barcode_ean' => $c['barcode_ean']
29			]);
30			}
31
32			return $simpleCollection;
			0 ignored issues – show Bug Best Practice introduced 2016-01-07 16:41 UTC by Report Bug Copy Issue Report The return type of `return $simpleCollection;` (`Iris\Transfer\Catalog\SimpleCollection`) is incompatible with the return type declared by the abstract method `Iris\Mapping\Base::assign` of type `Iris\Transfer\Catalog\ConfigCollection`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
33			}
34
35			/**
36			* {@inheritdoc}
37			* @param \Iris\Transfer\Catalog\SimpleCollection $internalData
38			*/
39			public function map($internalData)
40			{
41			$externalData = [];
42			foreach ($internalData as $simple) {
43			$externalData[] = [
44			'sku' => $simple->getSku(),
45			'variation' => $simple->getVariation(),
46			'brand' => $simple->getBrand(),
47			'color' => $simple->getColor(),
48			'gender' => $simple->getGender(),
49			'color_family' => $simple->getColorFamily(),
50			'box_height' => $simple->getBoxHeight(),
51			'box_width' => $simple->getBoxWidth(),
52			'box_length' => $simple->getBoxlength(),
53			'weight' => $simple->getWeight(),
54			'color_name_brand' => $simple->getColorNameBrand(),
55			'quantity' => $simple->getQuantity(),
56			'barcode_ean' => $simple->getBarcodeEan()
57			];
58			}
59
60			return $externalData;
61			}
62			}
63

tricae-br / iris

Pull Request — master (#7)

SimpleCollection::map() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like