Price::assign() - Code Metrics - Inspection of "Refactoring tracking partner and product venture" - tricae-br/iris - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by Rafael

created 2016-01-07 16:37 UTC

Price::assign() A

↳ Parent: Price

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
rs	9.4286
cc	2
eloc	7
nc	2
nop	1

<?php

namespace Iris\Mapping;

class Price extends Base
{
    /**
     * {@inheritdoc}
     */
    public function assign(array $externalData)
    {
        $priceCollection = new \Iris\Transfer\Catalog\PriceCollection;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        foreach ($externalData as $p) {
            $price = new \Iris\Transfer\Catalog\Price([
                'sku'   => $p['sku'],
                'price' => $p['price']
            ]);
        }

        return $price;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * {@inheritdoc}
     */
    public function map($internalData)
    {
        $externalData = array();

        foreach ($internalData->getItemCollection() as $price) {
            $externalData[] = [
                'sku'   => $price->getSku(),
                'price' => $price->getPrice(),
            ];  
        }

        return $externalData;
    }
}


1			<?php
2
3			namespace Iris\Mapping;
4
5			class Price extends Base
6			{
7			/**
8			* {@inheritdoc}
9			*/
10			public function assign(array $externalData)
11			{
12			$priceCollection = new \Iris\Transfer\Catalog\PriceCollection;
			0 ignored issues – show Unused Code introduced 2016-01-07 16:41 UTC by Report Bug Copy Issue Report `$priceCollection` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
13			foreach ($externalData as $p) {
14			$price = new \Iris\Transfer\Catalog\Price([
15			'sku' => $p['sku'],
16			'price' => $p['price']
17			]);
18			}
19
20			return $price;
			0 ignored issues – show Bug introduced 2016-01-07 16:41 UTC by Report Bug Copy Issue Report The variable `$price` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug Best Practice introduced 2016-01-07 16:41 UTC by Report Bug Copy Issue Report The return type of `return $price;` (`Iris\Transfer\Catalog\Price`) is incompatible with the return type declared by the abstract method `Iris\Mapping\Base::assign` of type `Iris\Transfer\Catalog\ConfigCollection`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
21			}
22
23			/**
24			* {@inheritdoc}
25			*/
26			public function map($internalData)
27			{
28			$externalData = array();
29
30			foreach ($internalData->getItemCollection() as $price) {
31			$externalData[] = [
32			'sku' => $price->getSku(),
33			'price' => $price->getPrice(),
34			];
35			}
36
37			return $externalData;
38			}
39			}
40

tricae-br / iris

Pull Request — master (#7)

Price::assign() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like