Partner - Code Metrics - Inspection of "Refactoring tracking partner and product venture" - tricae-br/iris - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by Rafael

created 2016-01-07 16:37 UTC

Partner A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	286
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Test Coverage

Coverage

100%

Importance

Changes	6
Bugs	1	Features	1

Metric	Value
wmc	27
c	6
b	1
f	1
lcom	1
cbo	10
dl	0
loc	286
ccs	47
cts	47
cp	1
rs	10

24 Methods

Rating	Name	Size	Complexity
A	getName()	4	1
A	getVentureService()	4	1
A	getStockService()	4	1
A	getCatalogService()	4	1
A	isVentureItem()	7	1
A	sendOrderToVenture()	7	1
A	dropReserveAndUpdateStock()	8	1
A	confirmOrderPaidOnVenture()	10	1
A	confirmOrderFromVenture()	5	1
A	cancelOrderOnVenture()	10	1
A	cancelOrderFromVenture()	9	1
A	bindVentureOrder()	9	1
A	getMapping()	9	2
A	setMapping()	5	1
A	setOrderStatusToShippedFromVenture()	13	3
A	setOrderStatusToDeliveredFromVenture()	7	1
A	setOrderStatusToDeliveryFailedFromVenture()	8	1
A	updatePriceFromVenture()	5	1
A	updateStockFromVenture()	7	1
A	createProductsFromVenture()	7	1
A	sendProductCreationConfirmationToVenture()	13	1
A	updateProductsFromVenture()	7	1
A	updateProductImagesFromVenture()	7	1
A	isInvalidOrder()	4	1

<?php

namespace Iris\SaleWrapper;

class Partner extends Base implements PartnerInterface
{
    private $mappingClasses;

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'partner';
    }

    /**
     * Gets Venture service.
     * @return \Iris\Interfaces\IrisVenture
     */
    public function getVentureService()
    {
        return $this->getManager()->getService(\Iris\Factory::VENTURE);
    }

    /**
     * Gets Stock service.
     * @return \Iris\Interfaces\Stock
     */
    public function getStockService()
    {
        return $this->getManager()->getService(\Iris\Factory::STOCK);
    }

    /**
     * Gets Stock service.
     * @return \Iris\Interfaces\Catalog
     */
    public function getCatalogService()
    {
        return $this->getManager()->getService(\Iris\Factory::CATALOG);
    }


    //order
    /**
     * {@inheritdoc}
     */
    public function isVentureItem(\Iris\Transfer\Sales\Order\Item $item)
    {
        $irisVenture = $this->getVentureService()
            ->getIrisVentureBySalesOrderId($item->getFkSalesOrder());

        return ($irisVenture instanceof \Iris\Transfer\Venture);
    }

    /**
     * {@inheritdoc}
     */
    public function sendOrderToVenture(
        array $orderData,
        string $ventureCode
    ) {
        return $this->getPartnerApiClient()
            ->createOrderOnVenture($ventureCode, $orderData);
    }

    /**
     * {@inheritdoc}
     */
    public function dropReserveAndUpdateStock(
        \Iris\Transfer\Sales\Order\Item $orderItem,
        array $productsData,
        $ventureCode
    ) {
        $this->getStockService()->dropReserve($orderItem);
        $this->updateStockFromVenture($productsData, $ventureCode);
    }

    /**
     * {@inheritdoc}
     */
    public function confirmOrderPaidOnVenture(
        \Iris\Transfer\Sales\Order $order,
        \Iris\Transfer\Venture $venture
    ) {
        return $this->getPartnerApiClient()
            ->confirmPaymentOnVenture(
                $venture->getVentureCode(),
                $order->getOrderNr()
            );
    }

    /**
     * {@inheritdoc}
     */
    public function confirmOrderFromVenture(array $orderData, $ventureCode)
    {
        $order = $this->getMapping('Order')->assign($orderData);
        $this->getOrderService()->confirmOrderFromVenture($order);
    }

    /**
     * {@inheritdoc}
     */
    public function cancelOrderOnVenture(
        \Iris\Transfer\Sales\Order $order,
        \Iris\Transfer\Venture $venture
    ) {
        return $this->getPartnerApiClient()
            ->cancelOrderOnVenture(
                $venture->getVentureCode(),
                $order->getOrderNr()
            );
    }

    /**
     * {@inheritdoc}
     */
    public function cancelOrderFromVenture($orderNr, $ventureCode)
    {

        $order = $this->getOrderService()
            ->getOrderByOrderNumberAndVentureCode($orderNr, $ventureCode);

        $this->getOrderService()->cancelOrderFromVenture($order);
        return ['order_number' => $order->getOrderNr()];
    }

    /**
     * {@inheritdoc}
     */
    public function bindVentureOrder($orderNr, $ventureCode, $ventureorderNr)
    {
        $this->getOrderService()
            ->bindPartnerOrderWithVentureOrder(
                $orderNr,
                $ventureCode,
                $ventureOrderNr

            );
    }

    /**
     * Gets an specific mapping classs
     *
     * @param string $mappingName
     */
    public function getMapping($mappingName)
    {
        if (!$this->mappingClasses[$mappingName]) {
            $mappingClass = '\Iris\Mapping\\' . $mappingName;
            $this->mappingClasses[$mappingName] =  $mappingClass::getInstance();
        }

        return $this->mappingClasses[$mappingName];
    }

    /**
     * Set an specific mapping classs
     *
     * @param string $mappingName
     * @param $mappingClass
     * @return \Iris\SaleWrapper\Partner
     */
    public function setMapping($mappingName, $mappingClass)
    {
        $this->mappingClasses[$mappingName] = $mappingClass;
        return $this;
    }

    //post payment
    /**
     * {@inheritdoc}
     */
    public function setOrderStatusToShippedFromVenture(array $postPaymentData)
    {
        $postPaymentCollection = $this->getMapping('PostPaymentCollection')
            ->assign($postPaymentData);

        foreach ($postPaymentCollection as $postPayment) {
            if (!$postPayment->getTrackingCode()) {
                $postPayment->setTrackingCode(md5($postPayment->getTrackingUrl()));
            }
        }

        return $this->getOrderService()->shippedByVenture($postPayment);
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
    }

    /**
     * {@inheritdoc}
     */
    public function setOrderStatusToDeliveredFromVenture(
        array $postPaymentData, 
        $ventureCode
    ) {
        $postPayment = $this->getMapping('PostPayment')->assign($postPaymentData);
        return $this->getOrderService()->deliveredByVenture($postPayment);

    }

    /**
     * {@inheritdoc}
     */
    public function setOrderStatusToDeliveryFailedFromVenture(
        array $orderData,
        $ventureCode
    ) {
        $postPayment = $this->getMapping('PostPayment')->assign($postPaymentData);

        return $this->getOrderService()
            ->deliveryFailedByVenture($postPayment, $ventureCode);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    //products
    /**
     * {@inheritdoc}
     */
    public function updatePriceFromVenture(array $productsData, $ventureCode)
    {
        $configCollection = $this->getMapping('ConfigCollection')->assign($productsData);
        return $this->getCatalogService()->updatePrice($configCollection);
    }

    /**
     * {@inheritdoc}
     */
    public function updateStockFromVenture(array $productsData, $ventureCode)
    {
        $configCollection = $this->getMapping('SimpleCollection')
            ->assign($productsData);

        return $this->getStockService()->updateAbsoluteStock($configCollection);
    }

    /**
     * {@inheritdoc}
     */
    public function createProductsFromVenture(array $productsData, $ventureCode)
    {
        $configCollection = $this->getMapping('ConfigCollection')
            ->assign($productsData);

        return $this->getCatalogService()->createProducts($configCollection, $ventureCode);
    }

    /**
     * {@inheritdoc}
     */
    public function sendProductCreationConfirmationToVenture(
        \Iris\Transfer\Catalog\ConfigCollection $configCollection,
        \Iris\Transfer\Venture $venture
    ) {
        $productsData = $this->getMapping('ConfigCollection')
            ->map($configCollection);

        $this->getPartnerApiClient()
            ->sendProductCreationConfirmationToVenture(
                $productsData,
                $venture->getVentureCode()
            );
    }

    /**
     * {@inheritdoc}
     */
    public function updateProductsFromVenture(array $productsData, $ventureCode)
    {
        $configCollection = $this->getMapping('ConfigCollection')
            ->assign($productsData);

        return $this->getCatalogService()->updateProducts($configCollection, $ventureCode);
    }

    /**
     * {@inheritdoc}
     */
    public function updateProductImagesFromVenture(array $productsData, $ventureCode)
    {
        $configCollection = $this->getMapping('ConfigCollection')
            ->assign($productsData);

        return $this->getCatalogService()->updateImages($configCollection, $ventureCode);
    }

    /**
     * {@inheritdoc}
     */
    public function isInvalidOrder(\Iris\Transfer\Sales\Order $order)
    {
        return $this->getOrderService()->isInvalidOrder($order);
    }
}


1		<?php
2
3		namespace Iris\SaleWrapper;
4
5		class Partner extends Base implements PartnerInterface
6		{
7		private $mappingClasses;
8
9		/**
10		* {@inheritdoc}
11		*/
12		public function getName()
13		{
14	4	return 'partner';
15		}
16	4
17		/**
18		* Gets Venture service.
19		* @return \Iris\Interfaces\IrisVenture
20		*/
21		public function getVentureService()
22		{
23	3	return $this->getManager()->getService(\Iris\Factory::VENTURE);
24		}
25	3
26		/**
27		* Gets Stock service.
28		* @return \Iris\Interfaces\Stock
29		*/
30		public function getStockService()
31		{
32	2	return $this->getManager()->getService(\Iris\Factory::STOCK);
33		}
34	2
35		/**
36		* Gets Stock service.
37		* @return \Iris\Interfaces\Catalog
38		*/
39		public function getCatalogService()
40	2	{
41		return $this->getManager()->getService(\Iris\Factory::CATALOG);
42	2	}
43	2
44	2
45		//order
46		/**
47		* {@inheritdoc}
48		*/
49	1	public function isVentureItem(\Iris\Transfer\Sales\Order\Item $item)
50		{
51	1	$irisVenture = $this->getVentureService()
52		->getIrisVentureBySalesOrderId($item->getFkSalesOrder());
53	1
54	1	return ($irisVenture instanceof \Iris\Transfer\Venture);
55	1	}
56	1
57		/**
58	1	* {@inheritdoc}
59		*/
60	1	public function sendOrderToVenture(
61	1	array $orderData,
62		string $ventureCode
63		) {
64		return $this->getPartnerApiClient()
65		->createOrderOnVenture($ventureCode, $orderData);
66	1	}
67
68	1	/**
69	1	* {@inheritdoc}
70		*/
71		public function dropReserveAndUpdateStock(
72		\Iris\Transfer\Sales\Order\Item $orderItem,
73		array $productsData,
74		$ventureCode
75	1	) {
76		$this->getStockService()->dropReserve($orderItem);
77	1	$this->updateStockFromVenture($productsData, $ventureCode);
78	1	}
79
80		/**
81		* {@inheritdoc}
82		*/
83		public function confirmOrderPaidOnVenture(
84	4	\Iris\Transfer\Sales\Order $order,
85		\Iris\Transfer\Venture $venture
86	4	) {
87		return $this->getPartnerApiClient()
88		->confirmPaymentOnVenture(
89		$venture->getVentureCode(),
90		$order->getOrderNr()
91		);
92	1	}
93
94	1	/**
95		* {@inheritdoc}
96	1	*/
97	1	public function confirmOrderFromVenture(array $orderData, $ventureCode)
98		{
99		$order = $this->getMapping('Order')->assign($orderData);
100		$this->getOrderService()->confirmOrderFromVenture($order);
101		}
102
103	1	/**
104		* {@inheritdoc}
105	1	*/
106	1	public function cancelOrderOnVenture(
107		\Iris\Transfer\Sales\Order $order,
108		\Iris\Transfer\Venture $venture
109		) {
110		return $this->getPartnerApiClient()
111		->cancelOrderOnVenture(
112	1	$venture->getVentureCode(),
113		$order->getOrderNr()
114	1	);
115	1	}
116
117		/**
118		* {@inheritdoc}
119		*/
120		public function cancelOrderFromVenture($orderNr, $ventureCode)
121	1	{
122
123	1	$order = $this->getOrderService()
124	1	->getOrderByOrderNumberAndVentureCode($orderNr, $ventureCode);
125	1
126	1	$this->getOrderService()->cancelOrderFromVenture($order);
127	1	return ['order_number' => $order->getOrderNr()];
128	1	}
129	1
130		/**
131		* {@inheritdoc}
132		*/
133		public function bindVentureOrder($orderNr, $ventureCode, $ventureorderNr)
134		{
135	2	$this->getOrderService()
136		->bindPartnerOrderWithVentureOrder(
137	2	$orderNr,
138		$ventureCode,
139		$ventureOrderNr
		0 ignored issues – show Bug introduced 2016-01-05 19:58 UTC by Report Bug Copy Issue Report The variable `$ventureOrderNr` does not exist. Did you mean `$orderNr`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
140		);
141		}
142
143		/**
144		* Gets an specific mapping classs
145		*
146		* @param string $mappingName
147		*/
148		public function getMapping($mappingName)
149		{
150		if (!$this->mappingClasses[$mappingName]) {
151		$mappingClass = '\Iris\Mapping\\' . $mappingName;
152		$this->mappingClasses[$mappingName] = $mappingClass::getInstance();
153		}
154
155		return $this->mappingClasses[$mappingName];
156		}
157
158		/**
159		* Set an specific mapping classs
160		*
161		* @param string $mappingName
162		* @param $mappingClass
163		* @return \Iris\SaleWrapper\Partner
164		*/
165		public function setMapping($mappingName, $mappingClass)
166		{
167		$this->mappingClasses[$mappingName] = $mappingClass;
168		return $this;
169		}
170
171		//post payment
172		/**
173		* {@inheritdoc}
174		*/
175		public function setOrderStatusToShippedFromVenture(array $postPaymentData)
176		{
177		$postPaymentCollection = $this->getMapping('PostPaymentCollection')
178		->assign($postPaymentData);
179
180		foreach ($postPaymentCollection as $postPayment) {
181		if (!$postPayment->getTrackingCode()) {
182		$postPayment->setTrackingCode(md5($postPayment->getTrackingUrl()));
183		}
184		}
185
186		return $this->getOrderService()->shippedByVenture($postPayment);
		0 ignored issues – show Bug introduced 2016-01-07 16:41 UTC by Report Bug Copy Issue Report The variable `$postPayment` seems to be defined by a `foreach` iteration on line `180`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
187		}
188
189		/**
190		* {@inheritdoc}
191		*/
192		public function setOrderStatusToDeliveredFromVenture(
193		array $postPaymentData,
194		$ventureCode
195		) {
196		$postPayment = $this->getMapping('PostPayment')->assign($postPaymentData);
197		return $this->getOrderService()->deliveredByVenture($postPayment);
		0 ignored issues – show Bug introduced 2016-01-07 16:41 UTC by Report Bug Copy Issue Report The call to `deliveredByVenture()` misses a required argument `$venture`. This check looks for function calls that miss required arguments. Loading history...
198		}
199
200		/**
201		* {@inheritdoc}
202		*/
203		public function setOrderStatusToDeliveryFailedFromVenture(
204		array $orderData,
205		$ventureCode
206		) {
207		$postPayment = $this->getMapping('PostPayment')->assign($postPaymentData);
		0 ignored issues – show Bug introduced 2016-01-07 16:41 UTC by Report Bug Copy Issue Report The variable `$postPaymentData` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
208		return $this->getOrderService()
209		->deliveryFailedByVenture($postPayment, $ventureCode);
		0 ignored issues – show Documentation introduced 2016-01-07 16:41 UTC by Report Bug Copy Issue Report `$ventureCode` is of type `string`, but the function expects a `object<Iris\Transfer\Venture>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
210		}
211
212		//products
213		/**
214		* {@inheritdoc}
215		*/
216		public function updatePriceFromVenture(array $productsData, $ventureCode)
217		{
218		$configCollection = $this->getMapping('ConfigCollection')->assign($productsData);
219		return $this->getCatalogService()->updatePrice($configCollection);
220		}
221
222		/**
223		* {@inheritdoc}
224		*/
225		public function updateStockFromVenture(array $productsData, $ventureCode)
226		{
227		$configCollection = $this->getMapping('SimpleCollection')
228		->assign($productsData);
229
230		return $this->getStockService()->updateAbsoluteStock($configCollection);
231		}
232
233		/**
234		* {@inheritdoc}
235		*/
236		public function createProductsFromVenture(array $productsData, $ventureCode)
237		{
238		$configCollection = $this->getMapping('ConfigCollection')
239		->assign($productsData);
240
241		return $this->getCatalogService()->createProducts($configCollection, $ventureCode);
242		}
243
244		/**
245		* {@inheritdoc}
246		*/
247		public function sendProductCreationConfirmationToVenture(
248		\Iris\Transfer\Catalog\ConfigCollection $configCollection,
249		\Iris\Transfer\Venture $venture
250		) {
251		$productsData = $this->getMapping('ConfigCollection')
252		->map($configCollection);
253
254		$this->getPartnerApiClient()
255		->sendProductCreationConfirmationToVenture(
256		$productsData,
257		$venture->getVentureCode()
258		);
259		}
260
261		/**
262		* {@inheritdoc}
263		*/
264		public function updateProductsFromVenture(array $productsData, $ventureCode)
265		{
266		$configCollection = $this->getMapping('ConfigCollection')
267		->assign($productsData);
268
269		return $this->getCatalogService()->updateProducts($configCollection, $ventureCode);
270		}
271
272		/**
273		* {@inheritdoc}
274		*/
275		public function updateProductImagesFromVenture(array $productsData, $ventureCode)
276		{
277		$configCollection = $this->getMapping('ConfigCollection')
278		->assign($productsData);
279
280		return $this->getCatalogService()->updateImages($configCollection, $ventureCode);
281		}
282
283		/**
284		* {@inheritdoc}
285		*/
286		public function isInvalidOrder(\Iris\Transfer\Sales\Order $order)
287		{
288		return $this->getOrderService()->isInvalidOrder($order);
289		}
290		}
291

tricae-br / iris

Pull Request — master (#7)

Partner A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

24 Methods

Duplication Side-by-Side

Filter issues like