Make::handle() - Code Metrics - Inspection of "Changed namespace path to leopard." - triadev/Leopard - Measure and Improve Code Quality continuously with Scrutinizer

Cancelled

Branch — master (8cb5b2)

by Christopher

created 2018-12-17 13:07 UTC

Make::handle() A

↳ Parent: Make

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	11
nc	2
nop	0
dl	0
loc	18
ccs	12
cts	12
cp	1
crap	2
rs	9.9
c	0
b	0
f	0

<?php

Coding Style introduced 2018-12-17 12:25 UTC by

This file is missing a doc comment.

Coding Style introduced 2018-12-17 12:25 UTC by

The PHP open tag does not have a corresponding PHP close tag

namespace Triadev\Leopard\Console\Commands\Mapping;

Coding Style introduced 2018-12-17 12:25 UTC by

Missing file doc comment

use Illuminate\Console\ConfirmableTrait;

use Illuminate\Filesystem\Filesystem;

use Illuminate\Support\Composer;

use Illuminate\Support\Str;

class Make extends BaseCommand

Coding Style Documentation introduced 2018-12-17 12:25 UTC by

Missing class doc comment

Coding Style introduced 2018-12-17 12:25 UTC by

Opening brace should be on the same line as the declaration for class Make

    use ConfirmableTrait;

/**

     * The console command name.

     * @var string

*/

    protected $signature = 'triadev:mapping:make {mapping} {--model=}';

Coding Style introduced 2018-12-17 12:25 UTC by

Protected member variable "signature" must contain a leading underscore

/**

     * The console command description.

     * @var string

*/

    protected $description = 'Make a new mapping';

Coding Style introduced 2018-12-17 12:25 UTC by

Protected member variable "description" must contain a leading underscore

    /** @var Filesystem */

Coding Style introduced 2018-12-17 12:25 UTC by

The open comment tag must be the only content on the line

Coding Style introduced 2018-12-17 12:25 UTC by

Missing short description in doc comment

Coding Style introduced 2018-12-17 12:25 UTC by

The close comment tag must be the only content on the line

    private $filesystem;

Coding Style introduced 2018-12-17 12:25 UTC by

Private member variable "filesystem" must contain a leading underscore

Coding Style introduced 2018-12-17 12:25 UTC by

Private member variable "filesystem" must be prefixed with an underscore

    /** @var Composer */

Coding Style introduced 2018-12-17 12:25 UTC by

The open comment tag must be the only content on the line

Coding Style introduced 2018-12-17 12:25 UTC by

Missing short description in doc comment

Coding Style introduced 2018-12-17 12:25 UTC by

The close comment tag must be the only content on the line

    private $composer;

Coding Style introduced 2018-12-17 12:25 UTC by

Private member variable "composer" must contain a leading underscore

Coding Style introduced 2018-12-17 12:25 UTC by

Private member variable "composer" must be prefixed with an underscore

/**

     * Make constructor.

     * @param Filesystem $filesystem

Coding Style introduced 2018-12-17 12:25 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style introduced 2018-12-17 12:25 UTC by

Missing parameter comment

     * @param Composer $composer

Coding Style introduced 2018-12-17 12:25 UTC by

Missing parameter comment

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 3 spaces after parameter type; 1 found

*/

132

    public function __construct(Filesystem $filesystem, Composer $composer)

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines before function; 1 found

132

        parent::__construct();

132

        $this->filesystem = $filesystem;

132

        $this->composer = $composer;

Coding Style introduced 2018-12-17 12:25 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

132

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end __construct()

/**

     * Execute the console command.

*/

Coding Style introduced 2018-12-17 12:25 UTC by

Missing @return tag in function comment

    public function handle()

        $mapping = $this->formatMappingName($this->argument('mapping'));

Bug introduced 2018-12-17 12:41 UTC by

It seems like $this->argument('mapping') can also be of type null and string[]; however, parameter $mapping of Triadev\Leopard\Console\...ke::formatMappingName() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

        $model = $this->option('model') ?

Coding Style introduced 2018-12-17 12:25 UTC by

The value of a comparison must not be assigned to a variable

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 space after "?"; newline found

Coding Style introduced 2018-12-17 12:25 UTC by

Inline IF statements are not allowed

Coding Style introduced 2018-12-17 12:25 UTC by

Inline shorthand IF statement must be declared on a single line

            $this->formatModelName($this->option('model')) :

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 space after ":"; newline found

            null;

        $this->filesystem->put(

            $this->buildMappingFilePath($mapping),

            $this->buildMapping(

                $this->getDefaultStub(),

                $mapping,

                $model

);

        $this->composer->dumpAutoloads();

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end handle()

    private function formatMappingName(string $mapping) : string

Coding Style introduced 2018-12-17 12:25 UTC by

Private method name "Make::formatMappingName" must be prefixed with an underscore

Coding Style introduced 2018-12-17 12:25 UTC by

Missing function doc comment

        return trim(Str::studly($mapping));

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end formatMappingName()

    private function formatModelName(string $model) : string

Coding Style introduced 2018-12-17 12:25 UTC by

Private method name "Make::formatModelName" must be prefixed with an underscore

Coding Style introduced 2018-12-17 12:25 UTC by

Missing function doc comment

        return trim($model);

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end formatModelName()

    private function getDefaultStub() : string

Coding Style introduced 2018-12-17 12:25 UTC by

Private method name "Make::getDefaultStub" must be prefixed with an underscore

Coding Style introduced 2018-12-17 12:25 UTC by

Missing function doc comment

        return $this->filesystem->get(__DIR__ . DIRECTORY_SEPARATOR . 'default.stub');

Coding Style introduced 2018-12-17 12:25 UTC by

Concat operator must not be surrounded by spaces

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end getDefaultStub()

    private function buildMappingFilePath(string $mapping) : string

Coding Style introduced 2018-12-17 12:25 UTC by

Private method name "Make::buildMappingFilePath" must be prefixed with an underscore

Coding Style introduced 2018-12-17 12:25 UTC by

Missing function doc comment

        return $this->getMappingPath() . DIRECTORY_SEPARATOR . $mapping . '.php';

Coding Style introduced 2018-12-17 12:25 UTC by

Concat operator must not be surrounded by spaces

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end buildMappingFilePath()

    private function buildMapping(string $stub, string $mapping, ?string $model) : string

Coding Style introduced 2018-12-17 12:25 UTC by

Private method name "Make::buildMapping" must be prefixed with an underscore

Coding Style introduced 2018-12-17 12:25 UTC by

Missing function doc comment

        $stub = str_replace('DefaultClass', $mapping, $stub);

        if ($model) {

            $stub = str_replace('DefaultModel', $model, $stub);

        return $stub;

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end buildMapping()

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end class

Coding Style introduced 2018-12-17 12:25 UTC by

As per coding style, files should not end with a newline character.

100

triadev / Leopard

Branch — master (8cb5b2)

Make::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like