Triadev\Leopard\Business\Dsl\Aggregation

Complexity

Total Complexity

7

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	append()	0	9	3
A	pipeline()	0	7	1
A	__construct()	0	3	1
A	metric()	0	7	1
A	bucketing()	0	7	1

<?php

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

namespace Triadev\Leopard\Business\Dsl;

Missing file doc comment

use ONGR\ElasticsearchDSL\Aggregation\AbstractAggregation;
use Triadev\Leopard\Business\Dsl\Aggregation\Bucketing;
use Triadev\Leopard\Business\Dsl\Aggregation\Metric;
use Triadev\Leopard\Business\Dsl\Aggregation\Pipeline;

class Aggregation

Missing class doc comment

{

Opening brace should be on the same line as the declaration for class Aggregation

    /** @var \ONGR\ElasticsearchDSL\Search */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

    private $search;

Private member variable "search" must contain a leading underscore

Expected 1 blank line before member var; 0 found

Private member variable "search" must be prefixed with an underscore

    
    /**
     * Aggregation constructor.
     * @param \ONGR\ElasticsearchDSL\Search $search

There must be exactly one blank line before the tags in a doc comment

Missing parameter comment

     */
    public function __construct(\ONGR\ElasticsearchDSL\Search $search)

Expected 2 blank lines before function; 1 found

    {
        $this->search = $search;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end __construct()

    
    /**
     * Bucketing
     *
     * @param \Closure $bucketing

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return Aggregation

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function bucketing(\Closure $bucketing) : Aggregation
    {
        $bucketingBuilder = new Bucketing();
        $bucketing($bucketingBuilder);
        
        $this->append($bucketingBuilder->getAggregations());
        return $this;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end bucketing()

    
    /**
     * Metric
     *
     * @param \Closure $metric

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return Aggregation

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function metric(\Closure $metric) : Aggregation
    {
        $metricBuilder = new Metric();
        $metric($metricBuilder);
        
        $this->append($metricBuilder->getAggregations());
        return $this;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end metric()

    
    /**
     * Pipeline
     *
     * @param \Closure $pipeline

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return Aggregation

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function pipeline(\Closure $pipeline) : Aggregation
    {
        $pipelineBuilder = new Pipeline();
        $pipeline($pipelineBuilder);
        
        $this->append($pipelineBuilder->getAggregations());
        return $this;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end pipeline()

    
    /**

Missing short description in doc comment

     * @param AbstractAggregation[] $aggs

Missing parameter comment

     * @return Aggregation
     */
    private function append(array $aggs) : Aggregation

Private method name "Aggregation::append" must be prefixed with an underscore

    {
        foreach ($aggs as $agg) {
            if ($agg instanceof AbstractAggregation) {
                $this->search->addAggregation($agg);
            }
        }
        
        return $this;
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end append()

}

Expected //end class

As per coding style, files should not end with a newline character.