ElasticsearchRepository::save() - Code Metrics - Inspection of "Changed namespace path to leopard." - triadev/Leopard - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (8cb5b2)

by Christopher

created 2018-12-17 13:11 UTC

ElasticsearchRepository::save() A

↳ Parent: ElasticsearchRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	1
dl	0
loc	9
ccs	7
cts	7
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

Coding Style introduced 2018-12-17 12:25 UTC by

The PHP open tag does not have a corresponding PHP close tag

namespace Triadev\Leopard\Business\Repository;

Coding Style introduced 2018-12-17 12:41 UTC by

Missing file doc comment

use Illuminate\Database\Eloquent\Model;

use Illuminate\Support\Collection;

use Triadev\Leopard\Business\Helper\IsModelSearchable;

use Triadev\Leopard\Contract\Repository\ElasticsearchRepositoryContract;

use Triadev\Leopard\Facade\Leopard;

use Triadev\Leopard\Searchable;

class ElasticsearchRepository implements ElasticsearchRepositoryContract

Coding Style Documentation introduced 2018-12-17 12:25 UTC by

Missing class doc comment

Coding Style introduced 2018-12-17 12:25 UTC by

Opening brace should be on the same line as the declaration for class ElasticsearchRepository

    use IsModelSearchable;

/**

     * Save

     * @param Model|Searchable $model

Coding Style introduced 2018-12-17 12:25 UTC by

Missing parameter comment

Coding Style introduced 2018-12-17 12:25 UTC by

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return array

Coding Style introduced 2018-12-17 12:25 UTC by

Tag cannot be grouped with parameter tags in a doc comment

     * @throws \InvalidArgumentException

introduced 2018-12-17 12:25 UTC by

Comment missing for @throws tag in function comment

*/

    public function save(Model $model): array

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines before function; 1 found

        $this->isModelSearchable($model);

        return Leopard::indexStatement([

1 ignored issue

– show

            'index' => $model->getDocumentIndex(),

1 ignored issue

– show

            'type' => $model->getDocumentType(),

1 ignored issue

– show

            'id' => $model->getKey(),

1 ignored issue

– show

            'body' => $model->getDocumentData()

1 ignored issue

– show

]);

Coding Style introduced 2018-12-17 12:25 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

Coding Style introduced 2018-12-17 12:41 UTC by

The closing parenthesis does not seem to be aligned correctly; expected 39 space(s), but found 8.

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end save()

/**

     * Update

     * @param Model|Searchable $model

Coding Style introduced 2018-12-17 12:25 UTC by

Missing parameter comment

Coding Style introduced 2018-12-17 12:25 UTC by

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return array

Coding Style introduced 2018-12-17 12:25 UTC by

Tag cannot be grouped with parameter tags in a doc comment

     * @throws \InvalidArgumentException

introduced 2018-12-17 12:25 UTC by

Comment missing for @throws tag in function comment

*/

    public function update(Model $model): array

        $this->isModelSearchable($model);

        return Leopard::updateStatement([

1 ignored issue

– show

            'index' => $model->getDocumentIndex(),

1 ignored issue

– show

            'type' => $model->getDocumentType(),

1 ignored issue

– show

            'id' => $model->getKey(),

1 ignored issue

– show

            'body' => [

1 ignored issue

– show

                'doc' => $model->getDocumentData()

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 23 spaces, but found 16.

Coding Style introduced 2018-12-17 12:25 UTC by

The closing parenthesis does not seem to be aligned correctly; expected 22 space(s), but found 12.

]);

Coding Style introduced 2018-12-17 12:25 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

Coding Style introduced 2018-12-17 12:41 UTC by

The closing parenthesis does not seem to be aligned correctly; expected 40 space(s), but found 8.

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end update()

/**

     * Delete

     * @param Model|Searchable $model

Coding Style introduced 2018-12-17 12:25 UTC by

Missing parameter comment

Coding Style introduced 2018-12-17 12:25 UTC by

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return bool

Coding Style introduced 2018-12-17 12:25 UTC by

Tag cannot be grouped with parameter tags in a doc comment

Coding Style introduced 2018-12-17 12:25 UTC by

Expected "boolean" but found "bool" for function return type

     * @throws \InvalidArgumentException

introduced 2018-12-17 12:25 UTC by

Comment missing for @throws tag in function comment

*/

    public function delete(Model $model): bool

        $this->isModelSearchable($model);

        $params = [

            'index' => $model->getDocumentIndex(),

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 19 spaces, but found 12.

            'type' => $model->getDocumentType(),

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 19 spaces, but found 12.

            'id' => $model->getKey(),

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 19 spaces, but found 12.

];

Coding Style introduced 2018-12-17 12:25 UTC by

The closing parenthesis does not seem to be aligned correctly; expected 18 space(s), but found 8.

        if (Leopard::existStatement($params)) {

            Leopard::deleteStatement($params);

        return true;

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end delete()

/**

     * Bulk save

     * @param array|Collection $models

Coding Style introduced 2018-12-17 12:25 UTC by

Missing parameter comment

Coding Style introduced 2018-12-17 12:25 UTC by

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return array

Coding Style introduced 2018-12-17 12:25 UTC by

Tag cannot be grouped with parameter tags in a doc comment

*/

    public function bulkSave($models) : array

        $params = [];

        $defaultIndex = Leopard::getEsDefaultIndex();

        foreach ($models as $model) {

            /** @var Model|Searchable $model */

Coding Style introduced 2018-12-17 12:25 UTC by

Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead

Coding Style introduced 2018-12-17 12:25 UTC by

Block comments must be started with /*

Coding Style introduced 2018-12-17 12:25 UTC by

The open comment tag must be the only content on the line

Coding Style introduced 2018-12-17 12:25 UTC by

Missing short description in doc comment

Coding Style introduced 2018-12-17 12:25 UTC by

The close comment tag must be the only content on the line

            $this->isModelSearchable($model);

1 ignored issue

– show

Bug introduced 2018-12-17 12:41 UTC by

It seems like $model can also be of type Triadev\Leopard\Searchable; however, parameter $model of Triadev\Leopard\Business...ry::isModelSearchable() does only seem to accept Illuminate\Database\Eloquent\Model, maybe add an additional type check? ( Ignorable by Annotation )

            $params['body'][] = [

Coding Style introduced 2018-12-17 12:25 UTC by

The value of a comparison must not be assigned to a variable

                'index' => [

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 33 spaces, but found 16.

100

                    '_index' => $model->getDocumentIndex() ?: $defaultIndex,

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 28 spaces, but found 20.

Coding Style introduced 2018-12-17 12:25 UTC by

Inline IF statements are not allowed

101

                    '_type' => $model->getDocumentType(),

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 28 spaces, but found 20.

102

                    '_id' => $model->getKey()

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 28 spaces, but found 20.

103

Coding Style introduced 2018-12-17 12:25 UTC by

The closing parenthesis does not seem to be aligned correctly; expected 27 space(s), but found 16.

104

];

Coding Style introduced 2018-12-17 12:25 UTC by

The closing parenthesis does not seem to be aligned correctly; expected 32 space(s), but found 12.

105

106

            $params['body'][] = $model->getDocumentData();

107

108

109

        return Leopard::bulkStatement($params);

110

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end bulkSave()

111

112

/**

113

     * Bulk delete

114

115

     * @param array $models

Coding Style introduced 2018-12-17 12:25 UTC by

Missing parameter comment

Coding Style introduced 2018-12-17 12:25 UTC by

Tag value indented incorrectly; expected 2 spaces but found 1

116

     * @return array

Coding Style introduced 2018-12-17 12:25 UTC by

Tag cannot be grouped with parameter tags in a doc comment

117

*/

118

    public function bulkDelete(array $models): array

119

120

        $params = [];

121

122

        $defaultIndex = Leopard::getEsDefaultIndex();

123

124

        foreach ($models as $model) {

125

            /** @var Model|Searchable $model */

Coding Style introduced 2018-12-17 12:25 UTC by

Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead

Coding Style introduced 2018-12-17 12:25 UTC by

Block comments must be started with /*

Coding Style introduced 2018-12-17 12:25 UTC by

The open comment tag must be the only content on the line

Coding Style introduced 2018-12-17 12:25 UTC by

Missing short description in doc comment

Coding Style introduced 2018-12-17 12:25 UTC by

The close comment tag must be the only content on the line

126

            $this->isModelSearchable($model);

1 ignored issue

– show

Bug introduced 2018-12-17 12:41 UTC by

127

128

            $params['body'][] = [

Coding Style introduced 2018-12-17 12:25 UTC by

The value of a comparison must not be assigned to a variable

129

                'delete' => [

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 33 spaces, but found 16.

130

                    '_index' => $model->getDocumentIndex() ?: $defaultIndex,

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 29 spaces, but found 20.

Coding Style introduced 2018-12-17 12:25 UTC by

Inline IF statements are not allowed

131

                    '_type' => $model->getDocumentType(),

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 29 spaces, but found 20.

132

                    '_id' => $model->getKey()

Coding Style introduced 2018-12-17 12:25 UTC by

This array key does not seem to be aligned correctly; expected 29 spaces, but found 20.

133

Coding Style introduced 2018-12-17 12:25 UTC by

The closing parenthesis does not seem to be aligned correctly; expected 28 space(s), but found 16.

134

];

Coding Style introduced 2018-12-17 12:25 UTC by

The closing parenthesis does not seem to be aligned correctly; expected 32 space(s), but found 12.

135

136

137

        return Leopard::bulkStatement($params);

138

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 2 blank lines after function; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end bulkDelete()

139

Coding Style introduced 2018-12-17 12:25 UTC by

Expected //end class

Coding Style introduced 2018-12-17 12:25 UTC by

As per coding style, files should not end with a newline character.

140

triadev / Leopard

Branch — master (8cb5b2)

ElasticsearchRepository::save() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like