Triadev\Leopard\Business\Repository\ElasticsearchRepository::bulkSave()

Complexity

Conditions	3
Paths	2

Size

Total Lines	22
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3

Importance

Changes

0

<?php
    public function bulkSave($models) : array
    {
        $params = [];
    
        $defaultIndex = Leopard::getEsDefaultIndex();
        
        foreach ($models as $model) {
            /** @var Model|Searchable $model */

Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead

Block comments must be started with /*

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

            $this->isModelSearchable($model);

It seems like $model can also be of type Triadev\Leopard\Searchable; however, parameter $model of Triadev\Leopard\Business\Repository\ElasticsearchRepository::isModelSearchable() does only seem to accept Illuminate\Database\Eloquent\Model, maybe add an additional type check?

            
            $params['body'][] = [

The value of a comparison must not be assigned to a variable

                'index' => [

This array key does not seem to be aligned correctly; expected 33 spaces, but found 16.

                    '_index' => $model->getDocumentIndex() ?: $defaultIndex,

This array key does not seem to be aligned correctly; expected 28 spaces, but found 20.

Inline IF statements are not allowed

                    '_type' => $model->getDocumentType(),

This array key does not seem to be aligned correctly; expected 28 spaces, but found 20.

                    '_id' => $model->getKey()

This array key does not seem to be aligned correctly; expected 28 spaces, but found 20.

                ]

The closing parenthesis does not seem to be aligned correctly; expected 27 space(s), but found 16.

            ];

The closing parenthesis does not seem to be aligned correctly; expected 32 space(s), but found 12.

            
            $params['body'][] = $model->getDocumentData();
        }
        
        return Leopard::bulkStatement($params);
    }