Triadev\Leopard\Business\Dsl\Query\Geo

Complexity

Total Complexity

8

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	geoShape()	0	3	1
A	geoPolygon()	0	14	3
A	geoDistance()	0	8	1
A	geoBoundingBox()	0	14	3

<?php

The PHP open tag does not have a corresponding PHP close tag

namespace Triadev\Leopard\Business\Dsl\Query;

Missing file doc comment

use ONGR\ElasticsearchDSL\Query\Geo\GeoBoundingBoxQuery;
use ONGR\ElasticsearchDSL\Query\Geo\GeoDistanceQuery;
use ONGR\ElasticsearchDSL\Query\Geo\GeoPolygonQuery;
use ONGR\ElasticsearchDSL\Query\Geo\GeoShapeQuery;
use Triadev\Leopard\Model\Location;
use Triadev\Leopard\Business\Dsl\AbstractQuery;

class Geo extends AbstractQuery

Missing class doc comment

{

Opening brace should be on the same line as the declaration for class Geo

    /**
     * Geo bounding box
     *
     * @param string $field

Missing parameter comment

Expected 5 spaces after parameter type; 1 found

Tag value indented incorrectly; expected 2 spaces but found 1

     * @param Location[] $locations

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @param array $params

Missing parameter comment

Expected 6 spaces after parameter type; 1 found

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return Geo

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function geoBoundingBox(string $field, array $locations, array $params = []): Geo

Expected 2 blank lines before function; 0 found

Incorrect spacing between argument "$params" and equals sign; expected 0 but found 1

Incorrect spacing between default value and equals sign for argument "$params"; expected 0 but found 1

    {
        $l = [];
        
        foreach ($locations as $location) {
            if ($location instanceof Location) {
                $l[] = [
                    'lat' => $location->getLatitude(),

This array key does not seem to be aligned correctly; expected 24 spaces, but found 20.

                    'lon' => $location->getLongitude()

This array key does not seem to be aligned correctly; expected 24 spaces, but found 20.

                ];

The closing parenthesis does not seem to be aligned correctly; expected 23 space(s), but found 16.

            }
        }
        
        return $this->append(new GeoBoundingBoxQuery($field, $l, $params));
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end geoBoundingBox()

    
    /**
     * Geo distance
     *
     * @param string $field

Missing parameter comment

Expected 3 spaces after parameter type; 1 found

Tag value indented incorrectly; expected 2 spaces but found 1

     * @param string $distance

Missing parameter comment

Expected 3 spaces after parameter type; 1 found

Tag value indented incorrectly; expected 2 spaces but found 1

     * @param Location $location

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return Geo

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function geoDistance(string $field, string $distance, Location $location): Geo
    {
        return $this->append(new GeoDistanceQuery(

The opening parenthesis of a multi-line function call should be the last content on the line.

            $field,
            $distance,
            [
                'lat' => $location->getLatitude(),

This array key does not seem to be aligned correctly; expected 13 spaces, but found 16.

                'lon' => $location->getLongitude()

This array key does not seem to be aligned correctly; expected 13 spaces, but found 16.

            ]
        ));

For multi-line function calls, the closing parenthesis should be on a new line.

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end geoDistance()

    
    /**
     * Geo polygon
     *
     * @param string $field

Missing parameter comment

Expected 5 spaces after parameter type; 1 found

Tag value indented incorrectly; expected 2 spaces but found 1

     * @param Location[] $points

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return Geo

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function geoPolygon(string $field, array $points): Geo
    {
        $p = [];
        
        foreach ($points as $point) {
            if ($point instanceof Location) {
                $p[] = [
                    'lat' => $point->getLatitude(),

This array key does not seem to be aligned correctly; expected 24 spaces, but found 20.

                    'lon' => $point->getLongitude()

This array key does not seem to be aligned correctly; expected 24 spaces, but found 20.

                ];

The closing parenthesis does not seem to be aligned correctly; expected 23 space(s), but found 16.

            }
        }
        
        return $this->append(new GeoPolygonQuery($field, $p));
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end geoPolygon()

    
    /**
     * Geo shape
     *
     * @param array $params

Missing parameter comment

Tag value indented incorrectly; expected 2 spaces but found 1

     * @return Geo

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function geoShape(array $params = []): Geo

Incorrect spacing between argument "$params" and equals sign; expected 0 but found 1

Incorrect spacing between default value and equals sign for argument "$params"; expected 0 but found 1

    {
        return $this->append(new GeoShapeQuery($params));
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end geoShape()

}

Expected //end class

As per coding style, files should not end with a newline character.