RequestPerRoute::requestLatencyMetric() - Code Metrics - triadev/LaravelPrometheusExporter - Measure and Improve Code Quality continuously with Scrutinizer

RequestPerRoute::requestLatencyMetric() A
last analyzed 2019-12-15 11:16 UTC

↳ Parent: RequestPerRoute

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	15
c	1
b	0
f	0
nc	2
nop	4
dl	0
loc	24
rs	9.7666
ccs	0
cts	13
cp	0
crap	6

<?php

Coding Style introduced 2018-10-26 21:05 UTC by

Filename "RequestPerRoute.php" doesn't match the expected filename "requestperroute.php"

namespace Triadev\PrometheusExporter\Middleware;

use Illuminate\Http\Request;

use Closure;

use Illuminate\Http\Response;

use Prometheus\Exception\MetricsRegistrationException;

use Triadev\PrometheusExporter\Contract\PrometheusExporterContract;

class RequestPerRoute

    /** @var PrometheusExporterContract */

Coding Style introduced 2018-10-26 21:05 UTC by

The open comment tag must be the only content on the line

Coding Style introduced 2018-10-26 21:05 UTC by

Missing short description in doc comment

Coding Style introduced 2018-10-26 21:05 UTC by

The close comment tag must be the only content on the line

    private $prometheusExporter;

Coding Style introduced 2018-10-26 21:05 UTC by

Private member variable "prometheusExporter" must contain a leading underscore

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 1 blank line before member var; 0 found

Coding Style introduced 2018-10-26 21:05 UTC by

Private member variable "prometheusExporter" must be prefixed with an underscore

/**

     * RequestPerRoute constructor.

     * @param PrometheusExporterContract $prometheusExporter

Coding Style introduced 2018-10-26 21:05 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style introduced 2018-10-26 21:05 UTC by

Missing parameter comment

*/

    public function __construct(PrometheusExporterContract $prometheusExporter)

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 2 blank lines before function; 1 found

Coding Style introduced 2018-10-26 21:05 UTC by

Opening brace should be on the same line as the declaration

        $this->prometheusExporter = $prometheusExporter;

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-10-26 21:05 UTC by

Expected //end __construct()

/**

     * Handle an incoming request.

     * @param  Request $request

Coding Style introduced 2019-06-29 19:41 UTC by

Missing parameter comment

Coding Style introduced 2019-06-29 19:41 UTC by

Expected 2 spaces after parameter type; 1 found

     * @param  \Closure $next

Coding Style introduced 2019-06-29 19:41 UTC by

Missing parameter comment

     * @return mixed

Coding Style introduced 2018-10-26 21:05 UTC by

Tag cannot be grouped with parameter tags in a doc comment

     * @throws MetricsRegistrationException

*/

    public function handle(Request $request, Closure $next)

Coding Style introduced 2018-10-26 21:05 UTC by

Opening brace should be on the same line as the declaration

        $start = microtime(true);

        /** @var Response $response */

Coding Style introduced 2019-06-29 19:41 UTC by

The open comment tag must be the only content on the line

Coding Style introduced 2019-06-29 19:41 UTC by

Missing short description in doc comment

Coding Style introduced 2019-06-29 19:41 UTC by

The close comment tag must be the only content on the line

        $response = $next($request);

        $durationMilliseconds = (microtime(true) - $start) * 1000.0;

Coding Style introduced 2018-10-26 21:05 UTC by

Arithmetic operation must be bracketed

        $path = $request->path();

Coding Style introduced 2019-06-29 19:41 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $method = $request->getMethod();

        $status = $response->getStatusCode();

        $this->requestCountMetric($path, $method, $status);

        $this->requestLatencyMetric($path, $method, $status, $durationMilliseconds);

        return $response;

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-10-26 21:05 UTC by

Expected //end handle()

/**

Coding Style introduced 2018-10-26 21:05 UTC by

Missing short description in doc comment

     * @param string $routeName

Coding Style introduced 2018-10-26 21:05 UTC by

Missing parameter comment

     * @param string $method

Coding Style introduced 2018-10-26 21:05 UTC by

Missing parameter comment

     * @param int $status

Coding Style introduced 2019-06-29 19:41 UTC by

Missing parameter comment

Coding Style introduced 2019-06-29 19:41 UTC by

Expected 4 spaces after parameter type; 1 found

     * @throws MetricsRegistrationException

*/

Coding Style introduced 2018-10-26 21:05 UTC by

Missing @return tag in function comment

    private function requestCountMetric(string $routeName, string $method, int $status)

Coding Style introduced 2018-10-26 21:05 UTC by

Private method name "RequestPerRoute::requestCountMetric" must be prefixed with an underscore

Coding Style introduced 2018-10-26 21:05 UTC by

Opening brace should be on the same line as the declaration

        $this->prometheusExporter->incCounter(

            'requests_total',

            'the number of http requests',

            config('prometheus_exporter.namespace_http'),

Coding Style introduced 2018-10-26 21:05 UTC by

Short array syntax is not allowed

                'route',

Coding Style introduced 2018-10-26 21:05 UTC by

This array value does not seem to be aligned correcty; expected 13 spaces, but found 16.

                'method',

Coding Style introduced 2018-10-26 21:05 UTC by

This array value does not seem to be aligned correcty; expected 13 spaces, but found 16.

                'status_code'

Coding Style introduced 2018-10-26 21:05 UTC by

There should be a trailing comma after the last value of an array declaration.

],

Coding Style introduced 2018-10-26 21:05 UTC by

Short array syntax is not allowed

                $routeName,

Coding Style introduced 2018-10-26 21:05 UTC by

This array value does not seem to be aligned correcty; expected 13 spaces, but found 16.

                $method,

Coding Style introduced 2018-10-26 21:05 UTC by

This array value does not seem to be aligned correcty; expected 13 spaces, but found 16.

                $status

Coding Style introduced 2018-10-26 21:05 UTC by

There should be a trailing comma after the last value of an array declaration.

);

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-10-26 21:05 UTC by

Expected //end requestCountMetric()

/**

Coding Style introduced 2018-10-26 21:05 UTC by

Missing short description in doc comment

     * @param string $routeName

Coding Style introduced 2018-10-26 21:05 UTC by

Missing parameter comment

     * @param string $method

Coding Style introduced 2018-10-26 21:05 UTC by

Missing parameter comment

     * @param int $status

Coding Style introduced 2018-10-26 21:05 UTC by

Missing parameter comment

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 4 spaces after parameter type; 1 found

     * @param int $duration

Coding Style introduced 2019-06-29 19:41 UTC by

Missing parameter comment

Coding Style introduced 2019-06-29 19:41 UTC by

Expected 4 spaces after parameter type; 1 found

     * @throws MetricsRegistrationException

*/

Coding Style introduced 2018-10-26 21:05 UTC by

Missing @return tag in function comment

    private function requestLatencyMetric(string $routeName, string $method, int $status, int $duration)

Coding Style introduced 2018-10-26 21:05 UTC by

Private method name "RequestPerRoute::requestLatencyMetric" must be prefixed with an underscore

Coding Style introduced 2018-10-26 21:05 UTC by

This line exceeds maximum limit of 100 characters; contains 104 characters

Coding Style introduced 2018-10-26 21:05 UTC by

Opening brace should be on the same line as the declaration

        $bucketsPerRoute = null;

        if ($bucketsPerRouteConfig = config('prometheus-exporter.buckets_per_route')) {

Coding Style introduced 2018-10-26 21:05 UTC by

Assignments must be the first block of code on a line

            $bucketsPerRoute = array_get($bucketsPerRouteConfig, $routeName);

Deprecated Code introduced 2019-12-15 11:16 UTC by

The function array_get() has been deprecated: Arr::get() should be used directly instead. Will be removed in Laravel 6.0. ( Ignorable by Annotation )

        $this->prometheusExporter->setHistogram(

            'requests_latency_milliseconds',

            'duration of requests',

            $duration,

            config('prometheus_exporter.namespace_http'),

Coding Style introduced 2018-10-26 21:05 UTC by

Short array syntax is not allowed

100

                'route',

Coding Style introduced 2018-10-26 21:05 UTC by

This array value does not seem to be aligned correcty; expected 13 spaces, but found 16.

101

                'method',

Coding Style introduced 2018-10-26 21:05 UTC by

This array value does not seem to be aligned correcty; expected 13 spaces, but found 16.

102

                'status_code'

Coding Style introduced 2018-10-26 21:05 UTC by

There should be a trailing comma after the last value of an array declaration.

103

],

104

Coding Style introduced 2018-10-26 21:05 UTC by

Short array syntax is not allowed

105

                $routeName,

Coding Style introduced 2018-10-26 21:05 UTC by

This array value does not seem to be aligned correcty; expected 13 spaces, but found 16.

106

                $method,

Coding Style introduced 2018-10-26 21:05 UTC by

This array value does not seem to be aligned correcty; expected 13 spaces, but found 16.

107

                $status

Coding Style introduced 2018-10-26 21:05 UTC by

There should be a trailing comma after the last value of an array declaration.

108

],

109

            $bucketsPerRoute

110

);

111

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 2 blank lines after function; 0 found

Coding Style introduced 2018-10-26 21:05 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2018-10-26 21:05 UTC by

Expected //end requestLatencyMetric()

112

Coding Style introduced 2018-10-26 21:05 UTC by

Expected //end class

Coding Style introduced 2018-10-26 21:05 UTC by

As per coding style, files should not end with a newline character.

113

triadev / LaravelPrometheusExporter

RequestPerRoute::requestLatencyMetric() A last analyzed 2019-12-15 11:16 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RequestPerRoute::requestLatencyMetric() A
last analyzed 2019-12-15 11:16 UTC