Triadev\PrometheusExporter\Controller\LumenController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	metrics()	0	7	1
A	__construct()	0	3	1

<?php

Filename "LumenController.php" doesn't match the expected filename "lumencontroller.php"

namespace Triadev\PrometheusExporter\Controller;

use Illuminate\Http\Response;
use Prometheus\RenderTextFormat;
use Triadev\PrometheusExporter\PrometheusExporter;
use Laravel\Lumen\Routing\Controller;

class LumenController extends Controller
{
    /**

Missing short description in doc comment

     * @var PrometheusExporter
     */
    protected $prometheusExporter;

Protected member variable "prometheusExporter" must contain a leading underscore

Expected 1 blank line before member var; 0 found

    /**
     * PrometheusExporterController constructor.
     *
     * @param PrometheusExporter $prometheusExporter

Missing parameter comment

     */
    public function __construct(PrometheusExporter $prometheusExporter)

Expected 2 blank lines before function; 1 found

    {

Opening brace should be on the same line as the declaration

        $this->prometheusExporter = $prometheusExporter;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end __construct()

    /**
     * metrics

Doc comment short description must start with a capital letter

     *
     * Expose metrics for prometheus
     *
     * @return Response
     */
    public function metrics() : Response
    {

Opening brace should be on the same line as the declaration

        $renderer = new RenderTextFormat();
        
        return \response()->make(
            $renderer->render($this->prometheusExporter->getMetricFamilySamples())
        )->header('Content-Type', RenderTextFormat::MIME_TYPE);
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end metrics()

}

Expected //end class

As per coding style, files should not end with a newline character.