triadev / LaravelElasticsearchProvider

src/Console/Commands/Migration/Reindex.php

<?php
namespace Triadev\Es\Console\Commands\Migration;

use Triadev\Es\Contract\ElasticsearchIndexContract;
use Illuminate\Console\Command;
use Log;

class Reindex extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'triadev:es:reindex
                            {index : Index}
                            {from_version : From version}
                            {to_version : To version}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Reindex the index.';

    /**
     * Execute the console command.
     *
     * @param ElasticsearchIndexContract $elasticsearchIndex
     */
    public function handle(ElasticsearchIndexContract $elasticsearchIndex)
    {
        $index = $this->argument('index');
        $from_version = $this->argument('from_version');
        $to_version = $this->argument('to_version');

        if (!$elasticsearchIndex->existIndex([$index], $from_version)) {

It seems like $from_version can also be of type string[]; however, parameter $version of Triadev\Es\Contract\ElasticsearchIndexContract::existIndex() does only seem to accept null|string, maybe add an additional type check?

            Log::error("The index (from) could not be found.", [
                'index' => $index,
                'from_version' => $from_version,
                'to_version' => $to_version
            ]);
        } elseif (!$elasticsearchIndex->existIndex([$index], $to_version)) {
            Log::error("The index (to) could not be found.", [
                'index' => $index,
                'from_version' => $from_version,
                'to_version' => $to_version
            ]);
        } else {
            try {
                $elasticsearchIndex->reindex($index, $from_version, $to_version);

It seems like $from_version can also be of type null and string[]; however, parameter $from_version of Triadev\Es\Contract\ElasticsearchIndexContract::reindex() does only seem to accept string, maybe add an additional type check?

It seems like $index can also be of type null and string[]; however, parameter $index of Triadev\Es\Contract\ElasticsearchIndexContract::reindex() does only seem to accept string, maybe add an additional type check?

It seems like $to_version can also be of type null and string[]; however, parameter $to_version of Triadev\Es\Contract\ElasticsearchIndexContract::reindex() does only seem to accept string, maybe add an additional type check?

            } catch (\Exception $e) {
                Log::error(sprintf(
                    "The indices could not be reindex: %s",
                    $e->getMessage()
                ), $index);

It seems like $index can also be of type string; however, parameter $context of Illuminate\Support\Facades\Log::error() does only seem to accept array, maybe add an additional type check?

            }
        }
    }
}