PeekCommand::configure() - Code Metrics - treehouselabs/worker-bundle - Measure and Improve Code Quality continuously with Scrutinizer

PeekCommand::configure() A
last analyzed 2020-02-13 08:40 UTC

↳ Parent: PeekCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	10
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	10
loc	10
ccs	0
cts	10
cp	0
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

namespace TreeHouse\WorkerBundle\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use TreeHouse\WorkerBundle\QueueManager;

class PeekCommand extends Command
{
    /**
     * @var QueueManager
     */
    protected $manager;

    /**
     * @param QueueManager $queueManager
     */
    public function __construct(QueueManager $queueManager)
    {
        $this->manager = $queueManager;

        parent::__construct();
    }

    /**
     * @inheritdoc
     */
    protected function configure()

    {
        $this
            ->setName('worker:peek')
            ->addArgument('action', InputArgument::OPTIONAL | InputArgument::IS_ARRAY, 'Selects which actions to peek for. Defaults to all actions')
            ->addOption('state', null, InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY, 'The state of job to peek for. Valid options are <comment>ready</comment>, <comment>delayed</comment> and <comment>buried</comment>.', ['ready'])
            ->setDescription('Peeks the next job from the queue')
            ->setHelp('Inspects the next job from the queue for one or more actions. Note that this does not reserve the job, so it will still be given to a worker if/once it\'s ready.')
        ;
    }

    /**
     * @inheritdoc
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $actions = $input->getArgument('action');
        if (empty($actions)) {
            $actions = array_keys($this->manager->getExecutors());
        }

        $states = $input->getOption('state');

        foreach ($actions as $action) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $output->writeln(sprintf('Action: <info>%s</info>', $action));

            $table = new Table($output);
            $table->setHeaders(['state', 'id', 'data']);
            foreach ($states as $state) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $job = $this->manager->peek($action, $state);

                if (is_null($job)) {
                    $table->addRow([$state, '-', '-']);
                } else {
                    $table->addRow([$state, $job->getId(), $job->getData()]);
                }
            }

            $table->render();
            $output->writeln('');
        }
    }
}


1		<?php
2
3		namespace TreeHouse\WorkerBundle\Command;
4
5		use Symfony\Component\Console\Command\Command;
6		use Symfony\Component\Console\Helper\Table;
7		use Symfony\Component\Console\Input\InputArgument;
8		use Symfony\Component\Console\Input\InputInterface;
9		use Symfony\Component\Console\Input\InputOption;
10		use Symfony\Component\Console\Output\OutputInterface;
11		use TreeHouse\WorkerBundle\QueueManager;
12
13		class PeekCommand extends Command
14		{
15		/**
16		* @var QueueManager
17		*/
18		protected $manager;
19
20		/**
21		* @param QueueManager $queueManager
22		*/
23		public function __construct(QueueManager $queueManager)
24		{
25		$this->manager = $queueManager;
26
27		parent::__construct();
28		}
29
30		/**
31		* @inheritdoc
32		*/
33	View Code Duplication	protected function configure()
		0 ignored issues – show Duplication introduced 2017-09-29 08:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$this
36		->setName('worker:peek')
37		->addArgument('action', InputArgument::OPTIONAL \| InputArgument::IS_ARRAY, 'Selects which actions to peek for. Defaults to all actions')
38		->addOption('state', null, InputOption::VALUE_OPTIONAL \| InputOption::VALUE_IS_ARRAY, 'The state of job to peek for. Valid options are <comment>ready</comment>, <comment>delayed</comment> and <comment>buried</comment>.', ['ready'])
39		->setDescription('Peeks the next job from the queue')
40		->setHelp('Inspects the next job from the queue for one or more actions. Note that this does not reserve the job, so it will still be given to a worker if/once it\'s ready.')
41		;
42		}
43
44		/**
45		* @inheritdoc
46		*/
47		protected function execute(InputInterface $input, OutputInterface $output)
48		{
49		$actions = $input->getArgument('action');
50		if (empty($actions)) {
51		$actions = array_keys($this->manager->getExecutors());
52		}
53
54		$states = $input->getOption('state');
55
56		foreach ($actions as $action) {
		0 ignored issues – show Bug introduced 2018-12-06 16:02 UTC by Report Bug Copy Issue Report The expression `$actions` of type `string\|array<integer,integer\|string>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
57		$output->writeln(sprintf('Action: <info>%s</info>', $action));
58
59		$table = new Table($output);
60		$table->setHeaders(['state', 'id', 'data']);
61		foreach ($states as $state) {
		0 ignored issues – show Bug introduced 2018-12-06 16:02 UTC by Report Bug Copy Issue Report The expression `$states` of type `string\|array<integer,string>\|boolean\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
62		$job = $this->manager->peek($action, $state);
63
64		if (is_null($job)) {
65		$table->addRow([$state, '-', '-']);
66		} else {
67		$table->addRow([$state, $job->getId(), $job->getData()]);
68		}
69		}
70
71		$table->render();
72		$output->writeln('');
73		}
74		}
75		}
76

treehouselabs / worker-bundle

PeekCommand::configure() A last analyzed 2020-02-13 08:40 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

PeekCommand::configure() A
last analyzed 2020-02-13 08:40 UTC