BackoffStrategy::retry() - Code Metrics - treehouselabs/queue - Measure and Improve Code Quality continuously with Scrutinizer

BackoffStrategy::retry() A
last analyzed 2020-09-08 14:30 UTC

↳ Parent: BackoffStrategy

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	5
cp	1
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	3
crap	1

<?php

namespace TreeHouse\Queue\Processor\Retry;

use TreeHouse\Queue\Amqp\EnvelopeInterface;
use TreeHouse\Queue\Message\Message;
use TreeHouse\Queue\Message\Publisher\MessagePublisherInterface;

/**
 * Retries a message, but with an increasing delay for every attempt.
 */
class BackoffStrategy extends AbstractStrategy
{
    /**
     * @var MessagePublisherInterface
     */
    protected $publisher;

    /**
     * @var int
     */
    protected $cooldownTime;

    /**
     * @param MessagePublisherInterface $publisher
     * @param int                       $cooldownTime
     */
    public function __construct(MessagePublisherInterface $publisher, $cooldownTime = 600)
    {
        $this->publisher = $publisher;
        $this->cooldownTime = $cooldownTime;
    }

    /**
     * @param int $cooldownTime
     */
    public function setCooldownTime($cooldownTime)
    {
        $this->cooldownTime = $cooldownTime;
    }

    /**
     * @return int
     */
    public function getCooldownTime()
    {
        return $this->cooldownTime;
    }

    /**
     * @inheritdoc
     */
    public function retry(EnvelopeInterface $envelope, $attempt, \Exception $exception = null)
    {
        $message = $this->createRetryMessage($envelope, $attempt, $exception);

        // multiply cooldown time by the attempt number,
        $cooldownTime = $attempt * $this->cooldownTime;
        $cooldownDate = \DateTime::createFromFormat('U', (time() + $cooldownTime));

        return $this->publisher->publish($message, $cooldownDate);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
    }
}


1		<?php
2
3		namespace TreeHouse\Queue\Processor\Retry;
4
5		use TreeHouse\Queue\Amqp\EnvelopeInterface;
6		use TreeHouse\Queue\Message\Message;
7		use TreeHouse\Queue\Message\Publisher\MessagePublisherInterface;
8
9		/**
10		* Retries a message, but with an increasing delay for every attempt.
11		*/
12		class BackoffStrategy extends AbstractStrategy
13		{
14		/**
15		* @var MessagePublisherInterface
16		*/
17		protected $publisher;
18
19		/**
20		* @var int
21		*/
22		protected $cooldownTime;
23
24		/**
25		* @param MessagePublisherInterface $publisher
26		* @param int $cooldownTime
27		*/
28	1	public function __construct(MessagePublisherInterface $publisher, $cooldownTime = 600)
29		{
30	1	$this->publisher = $publisher;
31	1	$this->cooldownTime = $cooldownTime;
32	1	}
33
34		/**
35		* @param int $cooldownTime
36		*/
37		public function setCooldownTime($cooldownTime)
38		{
39		$this->cooldownTime = $cooldownTime;
40		}
41
42		/**
43		* @return int
44		*/
45		public function getCooldownTime()
46		{
47		return $this->cooldownTime;
48		}
49
50		/**
51		* @inheritdoc
52		*/
53	1	public function retry(EnvelopeInterface $envelope, $attempt, \Exception $exception = null)
54		{
55	1	$message = $this->createRetryMessage($envelope, $attempt, $exception);
56
57		// multiply cooldown time by the attempt number,
58	1	$cooldownTime = $attempt * $this->cooldownTime;
59	1	$cooldownDate = \DateTime::createFromFormat('U', (time() + $cooldownTime));
60
61	1	return $this->publisher->publish($message, $cooldownDate);
		0 ignored issues – show Security Bug introduced 2016-02-23 12:17 UTC by Report Bug Copy Issue Report It seems like `$cooldownDate` defined by `\DateTime::createFromFor...time() + $cooldownTime)` on line `59` can also be of type `false`; however, `TreeHouse\Queue\Message\...herInterface::publish()` does only seem to accept `null\|object<DateTime>`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
62		}
63		}
64

treehouselabs / queue

BackoffStrategy::retry() A last analyzed 2020-09-08 14:30 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

BackoffStrategy::retry() A
last analyzed 2020-09-08 14:30 UTC